[Differential] [Request, 204 lines] D4264: redesign android-file-transfer icon

varlesh created this revision. varlesh added reviewers: andreask, Breeze. varlesh set the repository for this revision to R266 Breeze Icons. varlesh added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Compare: F2163528: Снимок экрана от 2017-01-

[Differential] [Updated, 286 lines] D4253: redesign gwenview icon

varlesh updated this revision to Diff 10479. varlesh added a comment. version 2, diff updated REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4253?vs=10458&id=10479 REVISION DETAIL https://phabricator.kde.org/D4253 AFFECTED FILES icons/apps/48/gwe

[Differential] [Updated] D4262: redesign android-studio icon

varlesh updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4262 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, andreask, #breeze Cc: #frameworks

[Differential] [Request, 730 lines] D4262: redesign android-studio icon

varlesh created this revision. varlesh added reviewers: andreask, Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - fix wrong size icon - fix c

[Differential] [Request, 36 lines] D4261: redesign atom icon

varlesh created this revision. varlesh added reviewers: andreask, Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Compare: F2163472: Снимок экр

[Differential] [Request, 359 lines] D4260: fix bitcoin128 icon

varlesh created this revision. varlesh added reviewers: andreask, Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - change color pallete (used fo

[Differential] [Request, 259 lines] D4259: fix alienarena icon

varlesh created this revision. varlesh added reviewers: andreask, Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - reverse gradient - change o

[Differential] [Request, 167 lines] D4258: redesign gimp icon

varlesh created this revision. varlesh added reviewers: andreask, Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Papirus icon not a Breeze style

[Differential] [Commented On] D4253: redesign gwenview icon

varlesh added a comment. For compare: F2163339: Снимок экрана от 2017-01-24 08-33-37.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Commented On] D4253: redesign gwenview icon

varlesh added a comment. Ok, but maybe this? New: F2163321: Снимок экрана от 2017-01-24 08-26-22.png SVG: F2163329: gwenview.svg Oxygen: F2163324: gwenview.png REPO

[Differential] [Commented On] D4234: Change algorithm for autobrace.

brauch added a comment. Let's discuss an alternative suggestion maybe: how about it just keeps track of the parenthesis balancing and removes them if doing so would make it unbalanced? It could stop counting at the next folding region, and exclude spellchecked parts. REPOSITORY R39 KTextE

[Differential] [Commented On] D4253: redesign gwenview icon

andreaska added a comment. first of all, thanks for starting the discussion I think also that the gwenview icon could get an update, but I miss something in the update in addition the dark eye background look to hard. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.

Re: Review Request 129315: Don't install plasmoid desktop files as services

> On Jan. 23, 2017, 8:10 p.m., Albert Astals Cid wrote: > > Any reason this has not been committed? Yes, IIRC the KService usage in KRunner was reintroduced. We need to retest the patch now. - Aleix --- This is an automatically generat

[Differential] [Accepted] D4257: [PlasmaComponents Menu] Add maximumWidth property

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4257 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Accepted] D4252: fix brackets icon

andreaska accepted this revision. andreaska added a reviewer: andreaska. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varle

[Differential] [Commented On] D4252: fix brackets icon

andreaska added a comment. I submitt the icon thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreaska Cc: guoyunhe, #frameworks

[Differential] [Accepted] D4251: Redesign aptana icon

andreaska accepted this revision. andreaska added a reviewer: andreaska. andreaska added a comment. This revision is now accepted and ready to land. submitted REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4251 EMAIL PREFERENCES https://phabricator.kde.org/se

[Differential] [Request, 62 lines] D4257: [PlasmaComponents Menu] Add maximumWidth property

broulik created this revision. broulik added reviewers: Plasma, hpereiradacosta. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 398 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/398/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 Jan 2017 21:18:14 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 398 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/398/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 Jan 2017 21:18:14 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name: (root) Failed:

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 229 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/229/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 Jan 2017 20:04:47 + Build duration: 4 min 15 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 225 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/225/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 Jan 2017 19:52:22 + Build duration: 6 min 27 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 221 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/221/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 Jan 2017 19:35:40 + Build duration: 1 min 41 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 221 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/221/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 Jan 2017 19:35:40 + Build duration: 1 min 41 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 121 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/121/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 23 Jan 2017 19:08:54 + Build duration: 8 min 15 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129083/#review102224 --- Patch doesn't apply anymore - Albert Astals Cid On Oct. 6

Re: Review Request 129315: Don't install plasmoid desktop files as services

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/#review102223 --- Any reason this has not been committed? - Albert Astals Cid

[Differential] [Updated] D4253: redesign gwenview icon

mck182 added a reviewer: andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4253 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze, andreask Cc: #frameworks

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129724/ --- (Updated Jan. 23, 2017, 7:04 p.m.) Status -- This change has been ma

Re: Review Request 129859: Add benchmark for KTextToHTML::convertToHtml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129859/ --- (Updated Jan. 23, 2017, 7:03 p.m.) Status -- This change has been ma

[Differential] [Closed] D4203: Fix appstream name/summary ends with '.' warning

This revision was automatically updated to reflect the committed changes. Closed by commit R290:3b0ee7dcf3fd: Fix appstream name/summary ends with '.' warning (authored by apol). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4203?vs=10358&id=10464 REVISION

[Differential] [Updated, 285 lines] D4254: add new test for scalable exposure

sitter updated this revision to Diff 10460. sitter added a comment. warning-- qdebug the limited testing of the test REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4254?vs=10459&id=10460 BRANCH master REVISION DETAIL https://phabricator.kde.org

[Differential] [Request, 286 lines] D4254: add new test for scalable exposure

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY the icon themes use SVG but do not want the same icon to be used for small resolutions as to not have high-detail icons at super small sizes

[Differential] [Request, 269 lines] D4253: redesign gwenview icon

varlesh created this revision. varlesh added a reviewer: Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - colorize - add shadows - pixelated

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

apol added a comment. Please disregard the last message, I didn't mean to send that, I wrote it some days ago. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

apol added inline comments. INLINE COMMENTS > dfaure wrote in kcrash.cpp:437 > You can't use QVector here. We're crashing, likely due to corrupted memory, > the whole point of this code is to NOT do any memory allocation. You should > revert to const char*[], or use something that always alloca

[Differential] [Changed Subscribers] D4214: Make sure we display enabled ListItem on hover

mart added inline comments. INLINE COMMENTS > apol wrote in ListItem.qml:97 > Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain... > > It's barely a behavioral change, in fact it's what it was supposed to happen > in the first place: give feedback on hover when the item

[Differential] [Accepted] D4203: Fix appstream name/summary ends with '.' warning

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D4203 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #

[Differential] [Commented On] D4252: fix brackets icon

guoyunhe added a comment. Like this REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze Cc: guoyunhe, #frameworks

[Differential] [Updated] D4252: fix brackets icon

varlesh updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4252 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze Cc: #frameworks

[Differential] [Request, 1,206 lines] D4252: fix brackets icon

varlesh created this revision. varlesh added a reviewer: Breeze. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY F2162612: brackets.svg

[Differential] [Closed] D4227: Don't block when running the post-install command

This revision was automatically updated to reflect the committed changes. Closed by commit R304:3178240748c6: Don't block when running the post-install command (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4227?vs=10396&id=10455#toc REPOSITORY R304 KNewStuff CHANG

[Differential] [Updated] D4227: Don't block when running the post-install command

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in installation.cpp:351 > I had to look multiple times to find what "f" is, can you make the name a bit > more descriptive. Good point. Will address this as I commit it. REPOSITORY R304 KNewStu

[Differential] [Updated] D4251: Redesign aptana icon

varlesh updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze Cc: #frameworks

[Differential] [Updated] D4251: Redesign aptana icon

varlesh added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh, #breeze Cc: #frameworks

[Differential] [Updated] D4251: Redesign aptana icon

varlesh updated the summary for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4251 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: varlesh Cc: #frameworks

[Differential] [Request, 203 lines] D4251: Redesign aptana icon

varlesh created this revision. varlesh set the repository for this revision to R266 Breeze Icons. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D4251 AFFECTED

[Differential] [Changed Subscribers] D4227: Don't block when running the post-install command

broulik added inline comments. INLINE COMMENTS > installation.cpp:351 > +QProcess* p = runPostInstallationCommand(installedFiles.size() == 1 > ? installedFiles.first() : targetPath); > +connect(p, static_cast(&QProcess::finished), > this, f); > +} else { I had to look multi

[Differential] [Accepted] D4227: Don't block when running the post-install command

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > apol wrote in installation.h:137 > According to our BIC documentation: > https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > > We can "remove pri

[Differential] [Updated] D4227: Don't block when running the post-install command

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > mart wrote in installation.h:137 > BIC > even if the api of this file is beyond terrible, unfortunately it's exported, > so no binary incompatible changes should occur According to our BIC documentation: https

[Differential] [Requested Changes To] D4227: Don't block when running the post-install command

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > installation.h:137 > QStringList installDownloadedFileAndUncompress(const > KNSCore::EntryInternal &entry, const QString &payloadfile, const QString > inst

[Differential] [Closed] D4226: [KNS] Take into account the distribution type

This revision was automatically updated to reflect the committed changes. Closed by commit R304:d283d9f951fb: [KNS] Take into account the distribution type (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4226?vs=10394&id=10449 REVISION DE

[Differential] [Accepted] D4226: [KNS] Take into account the distribution type

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Yup, this is fairly clearly what this is really supposed to be doing... REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4226 EMAIL PREFERENCES

[Differential] [Commented On] D4190: Update file type on save only if path changes

mperttunen added a comment. Good point, I missed that. I'll post a new revision once I have the chance. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4190 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mperttunen, #ktextedi