[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in ListItem.qml:97 > Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain... > > It's barely a behavioral change, in fact it's what it was supposed to happen > in the first place: give feedback on hover whe

[Differential] [Updated, 16 lines] D4214: Make sure we display enabled ListItem on hover

apol updated this revision to Diff 10379. apol marked an inline comment as done. apol added a comment. Address David's comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4214?vs=10372&id=10379 BRANCH master REVISION DETAIL https

[Differential] [Updated] D4214: Make sure we display enabled ListItem on hover

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > davidedmundson wrote in ListItem.qml:97 > why are you now following containsMouse. That's a behavioural change > > How can background.pressed be true. I don't see where it exists? > do you mean itemMouse.pressed

[Differential] [Updated, 312 lines] D4201: Make it possible to lower KCrash to tier 1

apol updated this revision to Diff 10377. apol added a comment. Dropped usage of QMap and QVector from the handler Still using QPluginLoader and QDirIterator which probably are as bad as those. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4201?vs=1036

[Differential] [Updated] D4213: Mark non-persistent notifications as transient.

apol added a reviewer: Plasma. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4213 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks, #plasma Cc: #frameworks

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

davidedmundson added a comment. Concept seems fine. New binding has some typos INLINE COMMENTS > ListItem.qml:97 > +prefix: (listItem.sectionDelegate ? "section" : > +(background.pressed || listItem.checked || > listItem.containsMouse) ? "pressed" : "normal") > why

[Differential] [Closed] D4151: Port to categorized logging

This revision was automatically updated to reflect the committed changes. Closed by commit R243:c1638e121d4a: Port to categorized logging (authored by ltoscano). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4151?vs=10198&id=10375#toc REPOSITORY R243 KArchive CHANGES SINCE LAST UPDAT

Re: [kde-dev-scripts/Applications/16.12] /: Add a script to run uncrustify for source code reformatting.

On jeudi 19 janvier 2017 22:49:07 CET Albert Astals Cid wrote: > This is a new application in a stable branch. Application is a big word for a script, but OK, I'll remove it. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

[Differential] [Accepted] D4151: Port to categorized logging

dfaure accepted this revision. dfaure added a reviewer: dfaure. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D4151 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: l

[Differential] [Request, 16 lines] D4214: Make sure we display enabled ListItem on hover

apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY I just realized there was a weird workaround in plasma-nm where it gets checked so it's sho

[Differential] [Updated] D4213: Mark non-persistent notifications as transient.

albertvaka added a reviewer: Frameworks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4213 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka, #frameworks Cc: #frameworks

[Differential] [Request, 4 lines] D4213: Mark non-persistent notifications as transient.

albertvaka created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On Gnome and other desktops using their extension of the notifications spec, notifications are persistent unless they set the transient

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 316 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/316/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 19 Jan 2017 22:19:20 + Build duration: 14 min CHANGE SET Revision 1d12abf

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 316 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/316/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 19 Jan 2017 22:19:20 + Build duration: 14 min CHANGE SET Revision 1d12abf

Re: [kde-dev-scripts/Applications/16.12] /: Add a script to run uncrustify for source code reformatting.

This is a new application in a stable branch. I'm sure distributions are going to love it. Cheers, Albert El dijous, 19 de gener de 2017, a les 10:27:49 CET, David Faure va escriure: > Git commit e93a28b3eb153695e8edb7ae259243b7b409a29d by David Faure. > Committed on 16/01/2017 at 19:13. > Pus

Re: Review Request 129609: utils.js: Escape backslash in i18n string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129609/#review102103 --- Fsck, gettext incorrectly extracts "\s" as "s". - Alexander

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

bcooksley updated the test plan for this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure Cc: anthonyfieroni, graesslin

Re: platform theme tinkering on Mac (to anyone doing/using KF5 builds on Mac)

On Thursday January 19 2017 18:05:26 René J.V. Bertin wrote: > There are a few build options, but the one you'll want to activate is > OVERRIDE_NATIVE_THEME . Without that you'll have to set QT_QPA_PLATFORMTHEME=kde in the environment. I just managed to build the plugin against a stock Qt 5.8.0

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kcrash.cpp:437 > You have a comment to follow :) You can't use QVector here. We're crashing, likely due to corrupted memory, the whole point of this code is to NOT do any memory allocation. You should revert to const char*

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

apol marked an inline comment as done. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure Cc: anthonyfieroni, graesslin

[Differential] [Updated, 325 lines] D4201: Make it possible to lower KCrash to tier 1

apol updated this revision to Diff 10363. apol added a comment. Use QVector instead of const char*[] REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4201?vs=10353&id=10363 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4201 AFFECTED FILES

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

graesslin added a comment. In https://phabricator.kde.org/D4201#78639, @apol wrote: > In https://phabricator.kde.org/D4201#78631, @graesslin wrote: > > > I don't understand why a plugin architecture allows to move it to tier1. Is functionality split out? if yes, how does that help?

[Differential] [Closed] D4144: Install also CamelCase forward headers for classes from multi-class headers

This revision was automatically updated to reflect the committed changes. Closed by commit R236:1473382cbd22: Install also CamelCase forward headers for classes from multi-class headers (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Closed] D4137: API dox: Add @class comment with CamelCase include, image title without KDE

This revision was automatically updated to reflect the committed changes. Closed by commit R236:0070f76418c0: API dox: Add @class comment with CamelCase include, image title without KDE (authored by kossebau). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

lcroft updated the test plan for this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure Cc: anthonyfieroni, graesslin

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

lcroft updated the test plan for this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure Cc: anthonyfieroni, graesslin

[Differential] [Request, 24 lines] D4203: Fix appstream name/summary ends with '.' warning

apol created this revision. apol added reviewers: Plasma, davidedmundson. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Drops the dot on these tags, possibly the right patch would be to fix the tr

[Differential] [Changed Subscribers] D4201: Make it possible to lower KCrash to tier 1

anthonyfieroni added inline comments. INLINE COMMENTS > kcrash.cpp:437 > > const char *argv[29]; // don't forget to update this > int i = 0; You have a comment to follow :) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES ht

platform theme tinkering on Mac (to anyone doing/using KF5 builds on Mac)

Hello! I know we don't have strictly identical ideas on how KF5 applications should look on Mac. Still, I think it might amuse some of you to check out a platform theme plugin that allows applications to use the different font "roles" and default colour and icon palettes -- provided it works wi

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

apol added a comment. In https://phabricator.kde.org/D4201#78631, @graesslin wrote: > I don't understand why a plugin architecture allows to move it to tier1. Is functionality split out? if yes, how does that help? Ah, you are right, I forgot to mention it. I thought about this pr

Re: Review Request 129609: utils.js: Escape backslash in i18n string

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129609/ --- (Updated Jan. 19, 2017, 4:09 p.m.) Status -- This change has been ma

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

graesslin added a comment. I don't understand why a plugin architecture allows to move it to tier1. Is functionality split out? if yes, how does that help? INLINE COMMENTS > kstartupinfoplugin.cpp:26 > +{ > +Q_OBJECT\ > +Q_PLUGIN_METADATA(IID "org.kde.KCrashHandlerPlugin") is the \

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

> On Jan. 19, 2017, 5:36 p.m., Stefan Brüns wrote: > > src/extractorcollection.cpp, line 155 > > > > > > This is broken: > > > > if (plugins.isEmpty()) { > > ... > > for (; it != d->m_extract

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129720/#review102096 --- src/extractorcollection.cpp (line 155)

[Differential] [Request, 281 lines] D4201: Make it possible to lower KCrash to tier 1

apol created this revision. apol added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY Puts in place a plugin system that exposes API to extract information to send the handler. This allows us to de-couple from different modules that need t

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

apol updated the summary for this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D4201 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 315 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/315/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 19 Jan 2017 13:30:56 + Build duration: 4 min 13 sec CHANGE SET Revision

[Differential] [Closed] D4065: Don't ask if we're getting the file in /tmp

This revision was automatically updated to reflect the committed changes. Closed by commit R304:2d6dc495fbe9: Don't ask if we're getting the file in /tmp (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4065?vs=9968&id=10350 REVISION DETAI

Re: knewstuff's gpg use

On Thu, Jan 19, 2017 at 12:58 PM, Harald Sitter wrote: > Morning, > > I had the most peculiar incident just now. KNewstuff shouted at me > because I have no bin/gpg(2). As it turns out core/security.cpp > implements some form of gpg signing verification. Based on the gpg CLI > app. > > Naturally,

knewstuff's gpg use

Morning, I had the most peculiar incident just now. KNewstuff shouted at me because I have no bin/gpg(2). As it turns out core/security.cpp implements some form of gpg signing verification. Based on the gpg CLI app. Naturally, I am perplexed by this because CMake doesn't actually report gpg as a

[Differential] [Accepted] D4065: Don't ask if we're getting the file in /tmp

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Go for it REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4065 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

mart added a comment. -1 on this.. wallpaper packagestructure is indeed very weird (it makes it so that a simple jpg is considered as a valid package.. is how the model for thumbnails works, which would be a good idea to change a little) , and that's why those warnings REPOSITORY R290 KP

[kde-dev-scripts/Applications/16.12] /: Add a script to run uncrustify for source code reformatting.

Git commit e93a28b3eb153695e8edb7ae259243b7b409a29d by David Faure. Committed on 16/01/2017 at 19:13. Pushed by dfaure into branch 'Applications/16.12'. Add a script to run uncrustify for source code reformatting. This does a better job than astyle-kdelibs, which I now consider deprecated. CCMAI

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 222 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/222/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 08:52:51 + Build duration: 5 min 34 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

marten added a comment. Agreed that a decision needs to be made, but I'm not an expert on the KPackage system and so wasn't sure whether the warning may be useful to package developers in some cases - in which case leaving it commented out would make it easier to reinstate than removing it e

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 170 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/170/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 08:52:19 + Build duration: 2 min 33 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 170 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/170/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 Jan 2017 08:52:19 + Build duration: 2 min 33 sec CHANGE SET No changes JUNIT RESULTS Name