Re: Review Request 129779: Fix oxygen icons duplicates test

2017-01-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129779/#review101857 --- Andreas pushed an identical change anyway whilst this was wa

Re: Review Request 129779: Fix oxygen icons duplicates test

2017-01-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129779/ --- (Updated Jan. 8, 2017, 1:34 a.m.) Status -- This change has been dis

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

2017-01-07 Thread Albert Astals Cid
> On Jan. 7, 2017, 7:10 p.m., Albert Astals Cid wrote: > > I don't know what "Scroll is now smooth in the Authors tab of the about > > dialog." > > > > But if i compare Qt 5.7.1 with this patch and Qt 5.6.1, they are different > > reacting to the wheel. > > > > "Qt 5.7.1 with this patch" is m

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 185 - Unstable!

2017-01-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/185/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 00:55:12 + Build duration: 6 min 10 sec CHANGE SET No changes JUNIT RESULTS Na

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 188 - Still Unstable!

2017-01-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/188/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 08 Jan 2017 00:51:31 + Build duration: 2 min 12 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

[Differential] [Closed] D4006: kcoreaddons: Fix clang documentation warnings

2017-01-07 Thread mpyne (Michael Pyne)
This revision was automatically updated to reflect the committed changes. Closed by commit R244:3819c0a32e21: apidox: Correct Doxygen errors reported by clang -Wdocumentation. (authored by mpyne). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4006?vs=9829

[Differential] [Accepted] D4006: kcoreaddons: Fix clang documentation warnings

2017-01-07 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4006 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mpyne, #frameworks, a

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-07 Thread René J . V . Bertin
On Saturday January 07 2017 13:32:22 René J.V. Bertin wrote: > After saving the shortcuts to the current scheme and restarting the app: > - the shortcut is shown as Command+< > - it no longer works In fact, that was testing in KDevelop, which has a hardcoded Ctrl+< shortcut for the (popup menu)

[Differential] [Request, 6 lines] D4006: kcoreaddons: Fix clang documentation warnings

2017-01-07 Thread mpyne (Michael Pyne)
mpyne created this revision. mpyne added a reviewer: Frameworks. mpyne set the repository for this revision to R244 KCoreAddons. Restricted Application added a project: Frameworks. REVISION SUMMARY This change corrects some minor API documentation errors in KCoreAddons noted by Kevin Funk when

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

2017-01-07 Thread Elvis Angelaccio
> On Jan. 7, 2017, 7:10 p.m., Albert Astals Cid wrote: > > I don't know what "Scroll is now smooth in the Authors tab of the about > > dialog." > > > > But if i compare Qt 5.7.1 with this patch and Qt 5.6.1, they are different > > reacting to the wheel. > > > > "Qt 5.7.1 with this patch" is m

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac : isShiftAsModifierAllowed() involved.

2017-01-07 Thread René J . V . Bertin
Looking over the kxmlgui code I notice isShiftAsModifierAllowed(), from KWindowSystem. Have there been recent changes in that function or its use in other places Applying the patch below has the following effect: - Command+Shift+, (Command+<) is shown as Command+Shift+, in the shortcut editor -

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 417 - Fixed!

2017-01-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/417/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:44:06 + Build duration: 3 min 28 sec CHANGE SET Revision 003d7cac31ee5788aa5c0bd2c467bb8b2

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 415 - Fixed!

2017-01-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/415/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:44:07 + Build duration: 3 min 17 sec CHANGE SET Revision 003d7cac31ee5788aa5c0bd2c4

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 417 - Fixed!

2017-01-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/417/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:44:06 + Build duration: 3 min 28 sec CHANGE SET Revision 003d7cac31ee5788aa5c0bd2c467bb8b2

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 415 - Fixed!

2017-01-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/415/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 20:44:07 + Build duration: 3 min 17 sec CHANGE SET Revision 003d7cac31ee5788aa5c0bd2c4

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 416 - Still Unstable!

2017-01-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/416/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 19:09:38 + Build duration: 19 min CHANGE SET Revision 438730736c7e47333cce78bb6d897c3d5fc0c8

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 414 - Still Unstable!

2017-01-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/414/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 19:09:38 + Build duration: 4 min 13 sec CHANGE SET Revision 438730736c7e47333cce78bb6

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

2017-01-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129694/#review101851 --- I don't know what "Scroll is now smooth in the Authors tab o

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-07 Thread René J . V . Bertin
On Saturday January 7 2017 19:33:13 Albert Astals Cid wrote: >You're a developer, you can reproduce the problem in one version and not in >another, instead of workarounding the problem you should bisect it until you >find where it broke. Sure, that's what I'd have done with my own code, and wha

Re: Fwd: Qt 5.7+ and Command+Shift shortcuts on Mac

2017-01-07 Thread Albert Astals Cid
El divendres, 6 de gener de 2017, a les 21:29:13 CET, René J.V. Bertin va escriure: > On Friday January 06 2017 18:33:01 David Faure wrote: > > Well, you didn't say either way, so I tried to guess from your > > description, > > and guessed wrong. > > No problem, can't be right all the time (and i

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 369 - Fixed!

2017-01-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/369/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 18:30:26 + Build duration: 1 min 26 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 369 - Fixed!

2017-01-07 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/369/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 18:30:26 + Build duration: 1 min 26 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Commented On] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

2017-01-07 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. In https://phabricator.kde.org/D4003#74814, @cullmann wrote: > Guess the wrong naming is my fault, fixing that is a good idea. > Perhaps for the mode line, just add the "byte-order-mark" as alternative (and keep the old one to be compatible)? For now j

[Differential] [Commented On] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

2017-01-07 Thread cullmann (Christoph Cullmann)
cullmann added a comment. Guess the wrong naming is my fault, fixing that is a good idea. Perhaps for the mode line, just add the "byte-order-mark" as alternative (and keep the old one to be compatible)? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4003 EMAI

[Differential] [Request, 31 lines] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

2017-01-07 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added a reviewer: Kate. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY The official names are "byte order mark" and "Unicode". Also consistently use "(BOM)" add

[Differential] [Commented On] D4003: Fix "byte order marker" -> "byte order mark", use upper-case "Unicode" name

2017-01-07 Thread kossebau (Friedrich W. H. Kossebau)
kossebau added a comment. For KF 30+, to give translators a chance. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4003 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #kate Cc: kwrite-devel, #frameworks

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 413 - Unstable!

2017-01-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/413/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 14:46:37 + Build duration: 2 min 29 sec CHANGE SET Revision 7e4cebe64227ea7046a3e4f7e

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 415 - Unstable!

2017-01-07 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/415/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 07 Jan 2017 14:46:37 + Build duration: 2 min 37 sec CHANGE SET Revision 7e4cebe64227ea7046a3e4f7e0492451