[Differential] [Accepted] D3696: Search for the more precise required version of AppstreamQt

2016-12-15 Thread lbeltrame (Luca Beltrame)
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM. Although, can we expect AppStreamQt to at least avoid breaking SIC in minor releases? Otherwise this problem will appear again... REPOSITORY R252 Framework Integration BRANCH

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101464 --- Ship it! Thanks for working on this! I noticed that I co

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101463 --- Ship it! Ship It! - Stephen Kelly On Dec. 15, 2016, 11

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-12-15 Thread thiago (Thiago Macieira)
thiago added a comment. More information on this Windows behaviour: - https://blogs.msdn.microsoft.com/oldnewthing/20070503-00/?p=27003 - https://blogs.msdn.microsoft.com/oldnewthing/20070502-00/?p=27023/#2375204 There doesn't seem to be a way of doing some clean up before the threa

[Differential] [Updated] D3696: Search for the more precise required version of AppstreamQt

2016-12-15 Thread ltoscano (Luigi Toscano)
ltoscano set the repository for this revision to R252 Framework Integration. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D3696 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, lbeltrame

[Differential] [Request, 2 lines] D3696: Search for the more precise required version of AppstreamQt

2016-12-15 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Frameworks, lbeltrame. REVISION SUMMARY With versions older than 0.10.4 it won't compile BRANCH master REVISION DETAIL https://phabricator.kde.org/D3696 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/setti

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 337 - Fixed!

2016-12-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/337/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:46 + Build duration: 5 min 15 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 337 - Fixed!

2016-12-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/337/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:46 + Build duration: 5 min 15 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 336 - Fixed!

2016-12-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/336/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:49 + Build duration: 1 min 31 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 336 - Fixed!

2016-12-15 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/336/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:49 + Build duration: 1 min 31 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-12-15 Thread thiago (Thiago Macieira)
thiago added a comment. In https://phabricator.kde.org/D2545#69083, @kfunk wrote: > > Here's the other problem: it's possible for threads to simply disappear on Windows. Given that I see "dllmain" in the backtrace (though not DllMain), I can't rule out that this has happened. Qt 5.6 has

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

2016-12-15 Thread kfunk (Kevin Funk)
kfunk added a comment. > Here's the other problem: it's possible for threads to simply disappear on Windows. Given that I see "dllmain" in the backtrace (though not DllMain), I can't rule out that this has happened. Qt 5.6 has a workaround to another deadlock caused by Windows. Can you try t

Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101460 --- +1 looks good. - Aleix Pol Gonzalez On Dec. 16, 2016, 12:

Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer

2016-12-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmod

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 335 - Still Failing!

2016-12-15 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/335/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Dec 2016 21:33:53 + Build duration: 3 min 32 sec CHANGE SET No changes

[Differential] [Accepted] D3636: [kconfig_compiler] Improve documentation about Inherits

2016-12-15 Thread dfaure (David Faure)
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH inherits-readme-improvement REVISION DETAIL https://phabricator.kde.org/D3636 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #fr

[Differential] [Updated, 6 lines] D3636: [kconfig_compiler] Improve documentation about Inherits

2016-12-15 Thread Martin Gräßlin
graesslin updated this revision to Diff 9049. graesslin added a comment. Add missing "(" REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3636?vs=9046&id=9049 BRANCH inherits-readme-improvement REVISION DETAIL https://phabricator.kde.org/D3636 AFFECTED

[Differential] [Updated, 674 lines] D3691: Update QMake syntax highlighting file

2016-12-15 Thread kfunk (Kevin Funk)
kfunk updated this revision to Diff 9048. kfunk added a comment. Add generator REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3691?vs=9047&id=9048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3691 AFFECTED FILES data/gener

[Differential] [Updated] D3691: Update QMake syntax highlighting file

2016-12-15 Thread kfunk (Kevin Funk)
kfunk added a reviewer: Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks

[Differential] [Commented On] D3636: [kconfig_compiler] Improve documentation about Inherits

2016-12-15 Thread dfaure (David Faure)
dfaure added inline comments. INLINE COMMENTS > README.dox:112 > + KConfigSkeleton and must provide a default constructor (kcfgfile not > specified), a constructor > + taking a QString argument kcfgfile with "name" attribute) and a > constructor taking a > + KSharedConfig::Ptr as argument (k

[Differential] [Updated, 6 lines] D3636: [kconfig_compiler] Improve documentation about Inherits

2016-12-15 Thread Martin Gräßlin
graesslin updated this revision to Diff 9046. graesslin added a comment. Constructor instead of ctor REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3636?vs=9018&id=9046 BRANCH inherits-readme-improvement REVISION DETAIL https://phabricator.kde.org/D36

[Differential] [Request, 194 lines] D3690: Generate an instance with KSharedConfig::Ptr for singleton and arg

2016-12-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Frameworks, dfaure, mdawson. REVISION SUMMARY In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an alread

[Differential] [Updated] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

2016-12-15 Thread Martin Gräßlin
graesslin retitled this revision from "[runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable" to "KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable". REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Request, 2 lines] D3689: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

2016-12-15 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Frameworks. REVISION SUMMARY The idea behind the env variable is to put kgloabalacceld into test mode and let it operate on a in-memory KConfig instead of the normal rc file. From auto tests in KWin we know that the QStandardP

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-15 Thread Elvis Angelaccio
> On Dec. 14, 2016, 7:21 p.m., Martin Gräßlin wrote: > > If I see correctly we are losing a feature here: blur behind. > > Elvis Angelaccio wrote: > Right, I had to drop that because we cannot use KWindowSystem in tier 1. > Is there a way to achieve the same feature with Qt only? > > Marti

Re: Review Request 129648: New widget: tooltip that contains another widget

2016-12-15 Thread Martin Gräßlin
> On Dec. 14, 2016, 8:21 p.m., Martin Gräßlin wrote: > > If I see correctly we are losing a feature here: blur behind. > > Elvis Angelaccio wrote: > Right, I had to drop that because we cannot use KWindowSystem in tier 1. > Is there a way to achieve the same feature with Qt only? Well ther

Re: Review Request 129260: Add find module for QtPlatformSupport

2016-12-15 Thread Martin Gräßlin
> On Oct. 27, 2016, 7:39 a.m., Martin Gräßlin wrote: > > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding > > to ECM > > David Edmundson wrote: > To this specific patch, or the concept in general? To this specific patch - Martin ---

Review Request 129654: Introduce the resource name in the knsrc file

2016-12-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129654/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 129260: Add find module for QtPlatformSupport

2016-12-15 Thread David Edmundson
> On Oct. 27, 2016, 5:39 a.m., Martin Gräßlin wrote: > > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding > > to ECM To this specific patch, or the concept in general? - David --- This is an automatically gene

Re: Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 334 - Still Failing!

2016-12-15 Thread Aleix Pol
On Thu, Dec 15, 2016 at 7:19 AM, Ben Cooksley wrote: > > On Thu, Dec 15, 2016 at 7:16 PM, wrote: > > > > GENERAL INFO > > > > BUILD FAILURE > > Build URL: > > https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/334/ > > Project: PLATFORM=Linux,co