Re: Fwd: KStandardAction::showMenubar and native menubars

On Wednesday October 12 2016 01:12:14 Marko Käning wrote: > > From: Albert Astals Cid > > My current (yet to implement/test) idea is have > > KStandardAction::showMenubar check all the menubars of the top level > > windows of the app and if they are all marked as native, then return a > > dum

KStandardAction::showMenubar and native menubars

On platforms with native menubars (Mac, Unity) the showMenuBar action makes no sense since the menubar is integrated in the desktop shell instead of the application so the application gains no space by hiding/showing the menubar (sometimes it isn't possible to hide it at all) So on thos platf

Review Request 129155: reviewboard-am: add Python 3 compatibility

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129155/ --- Review request for KDE Frameworks. Repository: kde-dev-scripts Descript

Review Request 129154: reviewboard-am: add marker to ignore following text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129154/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kde-de

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 15, 2016, 8:42 a.m., Martin Gräßlin wrote: > > src/platforms/osx/kwindowsystem_macobjc.mm, line 89 > > > > > > Why is the define needed? Doesn't it make more sense to just not build > > the OSX backend

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote: > > src/kwindowsystem.cpp, lines 465-467 > > > > > > I would prefer to not introduce new platform specific code in the > > shared part. > > > > The i

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 215 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/215/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 11 Oct 2016 15:24:47 + Build duration: 5 min 51 sec CHANGE SET Revision b

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 215 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/215/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 15:24:47 + Build duration: 6 min 6 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 215 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/215/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 11 Oct 2016 15:24:47 + Build duration: 6 min 33 sec CHANGE SET Rev

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 215 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/215/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 15:24:47 + Build duration: 4 min 38 sec CHANGE SET Revisi

Review Request 129150: Use less deprecated API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129150/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 214 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 11 Oct 2016 13:34:16 + Build duration: 8 min 54 sec CHANGE SET Revision b

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 214 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 11 Oct 2016 13:34:16 + Build duration: 8 min 54 sec CHANGE SET Revision b

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 13:34:16 + Build duration: 6 min 38 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 13:34:16 + Build duration: 6 min 38 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 214 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 11 Oct 2016 13:34:16 + Build duration: 6 min 27 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 13:34:16 + Build duration: 2 min 40 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 13:34:16 + Build duration: 2 min 40 sec CHANGE SET Revisi

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/ --- (Updated Oct. 11, 2016, 1:33 p.m.) Status -- This change has been ma

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99935 --- Ship it! Ship It! - Marco Martin On Oct. 10, 2016, 9:48

Re: Review Request 129146: Fix emitting close when an event has no actions

> On Oct. 11, 2016, 12:16 p.m., Anthony Fieroni wrote: > > src/knotificationmanager.cpp, line 203 > > > > > > n->close() > > David Edmundson wrote: > I did think about that, but what if the userspace code is

Re: Review Request 129146: Fix emitting close when an event has no actions

> On Oct. 11, 2016, 3:16 p.m., Anthony Fieroni wrote: > > src/knotificationmanager.cpp, line 203 > > > > > > n->close() > > David Edmundson wrote: > I did think about that, but what if the userspace code is:

Re: Review Request 129146: Fix emitting close when an event has no actions

> On Oct. 11, 2016, 12:16 p.m., Anthony Fieroni wrote: > > src/knotificationmanager.cpp, line 203 > > > > > > n->close() I did think about that, but what if the userspace code is: KNotification *n = new KNoti..

Re: Review Request 129146: Fix emitting close when an event has no actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/#review99930 --- src/knotificationmanager.cpp (line 203)

Review Request 129146: Fix emitting close when an event has no actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129146/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 213 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/213/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 11 Oct 2016 10:32:14 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 213 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/213/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 11 Oct 2016 10:32:14 + Build duration: 2 min 24 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 213 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/213/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 10:32:14 + Build duration: 2 min 17 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 213 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/213/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 11 Oct 2016 10:32:14 + Build duration: 2 min 17 sec CHANGE SE

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 132 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/132/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:55:07 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS Name: (ro

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 130 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:49:57 + Build duration: 1 min 54 sec CHANGE SET No changes JUNIT RESULTS Na

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 129 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/129/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:20:35 + Build duration: 3 min 31 sec CHANGE SET No changes JUNIT RESULTS Na

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 131 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:18:30 + Build duration: 6 min 0 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

Jenkins-kde-ci: kcrash master kf5-qt5 » Linux,gcc - Build # 111 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:18:30 + Build duration: 54 sec CHANGE SET Revision b325b76b86e4376f45749eebd6bc10a2e90e984e by s

Jenkins-kde-ci: kcrash master kf5-qt5 » Linux,gcc - Build # 111 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcrash%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/111/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:18:30 + Build duration: 54 sec CHANGE SET Revision b325b76b86e4376f45749eebd6bc10a2e90e984e by s

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 95 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:11:40 + Build duration: 2 min 30 sec CHANGE SET Revision bc77577d7752e4069b9c7826673585e6c6e

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 95 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:11:40 + Build duration: 2 min 30 sec CHANGE SET Revision bc77577d7752e4069b9c7826673585e6c6e

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124905/#review99926 --- Reposting here, proposing to reopen it. After a while: I thi

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

> On Oct. 11, 2016, 8:52 a.m., Kai Uwe Broulik wrote: > > I have a FolderView applet in my panel (pointing to Downloads folder) and > > it is blank with this patch now. ok, so please don't push this yet - Marco --- This is an automatic

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99923 --- I have a FolderView applet in my panel (pointing to Downloads

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99921 --- Ship it! this version seems to work well - Marco Martin