Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-12 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128219/ --- (Updated Aug. 12, 2016, 12:58 p.m.) Review request for KDE Frameworks, Da

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

2016-08-12 Thread Gregor Mi
> On Feb. 20, 2016, 7:46 p.m., David Faure wrote: > > src/filewidgets/kurlnavigator.h, line 428 > > > > > > Signal names usually end with "ed", they reflect a state change or an > > action change. > > > >

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 175 - Fixed!

2016-08-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/175/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 12 Aug 2016 09:32:40 + Build duration: 19 min CHANGE SET Revision 73496a93c8c5adf1860e462cfbf1acbaf80664a7 by Davi

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 175 - Fixed!

2016-08-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/175/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 12 Aug 2016 09:32:40 + Build duration: 19 min CHANGE SET Revision 73496a93c8c5adf1860e462cfbf1acbaf80664a7 by Davi

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128618/#review98236 --- I don't feel confident about this change, for lack of unit te

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98328 --- Sorry, found two issues. src/declarativeimports/plasmacompo

Re: Review Request 128660: Add an optional reveal password button to TextField

2016-08-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/#review98326 --- Fix it, then Ship it! Neat. Some minor nitpicks below. A

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

2016-08-12 Thread David Faure
> On Feb. 20, 2016, 7:46 p.m., David Faure wrote: > > src/filewidgets/kurlnavigator.h, line 428 > > > > > > Signal names usually end with "ed", they reflect a state change or an > > action change. > > > >

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

2016-08-12 Thread David Faure
> On June 17, 2016, 7:36 a.m., David Faure wrote: > > src/core/installation.cpp, line 379 > > > > > > There are of course other values for targetDirectory which would create > > problems. > > - "//" > >

Review Request 128661: [KTreeWidgetsSearchLineWidget] Use placeholderText instead of separate label

2016-08-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128661/ --- Review request for KDE Frameworks and KDE Usability. Repository: kitemvie