Usage of QNetworkAccessManager

2016-07-13 Thread Ben Cooksley
Hi all, Just my regular reminder regarding usage of QNetworkAccessManager in your applications and libraries, especially when it comes to interacting with kde.org infrastructure. Unfortunately, from it's first iteration in Qt 4 QNetworkAccessManager was shipped with a severe and fundamental defec

Re: Review Request 124811: KIconLoader: speed up hasIcon/iconPath by using the on-disk cache from loadIcon

2016-07-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124811/ --- (Updated July 13, 2016, 10:31 p.m.) Status -- This change has been d

Re: Review Request 128232: The default level for logging categories should be Info rather than Warning.

2016-07-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128232/#review97364 --- +1 - Aleix Pol Gonzalez On July 14, 2016, 12:22 a.m., Davi

Re: Review Request 128232: The default level for logging categories should be Info rather than Warning.

2016-07-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128232/ --- (Updated July 13, 2016, 10:22 p.m.) Review request for Extra Cmake Module

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-13 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128437/#review97363 --- I am opposed to this change, because it spams downstream pack

Re: Review Request 128443: [KAboutKdeDialog] Fix minimum size hint (cut-off text)

2016-07-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128443/#review97362 --- Ship it! Ship It! - David Faure On July 13, 2016, 9:36

Review Request 128443: [KAboutKdeDialog] Fix minimum size hint (cut-off text)

2016-07-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128443/ --- Review request for KDE Frameworks. Bugs: 312667 https://bugs.kde.org/

Re: Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP

2016-07-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120904/#review97358 --- src/kcharselect.h (line 210)

Re: Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP

2016-07-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120904/ --- (Updated July 13, 2016, 9:23 p.m.) Review request for KDE Frameworks and

Re: Review Request 120904: [KCharSelect] [API] Add new methods to handle characters outside BMP

2016-07-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120904/ --- (Updated July 13, 2016, 9:18 p.m.) Review request for KDE Frameworks and

Re: Review Request 128442: [KIconDialog] Allow showing icons from all categories

2016-07-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128442/ --- (Updated July 13, 2016, 8:54 p.m.) Review request for KDE Frameworks. C

Re: Review Request 128442: [KIconDialog] Allow showing icons from all categories

2016-07-13 Thread Christoph Feck
> On July 13, 2016, 8:35 p.m., Kai Uwe Broulik wrote: > > src/kicondialog.cpp, line 302 > > > > > > While at it, can we get the size of the array instead of hardcoding a > > number here? Good idea, fixed. > O

Re: Review Request 128442: [KIconDialog] Allow showing icons from all categories

2016-07-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128442/#review97356 --- Good idea. Sorry for abusing this review for commenting on un

Review Request 128442: [KIconDialog] Allow showing icons from all categories

2016-07-13 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128442/ --- Review request for KDE Frameworks. Bugs: 216653 https://bugs.kde.org/

[Differential] [Closed] D1942: [KIconDialog] Do not clear search line when switching category

2016-07-13 Thread cfeck (Christoph Feck)
cfeck closed this revision. cfeck added a comment. Committed as http://commits.kde.org/kiconthemes/7f3f28ca8263aa7910587aa3814141d397bb1766 REVISION DETAIL https://phabricator.kde.org/D1942 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: cfeck, #frame

Re: Review Request 128174: Update AppStream data location

2016-07-13 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128174/#review97350 --- Ship it! This really shouldn't be an issue anymore. Ubuntu

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-13 Thread Harald Sitter
> On July 13, 2016, 12:43 p.m., Kai Uwe Broulik wrote: > > +1 to the idea > > > > However, will this mean we get this awful apport "something crashed, now or > > in the past" tray icon in addition to Drkonqi? yes. its upon ubuntu to make that go away though as their use case is more involved.

Re: Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128437/#review97345 --- +1 to the idea However, will this mean we get this awful app

Review Request 128437: raise to core dump handlers when drkonqi is done

2016-07-13 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128437/ --- Review request for KDE Frameworks. Repository: kcrash Description -

Re: QIcon::fromTheme() does not load scalable icons

2016-07-13 Thread Olivier Churlaud
From: Antonio Rojas To:kde-frameworks-devel@kde.org Subject: Re: QIcon::fromTheme() does not load scalable icons Message-ID: Content-Type: text/plain; charset="ISO-8859-1" Olivier Churlaud wrote: > >Can you point me to the right place where to open the bug? > Already fixed in http://commits.

Jenkins-kde-ci: attica master stable-kf5-qt5 » Linux,gcc - Build # 40 - Fixed!

2016-07-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/attica%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 11:17:28 + Build duration: 4 min 7 sec CHANGE SET Revision f7157fc1ddcf6d5a03273d3331a64427d9

Jenkins-kde-ci: attica master stable-kf5-qt5 » Linux,gcc - Build # 40 - Fixed!

2016-07-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/attica%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 11:17:28 + Build duration: 4 min 7 sec CHANGE SET Revision f7157fc1ddcf6d5a03273d3331a64427d9

Jenkins-kde-ci: attica master stable-kf5-qt5 » Linux,gcc - Build # 39 - Failure!

2016-07-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/attica%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jul 2016 11:06:52 + Build duration: 1 min 38 sec CHANGE SET Revision b55f564c50daa2a6a3647596ad2a796be