Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > > Thi

Re: gcode.xml got into KF5::KTextEditor without review

On Sat, Mar 5, 2016 at 1:12 AM, Sven Brauch wrote: > Hey Alexander, > > Thanks for caring and sorry for breaking the string freeze; I missed > that. I reverted the commit and I will resubmit it after the 5.8 release > is out. > > On 05/03/16 01:01, Alexander Potashev wrote: >> [2] is clearly a fea

Re: gcode.xml got into KF5::KTextEditor without review

Hey Alexander, Thanks for caring and sorry for breaking the string freeze; I missed that. I reverted the commit and I will resubmit it after the 5.8 release is out. On 05/03/16 01:01, Alexander Potashev wrote: > [2] is clearly a feature, but it was not submitted to reviewboard > before pushing to

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

> On Март 4, 2016, 4:01 по п., Chusslove Illich wrote: > > src/klocalizedstring.cpp, line 368 > > > > > > I would nevertheless ifdef it. It may be that some strange thing is > > intentionally done with locale va

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/ --- (Updated March 5, 2016, 8:25 p.m.) Status -- This change has been ma

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/#review93208 --- Ship it! Ship It! - David Faure On March 5, 2016, 8:01

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 192 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Mar 2016 19:09:29 + Build duration: 4.6 sec CHANGE SET No changes _

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 197 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/197/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Mar 2016 19:09:29 + Build duration: 2 min 38 sec CHANGE SET Revision d472daac5b5580ead6533610b34

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126184/ --- (Updated March 5, 2016, 8:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? > > Xuetian Weng wrote: > This is not to disable the whole session

Re: Review Request 127271: Disable session restore for kwalletd5

> On March 5, 2016, 9:27 a.m., David Faure wrote: > > Looks good and more portable than the > > qunsetenv("SESSION_MANAGER"); > > which is used in many other places... > > > > Not sure both connects are necessary though? This is not to disable the whole session manager thing, but just disab

Re: Review Request 127261: Fix dead lock when program use kauth exits.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127261/ --- (Updated March 5, 2016, 6:32 p.m.) Status -- This change has been ma

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an in

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On March 3, 2016, 10:16 p.m., Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > > This sho

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 304 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/304/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Mar 2016 10:06:51 + Build duration: 2 min 30 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 304 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/304/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 05 Mar 2016 10:06:51 + Build duration: 2 min 59 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 297 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/297/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 05 Mar 2016 10:06:51 + Build duration: 2 min 37 sec CHANGE SET Revis

Re: Review Request 127266: Fix build with MinGW on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127266/ --- (Updated March 5, 2016, 10:47 a.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 297 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/297/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 05 Mar 2016 10:06:51 + Build duration: 3 min 11 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Mar 2016 09:55:05 + Build duration: 6 min 11 sec CHANGE SET Revision 9b90b718518f0f6346a4523d371b54951d929014 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Mar 2016 09:55:05 + Build duration: 6 min 11 sec CHANGE SET Revision 9b90b718518f0f6346a4523d371b54951d929014 b

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/244/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Mar 2016 09:55:05 + Build duration: 5 min 39 sec CHANGE SET Revision 9b90b718518f0f6346a4523d371b54951d9

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/244/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 05 Mar 2016 09:55:05 + Build duration: 5 min 39 sec CHANGE SET Revision 9b90b718518f0f6346a4523d371b54951d9

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an in

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

> On Dec. 6, 2015, 2:58 p.m., David Faure wrote: > > src/kedittoolbar.cpp, line 770 > > > > > > this code path didn't call accept() before. > > > > Please investigate when save can fail, or keep former b

Re: Review Request 127271: Disable session restore for kwalletd5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93187 --- Looks good and more portable than the qunsetenv("SESSION_

Re: kconfig question

On Thursday 28 January 2016 10:06:29 Ralf Habacker wrote: > > In a similar patch I wrote recently for testing > https://build.opensuse.org/package/view_file/home:rhabacker:branches:windows:mingw:win32:Qt55/mingw32-libqt5-qtbase/0001-Add-QStandardPaths-support-for-qt.conf.patch?expand=1 > I used Q

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127166/#review93186 --- Looks good to me, but I'd rather let Martin have another look

Re: Review Request 127266: Fix build with MinGW on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127266/#review93185 --- Ship it! (Another approach would have been to rename the s

Re: Review Request 127261: Fix dead lock when program use kauth exits.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127261/#review93184 --- Fix it, then Ship it! Please push asap, I'm releasing toda

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127251/#review93183 --- I guess you couldn't trigger the mentionned crashes because I

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote: > > src/kstatusnotifieritem.cpp, line 934 > > > > > > append > > associatedWidget->setAttribute(Qt::WA_Moved); > > > > > > > > Thi