Re: Review Request 126196: Fix regression caused by RR 125527

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126196/#review88920 --- Ship it! Brilliant fix. Thanks a lot, Alex! - Jarosław Stani

Review Request 126196: Fix regression caused by RR 125527

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126196/ --- Review request for KDE Frameworks and Jarosław Staniek. Repository: kcore

Re: [Development] setting default widgetStyle (and ColorScheme)

btw, I'm also fine with having to set, say, KDE_SESSION_VERSION to a meaningful value in order to get automatic loading of the selected KDE theme, at least as long as it's possible to set env. variables session-wide on OS X. R. ___ Kde-frameworks-deve

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

Alex Merry wrote: > I'd be fine with adding something to KDECompilerSettings as long you had > to explicitly ask for it to be enabled when running CMake. But if you're > doing that, why not set CMAKE_EXE_LINKER_FLAGS_INIT directly on the > CMake command line, or use the LDFLAGS env var? I assume

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125988/ --- (Updated Nov. 28, 2015, 10:36 p.m.) Review request for KDE Frameworks and

Re: Review Request 125988: [KUrlCompletion] Add autocompletion for '.' input which offers all hidden files/folders

> On Nov. 26, 2015, 9:20 a.m., David Faure wrote: > > src/widgets/kurlcompletion.cpp, line 531 > > > > > > are you sure this hunk is necessary? > > QUrl has no special handling of "." in paths. > > So m_f

Re: [Development] setting default widgetStyle (and ColorScheme)

Kai Uwe Broulik wrote: >> A priori users should then still be able to use Qt's native Macintosh "aqua" > theme by selecting it as their KDE widget style. > > I think it should do that automatically anyway. I wouldn't want to install > System Settings to begin with, let alone manually choosing th

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On 2015-11-28 19:25, René J.V. Bertin wrote: On Saturday November 28 2015 15:29:00 David Faure wrote: Otherwise, the next best idea is to get ECM to add your activator to all link lines automatically, e.g. by adding it to CMAKE_EXE_LINKER_FLAGS or whatever. This for sure beats editing every lin

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

> On Nov. 28, 2015, 8:10 p.m., Jarosław Staniek wrote: > > Hi, I see one regression. > > Before this change I had "MimeType" field. And I've been using this field. > > > > Now I miss miss this field and have "KPlugin/MimeTypes" field. This means > > plugin error if KF5 5.16.x is installed. I c

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

> On Nov. 28, 2015, 8:10 p.m., Jarosław Staniek wrote: > > Hi, I see one regression. > > Before this change I had "MimeType" field. And I've been using this field. > > > > Now I miss miss this field and have "KPlugin/MimeTypes" field. This means > > plugin error if KF5 5.16.x is installed. I c

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

> On Nov. 28, 2015, 7:10 p.m., Jarosław Staniek wrote: > > Hi, I see one regression. > > Before this change I had "MimeType" field. And I've been using this field. > > > > Now I miss miss this field and have "KPlugin/MimeTypes" field. This means > > plugin error if KF5 5.16.x is installed. I c

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On Saturday November 28 2015 15:29:00 David Faure wrote: >I still have to see proof that a "pure Qt application" installed with MacPorts >really cares about where QSP points to - apart from the obvious migration issue >if this ever changes. The question is not whether individual applications care

Re: Review Request 125527: Add mimeTypes() to KPluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/#review88915 --- Hi, I see one regression. Before this change I had "MimeType"

Re: setting default widgetStyle (and ColorScheme)

Olivier Goffart wrote: > > A pure KF5 appliation would anyway use the KDE platform theme plugin provided > by KDE Frameworks. (in frameworkintegration) > (So in other words: that code should not be executed when kde frameworks is > installed, in theory) So... No, it doesn't. Not on OS X when u

Re: [Development] setting default widgetStyle (and ColorScheme)

Hi, > A priori users should then still be able to use Qt's native Macintosh "aqua" theme by selecting it as their KDE widget style. I think it should do that automatically anyway. I wouldn't want to install System Settings to begin with, let alone manually choosing the platform-native look. Ch

Re: Failure while executing KTar::open while using KCompressionDevice as the device

On Monday 23 November 2015 12:54:01 Luiz Romário Santana Rios wrote: > QNetworkReply is a sequential device. Yes, that's the problem. > This, as I > understand it, is only a problem because KCompressionDevice is able to > open any file it wants in any sequence No, not KCompressionDevice, but KT

Re: QSP patch/activator (Review Request 126125: [OS X] make KDE's trash use the OS X trash)

On Saturday 21 November 2015 17:17:49 René J.V. Bertin wrote: > That would mean having 2 different Qt5 installs in MacPorts; one for pure Qt > applications that are expected to behave "natively" I still have to see proof that a "pure Qt application" installed with MacPorts really cares about wher

Re: Review Request 126189: Support https and other URL schemas for "home page" property in KAboutData constructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126189/#review88913 --- Most of this looks good, but I'm not sure about the "2 compone

Re: [Development] setting default widgetStyle (and ColorScheme)

Aleix Pol wrote: >> In fact, my observations probably imply that the code *is* called when >> running "pure Qt5" apps under X11 (it is with the xcb plugin on OS X; I >> checked). If indeed so, I think it should be updated to comply with KF5 >> principles if KDE_SESSION_VERSION = 5 (and use the KD