Review Request 125319: KSycoca: make global database work after the recent timestamp check code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125319/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kser

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 11:29 p.m.) Review request for KDE Frameworks an

Re: Review Request 125318: KBuildSycocaProgressDialog: use Qt's builtin busy indicator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125318/ --- (Updated Sept. 19, 2015, 10:58 p.m.) Review request for KDE Frameworks an

Review Request 125318: KBuildSycocaProgressDialog: use Qt's builtin busy indicator.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125318/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kio

Review Request 125316: KProtocolManager: fix deadlock when using EnvVarProxy.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125316/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kio

Re: Review Request 125308: KSycoca: make ensureCacheValid() part of the public API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125308/ --- (Updated Sept. 19, 2015, 8:24 p.m.) Status -- This change has been m

Re: Review Request 125314: KBuildSycocaProgressDialog: run kbuildsycoca5 with QProcess.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125314/ --- (Updated Sept. 19, 2015, 8:21 p.m.) Review request for KDE Frameworks and

Re: Review Request 125314: KBuildSycocaProgressDialog: run kbuildsycoca5 with QProcess.

> On Sept. 19, 2015, 3:53 p.m., Albert Astals Cid wrote: > > src/widgets/kbuildsycocaprogressdialog.cpp, line 59 > > > > > > Can you close the dialog while the process is running? Does that > > destroy the proces

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 7:34 p.m.) Review request for KDE Frameworks and

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

> On Sept. 19, 2015, 3:47 p.m., David Faure wrote: > > Hmmm... and then old-kded crashed. You can't mmap a symlink? > > > > #10 0x7f6b0c76d6d4 in qt_assert(char const*, char const*, int) > > (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] > > "/d/kde/src/5/frameworks/kservice/src/sy

Re: Review Request 125290: Refresh Solid's device list before querying in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125290/#review85675 --- Ship it! Ship It! - David Faure On Sept. 19, 2015, 5:14 p.

Re: Review Request 125290: Refresh Solid's device list before querying in kio_trash

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125290/ --- (Updated Sept. 19, 2015, 7:14 p.m.) Review request for KDE Frameworks and

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

> On set. 19, 2015, 3:47 p.m., David Faure wrote: > > Hmmm... and then old-kded crashed. You can't mmap a symlink? > > > > #10 0x7f6b0c76d6d4 in qt_assert(char const*, char const*, int) > > (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] > > "/d/kde/src/5/frameworks/kservice/src/syc

Re: Review Request 125314: KBuildSycocaProgressDialog: run kbuildsycoca5 with QProcess.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125314/#review85672 --- src/widgets/kbuildsycocaprogressdialog.cpp (line 59)

Re: Review Request 125308: KSycoca: make ensureCacheValid() part of the public API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125308/#review85671 --- Ship it! Ship It! - Albert Astals Cid On set. 19, 2015, 1:

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85670 --- Hmmm... and then old-kded crashed. You can't mmap a symlink?

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 3:43 p.m.) Review request for KDE Frameworks and

Review Request 125314: KBuildSycocaProgressDialog: run kbuildsycoca5 with QProcess.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125314/ --- Review request for KDE Frameworks and Albert Astals Cid. Bugs: 166792

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

> On set. 18, 2015, 8:37 p.m., Albert Astals Cid wrote: > > Ship It! > > David Faure wrote: > I just realized that there is a possible migration problem with this > patch. > If you upgrade kservice in a running plasma5 session, and then install > some app, it will never show up in the

Re: KTabWidget vs QTabWidget

On Friday 18 September 2015 18:46:24 Jeremy Whiting wrote: > Hey all, > > In looking into fixing the remaining issues in Okular's frameworks > branch I realized that in part of the effort to port it away from > KDELibs4Support it got some functionality removed. It was ported from > KTabWidget to Q

Re: Review Request 125309: Support multiple X servers in the NETWM classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/#review85666 --- src/platforms/xcb/atoms_p.h (line 25)

Review Request 125309: Support multiple X servers in the NETWM classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125309/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindow

Re: Review Request 125308: KSycoca: make ensureCacheValid() part of the public API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125308/ --- (Updated Sept. 19, 2015, 1:06 p.m.) Review request for KDE Frameworks and

Review Request 125308: KSycoca: make ensureCacheValid() part of the public API.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125308/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kser

Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.

> On Sept. 18, 2015, 8:37 p.m., Albert Astals Cid wrote: > > Ship It! I just realized that there is a possible migration problem with this patch. If you upgrade kservice in a running plasma5 session, and then install some app, it will never show up in the K menu (or be launched when clicking on

Re: Review Request 125259: Support multiple X servers in the NETWM classes

> On Sept. 18, 2015, 12:21 nachm., Thomas Lübking wrote: > > src/platforms/xcb/netwm_p.h, line 31 > > > > > > errrhemmm ... the idea was actually to keep things more in sync and not > > have to match variable, st