Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 50 - Failure!

2015-09-08 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 06:52:33 + Build duration: 1 min 57 sec CHANGE SET Revision c297f89dcb9a34972c1a03b6ecf564b8e46bb4

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 50 - Failure!

2015-09-08 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Sep 2015 06:52:28 + Build duration: 1 min 56 sec CHANGE SET Revision c297f89dcb9a34972c1a03b6ecf564b

Re: Review Request 125106: Minor optimizations

2015-09-08 Thread Albert Astals Cid
> On set. 8, 2015, 4:46 p.m., Milian Wolff wrote: > > src/kconf_update/kconf_update.cpp, line 523 > > > > > > QLatin1String This was already a QLatin1String :D > On set. 8, 2015, 4:46 p.m., Milian Wolff wrote:

Review Request 125108: kbuildsycoca: remove code for --checkstamps and --nocheckfiles.

2015-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125108/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository: kser

Re: KService, ksycoca and translations

2015-09-08 Thread David Faure
On Monday 07 September 2015 23:34:54 Albert Astals Cid wrote: > El Dilluns, 7 de setembre de 2015, a les 23:28:40, Albert Astals Cid va > escriure: > > Running > >LANGUAGE=de kcmshell5 --list > > > > in my catalan based system gives me almost everything in catalan. > > > > That is because mo

Re: Review Request 125048: Use JSON files directly instead of kcoreaddons_desktop_to_json()

2015-09-08 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125048/ --- (Updated Sept. 8, 2015, 7:28 p.m.) Status -- This change has been ma

Re: Review Request 125106: Minor optimizations

2015-09-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review85019 --- in general +1, but I think some occassions should use QLatin1S

Review Request 125106: Minor optimizations

2015-09-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: Review Request 125104: When using scalable icons use still only use sizes defined by index metadata

2015-09-08 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125104/#review85013 --- Ship it! Ship It! - andreas kainz On Sept. 8, 2015, 2:27 p

Review Request 125104: When using scalable icons use still only use sizes defined by index metadata

2015-09-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125104/ --- Review request for KDE Frameworks, andreas kainz and Christoph Feck. Repo

Re: QIcon::fromTheme(xxx, someFallback)

2015-09-08 Thread David Faure
On Monday 07 September 2015 15:53:31 Olivier Goffart wrote: > > But the problem is that QIcon::isNull is likely to be called anyway. > And this will again do all the look ups in the file system. I don't think so. That's the whole reasoning behind this change. I added debug output in QIcon and r

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-08 Thread Martin Gräßlin
> On Sept. 7, 2015, 9:17 a.m., Martin Gräßlin wrote: > > hey OSX-devs: we need to find a better solution for this things. I didn't > > notice the review before it was pushed, but I would not have given a shipit > > for it. > > > > The solution is sementically wrong. We are now binding finding

Re: Review Request 124525: Add KMessageWidget to designer plugin

2015-09-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124525/ --- (Updated Sept. 8, 2015, 7:13 a.m.) Status -- This change has been ma

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-08 Thread Samuel Gaist
> On Sept. 7, 2015, 7:17 a.m., Martin Gräßlin wrote: > > hey OSX-devs: we need to find a better solution for this things. I didn't > > notice the review before it was pushed, but I would not have given a shipit > > for it. > > > > The solution is sementically wrong. We are now binding finding