Review Request 125025: eps: fix includes related to Qt Caterogized Logging

2015-09-01 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125025/ --- Review request for KDE Frameworks and Alex Merry. Repository: kimageforma

Re: assert in kservicetypefactory.cpp

2015-09-01 Thread Boudewijn Rempt
I've rebuilt frameworks this afternoon, but I'm struggling with calligra itself atm. I'll try it tomorrow morning. On Tue, 1 Sep 2015, David Faure wrote: On Wednesday 19 August 2015 09:08:35 Boudewijn Rempt wrote: Oh. I think you found a real bug :-) Does this patch help? Hm, doesn't look l

Re: assert in kservicetypefactory.cpp

2015-09-01 Thread David Faure
On Wednesday 19 August 2015 09:08:35 Boudewijn Rempt wrote: > > Oh. I think you found a real bug :-) > > Does this patch help? > > > Hm, doesn't look like it... How about the current kservice code, where I completely got rid of the kded dependency? Does that fix the assert? (or did you already mov

Re: Review Request 125021: Fix uninitialized value valgrind error

2015-09-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125021/#review84716 --- Ship it! Ship It! - David Edmundson On Sept. 1, 2015, 4:18

Review Request 125021: Fix uninitialized value valgrind error

2015-09-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125021/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative