Re: assert in kservicetypefactory.cpp

On Mon, 17 Aug 2015, David Faure wrote: On Monday 17 August 2015 10:05:05 Boudewijn Rempt wrote: This assert isn't triggered from our own code, but from kio's previewjob Ah OK. and either kdelibs4 didn't have the assert, or kio didn't need the cache. I'm pretty sure that both of these sta

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 68 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Aug 2015 21:59:01 + Build duration: 14 min CHANGE SET Revision 5ccd6db89c8a58a91fc40111c0c4a6a6da8649f6 by Davi

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 68 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 17 Aug 2015 21:59:01 + Build duration: 14 min CHANGE SET Revision 5ccd6db89c8a58a91fc40111c0c4a6a6da8649f6 by Davi

Re: Review Request 124795: Provide deterministic sort order for KDirSortFilterProxyModelPrivate::compare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124795/ --- (Updated Aug. 17, 2015, 9:58 p.m.) Status -- This change has been ma

Re: Review Request 124795: Provide deterministic sort order for KDirSortFilterProxyModelPrivate::compare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124795/#review83964 --- Ship it! Good solution! Clearly kmail's folder tree needs th

Re: Review Request 124772: kservice: fix almost all clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124772/ --- (Updated Aug. 17, 2015, 9:16 p.m.) Status -- This change has been ma

Re: assert in kservicetypefactory.cpp

On Monday 17 August 2015 10:05:05 Boudewijn Rempt wrote: > This assert isn't triggered from our own code, but from kio's previewjob Ah OK. > and either kdelibs4 didn't have the assert, or kio didn't need the > cache. I'm pretty sure that both of these statements are wrong. kdelibs/kio/kio/prev

Review Request 124795: Provide deterministic sort order for KDirSortFilterProxyModelPrivate::compare

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124795/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

> On Aug. 17, 2015, 3:51 p.m., David Rosca wrote: > > Thanks. I will commit it for you. > > David Rosca wrote: > But I need your full name. > > Armin K. wrote: > I've used Armin K. all the time I've been online and nobody has > complained when using it in git commits. I don't feel comf

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

> On Aug. 17, 2015, 3:51 p.m., David Rosca wrote: > > Thanks. I will commit it for you. > > David Rosca wrote: > But I need your full name. I've used Armin K. all the time I've been online and nobody has complained when using it in git commits. I don't feel comfortable in revealing my last

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

> On Aug. 17, 2015, 3:51 p.m., David Rosca wrote: > > Thanks. I will commit it for you. But I need your full name. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124789/#review8

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124789/#review83950 --- Ship it! Thanks. I will commit it for you. - David Rosca O

Review Request 124789: Respect -DBUILD_TESTING=OFF

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124789/ --- Review request for KDE Frameworks. Repository: bluez-qt Description ---

Review Request 124788: Replace std::auto_ptr with std::unique_ptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124788/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 124772: kservice: fix almost all clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124772/#review83945 --- Ship it! +1 src/services/kservicegroup.cpp (line 711)

Minimum supported version of MSVC for frameworks

Hi, Qt accepts 2012 at least doesn't it? I see KF5 following this a good thing. >From my perspective of supporting 3rd party devs: Dependency on 2012 in practice can exist for many reasons, preference and taste often being the last ones. If the goal is to have maximum reach for KF5 possible, using

Re: Review Request 124772: kservice: fix almost all clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124772/#review83935 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 16, 2015, 2

Re: Review Request 124746: [KDesktopFile] add readMimeType

> On Aug. 15, 2015, 9:24 p.m., David Faure wrote: > > Why not use KService instead? > > Kai Uwe Broulik wrote: > I don't know :) Seemed like the most reasonable way given I was checking > the Desktop file for the exec path already. KService is in Tier 3, KConfig is in Tier 1. - Aleix -

Re: Minimum supported version of MSVC for frameworks

On Mon, Aug 17, 2015 at 9:13 AM, Kevin Funk wrote: > On Sunday 16 August 2015 11:19:39 Alex Merry wrote: > > On 2015-08-13 09:57, Kai Uwe Broulik wrote: > > > ‎Hi, > > > > > > My experience with MSVC 2013 was that you even need at least Update 4 > > > for initializer lists to work properly, which

Re: Proposal to improving KDE Software Repository Organization

On Sunday 16 August 2015 23:36:33 Luigi Toscano wrote: > David Faure ha scritto: > > On Sunday 16 August 2015 13:51:29 Michael Pyne wrote: > >> There's no reason even with our current build metadata that we'd *have* to > >> have project hierarchies, as long as each underlying git repository name

Re: assert in kservicetypefactory.cpp

On Mon, 17 Aug 2015, David Faure wrote: On Monday 17 August 2015 09:37:52 Boudewijn Rempt wrote: Is it really necessary to assert here: krita(3310)/(default) unknown: ASSERT failure in KServiceTypeFactory::KServiceTypeFactory(): "Could not open sycoca database, you must run kbuildsycoca first!

Re: assert in kservicetypefactory.cpp

On Monday 17 August 2015 09:37:52 Boudewijn Rempt wrote: > Is it really necessary to assert here: > > krita(3310)/(default) unknown: ASSERT failure in > KServiceTypeFactory::KServiceTypeFactory(): "Could not open sycoca > database, you must run kbuildsycoca first!", file > /home/boud/kf5/src/fr

assert in kservicetypefactory.cpp

Is it really necessary to assert here: krita(3310)/(default) unknown: ASSERT failure in KServiceTypeFactory::KServiceTypeFactory(): "Could not open sycoca database, you must run kbuildsycoca first!", file /home/boud/kf5/src/frameworks/kservice/src/services/kservicetypefactory.cpp, line 38 A

Re: Minimum supported version of MSVC for frameworks

On Sunday 16 August 2015 11:19:39 Alex Merry wrote: > On 2015-08-13 09:57, Kai Uwe Broulik wrote: > > ‎Hi, > > > > My experience with MSVC 2013 was that you even need at least Update 4 > > for initializer lists to work properly, which was released quite > > recently iirc. > > And even then, initi