Re: Review Request 124648: Handle clients having a different device pixel ratio

2015-08-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/ --- (Updated Aug. 7, 2015, 9:47 p.m.) Status -- This change has been mar

Re: Review Request 124648: Handle clients having a different device pixel ratio

2015-08-07 Thread David Edmundson
> On Aug. 7, 2015, 2:13 p.m., Aleix Pol Gonzalez wrote: > > src/kwindowsystem.cpp, line 34 > > > > > > Make static, at least it won't expose this to the linker. > > > > Some documentation wouldn't hurt.

Re: Review Request 124648: Handle clients having a different device pixel ratio

2015-08-07 Thread Marco Martin
> On Aug. 7, 2015, 4:54 p.m., Aleix Pol Gonzalez wrote: > > src/kwindowsystem.cpp, line 34 > > > > > > I insist. agree on the inststing :p - Marco --- T

Re: Review Request 124648: Handle clients having a different device pixel ratio

2015-08-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/#review83535 --- Ship it! src/kwindowsystem.cpp (line 34)

Re: Review Request 124648: Handle clients having a different device pixel ratio

2015-08-07 Thread David Edmundson
On Aug. 7, 2015, 2:13 p.m., David Edmundson wrote: > > I'm unsure how good it is though, I would expect to be getting proper > > coordinates already. Will this break on wayland maybe? >I would expect to be getting proper coordinates already. How? >Will this break on wayland maybe? No. - Da

Re: Review Request 124648: Handle clients having a different device pixel ratio

2015-08-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124648/#review83533 --- src/kwindowsystem.cpp (line 34)

Re: Review Request 124646: Let the RowLayout figure out the size of the label

2015-08-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124646/ --- (Updated Aug. 7, 2015, 12:24 p.m.) Status -- This change has been ma

Re: Jenkins-kde-ci: kinfocenter master kf5-qt5 ยป Linux,gcc - Build # 11 - Fixed!

2015-08-07 Thread Scarlett Clark
Done, Thank you. Scarlett On Thu, Aug 6, 2015 at 5:13 AM, David Faure wrote: > On Thursday 06 August 2015 11:54:40 no-re...@kde.org wrote: > > > > GENERAL INFO > > > > BUILD SUCCESS > > Build URL: > https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ > > Hi S