Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

> On July 8, 2015, 7:52 p.m., Hrvoje Senjan wrote: > > src/pluginwrapper.cpp, line 68 > > > > > > After updating to latest master, i wonder do we need this debug enabled > > by default? :D In the case of kglobal

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review82237 --- src/pluginwrapper.cpp (line 68)

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 8, 2015, 5:10 ip) Review request for KDE Frameworks and Ma

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281/#review82234 --- src/knotificationmanager.cpp (line 92)

Re: Review Request 124289: [kidletime] Install private headers for platform plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124289/#review82221 --- Ship it! It's what I would have expected for private headers.

Re: Review Request 124288: [kwindowsystem] Install private headers for platform plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124288/#review82220 --- Ship it! It's what I would have expected for private headers.

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

On jul 7, 2015, 7:38 p.m., Martin Klapetek wrote: > > I'm looking at the KNotifications dependency graph here [1] and see that > > KWindowSystem is only required for KCrash. > > So err, can't that one go as well since you removed KService which required > > KCrash which then required KWindowSys