Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- (Updated July 2, 2015, 8:19 a.m.) Review request for KDE Frameworks. Ch

Re: Review Request 124226: Delete old highlighter

> On heinä 1, 2015, 10:35 ip, Aleix Pol Gonzalez wrote: > > src/widgets/ktextedit.cpp, line 662 > > > > > > no need for the if, you can just call `delete decorator->highlighter();` > > > > Also this is w

Re: Review Request 124226: Delete old highlighter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/#review81973 --- src/widgets/ktextedit.cpp (line 662)

Re: Review Request 123890: Don't show "KDE Frameworks version" in the About KDE dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123890/ --- (Updated July 1, 2015, 8:56 p.m.) Status -- This change has been mar

Review Request 124226: Delete old highlighter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226/ --- Review request for KDE Frameworks and Laurent Montel. Repository: ktextwi

Re: QPA plugin like functionality in frameworks?

On Tuesday 30 June 2015 20:33:09 Albert Astals Cid wrote: > El Dijous, 25 de juny de 2015, a les 08:46:07, Martin Gräßlin va escriure: > > On Wednesday 24 June 2015 23:20:21 Aleix Pol wrote: > > > On Wed, Jun 24, 2015 at 9:51 AM, Martin Gräßlin > > wrote: > > > > On Tuesday 23 June 2015 19:35:48

Re: Review Request 124186: [runtime] Install headers and library for the private part

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/#review81945 --- Ship it! src/runtime/CMakeLists.txt (line 26)

Re: Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/#review81943 --- src/platforms/wayland/CMakeLists.txt (line 15)

Re: Review Request 124212: kwindowsystem: Change source file layout

> On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: > > In general, I like it. > > > > Maybe now that we're putting the files in separate directories, we can drop > > the _mac postfixes? > > Martin Gräßlin wrote: > I like the idea, but that won't be possible for all cases. E.g. with

Re: Review Request 124212: kwindowsystem: Change source file layout

> On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: > > In general, I like it. > > > > Maybe now that we're putting the files in separate directories, we can drop > > the _mac postfixes? > > Martin Gräßlin wrote: > I like the idea, but that won't be possible for all cases. E.g. with

Re: Review Request 124212: kwindowsystem: Change source file layout

> On June 30, 2015, 4:59 p.m., Aleix Pol Gonzalez wrote: > > In general, I like it. > > > > Maybe now that we're putting the files in separate directories, we can drop > > the _mac postfixes? > > Martin Gräßlin wrote: > I like the idea, but that won't be possible for all cases. E.g. with

Review Request 124222: kidletime: Introduce plugin infrastructure for platform specific parts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124222/ --- Review request for KDE Frameworks. Repository: kidletime Description --

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124128/#review81935 --- Ship it! Ship It! - David Faure On June 30, 2015, 2:50 p.m

Re: Review Request 124186: [runtime] Install headers and library for the private part

> On July 1, 2015, 9:50 a.m., Martin Gräßlin wrote: > > any further opinions on the installation of the "private" headers? > > Otherwise I'm going to push tomorrow. Looks good to me - Martin --- This is an automatically generated e-mai

Re: Review Request 124213: Add standard shortcut for "new tab" action

> On June 30, 2015, 12:07 p.m., Kai Uwe Broulik wrote: > > +1 for Ctrl+T but not sure about Ctrl+Shift+N, never seen that used for > > that purpose, just "incognito mode", or "new window" in applications like > > Konsole. You can see that ctrl+. (period) is the current default in kstandardsho

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 15 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 01 Jul 2015 08:24:49 + Build duration: 9.4 sec CHANGE SET Revision b01f782c5916b29a41cf26bfa132b761e0b45065

Re: Review Request 124155: Add KStatusNotifierItem::action(const QString &) to retrieve an action by name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124155/ --- (Updated July 1, 2015, 8:05 a.m.) Status -- This change has been mar

Re: Review Request 124186: [runtime] Install headers and library for the private part

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124186/#review81927 --- any further opinions on the installation of the "private" head

Re: Review Request 124208: Fallback for componentFriendlyForAction name resolving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124208/ --- (Updated July 1, 2015, 7:49 a.m.) Status -- This change has been mar

Review Request 124220: kwindowsystem: Add a plugin infrastructure for platform specific implementations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124220/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio