Re: Review Request 123951: Change from GPL with KDE exception to LGPL to match the rest of the library

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123951/ --- (Updated June 2, 2015, 5:32 a.m.) Status -- This change has been mar

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

> On May 29, 2015, 12:45 p.m., David Faure wrote: > > I'm not sure this is a good idea, usability wise. Miss an icon by one > > pixel, and the effect is to go up, making the whole set of icons disappear? > > Ashish Bansal wrote: > Well about usability there's already discussion going on dol

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/ --- (Updated June 1, 2015, 1:22 p.m.) Status -- This change has been mar

Re: Review Request 123974: Add more symbols to convert-klineedit.pl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123974/ --- (Updated June 1, 2015, 1:10 p.m.) Status -- This change has been mar

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/#review81049 --- Ship it! Ship It! - David Edmundson On June 1, 2015, 12:49

Re: Review Request 123974: Add more symbols to convert-klineedit.pl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123974/#review81048 --- Ship it! Seems good for me :) Ship it - Laurent Montel On

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/ --- (Updated June 1, 2015, 2:49 p.m.) Review request for KDE Frameworks. Bu

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

> On June 1, 2015, 2:40 p.m., David Edmundson wrote: > > src/notifybyexecute.cpp, line 56 > > > > > > should this have an > > > > else subst.insert("w", 0); ? > > > > otherwise it won't be subst

Re: Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/#review81044 --- src/notifybyexecute.cpp (line 54)

Review Request 123975: Fix crash in NotifyByExecute when no widget has been set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123975/ --- Review request for KDE Frameworks. Bugs: 348510 https://bugs.kde.org/

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » OSX,clang - Build # 8 - Failure!

Check console output at https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=OSX,compiler=clang/8/ to view the results. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/k

Review Request 123974: Add more symbols to convert-klineedit.pl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123974/ --- Review request for KDE Frameworks. Repository: kde-dev-scripts Descript

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

> On May 29, 2015, 12:45 p.m., David Faure wrote: > > I'm not sure this is a good idea, usability wise. Miss an icon by one > > pixel, and the effect is to go up, making the whole set of icons disappear? > > Ashish Bansal wrote: > Well about usability there's already discussion going on dol

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

> On May 29, 2015, 2:45 p.m., David Faure wrote: > > I'm not sure this is a good idea, usability wise. Miss an icon by one > > pixel, and the effect is to go up, making the whole set of icons disappear? > > Ashish Bansal wrote: > Well about usability there's already discussion going on dolp

Re: [knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory

On Monday 01 June 2015 10:22:19 Gregor Mi wrote: > Am 01.06.2015 09:48 schrieb David Faure: > > On Thursday 21 May 2015 14:41:27 Gregor Mi wrote: > >> private: > >> -// Note that this object must live long enough in case the user > >> opens > >> -// the "Configure..." dialog > >> -KMor

Re: [knewstuff] src/kmoretools: Use pimpl for KMoreToolsMenuFactory

On Thursday 21 May 2015 14:41:27 Gregor Mi wrote: > private: > -// Note that this object must live long enough in case the user opens > -// the "Configure..." dialog > -KMoreTools* m_kmt = nullptr; > - > -QMenu* m_menu = nullptr; > +KMoreToolsMenuFactoryPrivate* d; > }; > E