Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/#review80432 --- Ship it! Ship It! - David Faure On May 13, 2015, 7:38 p.m.

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/#review80430 --- Ship it! About your commit log: we won't have a different cod

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On May 15, 2015, 8:08 p.m., Hrvoje Senjan wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 300 > > > > > > This somehow breaks dialogs from QFileDialog. e.g. standarddialogs' > > QFileDialo

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

> On May 15, 2015, 6:08 p.m., Hrvoje Senjan wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 300 > > > > > > This somehow breaks dialogs from QFileDialog. e.g. standarddialogs' > > QFileDialo

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review80415 --- src/platformtheme/kdeplatformfiledialoghelper.cpp (line 300)

Review Request 123803: Coding Style for k7zip.cpp kar.cpp karchive.cpp kbzip2filter.cpp kcompressiondevice.cpp kfilterdev.cpp kgzipfilter.cpp klimitediodevice.cpp knonefilter.cpp krcc.cpp ktar.cpp kxz

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123803/ --- Review request for KDE Frameworks, Mario Bensi and David Faure. Repositor

Re: Review Request 123439: Coding Style for karchive_p.h kbzip2filter.h kcompressiondevice.h kfilterbase.h kfilterdev.h klimitediodevice_p.h kxzfilter.h kzip.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123439/ --- (Updated May 15, 2015, 4:05 p.m.) Status -- This change has been mar

Re: purpose bugzilla product

On Fri, May 15, 2015 at 4:44 PM, Aleix Pol wrote: > On Fri, May 15, 2015 at 3:35 PM, Harald Sitter wrote: >> could someone please create a bugzilla product for purpose >> >> tia >> >> HS > > I'll request it. > > Please note Purpose it's not a framework (yet). > > Aleix Added, I forgot I had such

Re: purpose bugzilla product

On Fri, May 15, 2015 at 3:35 PM, Harald Sitter wrote: > could someone please create a bugzilla product for purpose > > tia > > HS I'll request it. Please note Purpose it's not a framework (yet). Aleix ___ Kde-frameworks-devel mailing list Kde-framewor

Re: Kross module loading is broken since KF5.0.0

On Wed, May 13, 2015 at 2:42 PM, Alexander Potashev wrote: > But nobody will ever link to a Kross plugin bypassing the standard loader > for Kross modules. > > That said, I think it should be absolutely fine if we rename all Kross > modules back to lowercase spelling and be happy again. > > What

purpose bugzilla product

could someone please create a bugzilla product for purpose tia HS ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 123768: port to new ecm_add_test PROPERTIES argument

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123768/ --- (Updated May 15, 2015, 12:42 p.m.) Status -- This change has been ma

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review80379 --- src/core/kconfig.cpp (line 98)