Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/ --- (Updated May 2, 2015, 2:57 a.m.) Review request for KDE Frameworks and Da

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

> On May 1, 2015, 4:01 p.m., David Faure wrote: > > autotests/jobtest.cpp, line 265 > > > > > > This particular syntax is too recent to be used, but you could create a > > QTimer and then connect its timeout sig

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

> On May 1, 2015, 9:24 p.m., David Faure wrote: > > The conditional comes from 50a2283112225e2db4673e41d12411e8664865fa in > > kdelibs.git where qMetaTypeId was ported to > > qMetaTypeId >. However that porting looks wrong indeed, > > KShortcut was UserType in QVariant while, from what you say

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79767 --- Don't remove the case that improves things for users :) src/

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated May 2, 2015, 12:55 a.m.) Review request for KDE Frameworks and D

Re: Versioning of Frameworks

On Thursday 30 April 2015 10:35:59 Kevin Funk wrote: > > QtAnything 5.5 cannot be compiled with QtBase 5.2. > > I'm fairly sure you can; let's say build QtWebChannel 5.6 (dev) against > QtBase 5.4.1. In fact, I just tried again and it worked just fine. QMake > did not complain. I would say Qt do

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79764 --- The conditional comes from 50a2283112225e2db4673e41d12411e8664

Re: Review Request 123567: Add an Arch Linux package search provider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123567/#review79763 --- Ship it! Ship It! - David Faure On April 29, 2015, 1:21 p.

Re: Review Request 123514: Make it possible to treat non-sequential QIODevice asynchronously

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123514/#review79761 --- Nice work. autotests/jobtest.cpp (line 264)

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79754 --- It looks ok to. +1 Consider it a ship it if noone replies in

Re: Review Request 123376: Fix handling of mod-shift-number shortcuts.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123376/#review79753 --- Two things. a) "1" is a magic number (stupid xcb, should be xc