Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 23, 2015, 3:20 a.m.) Review request for KDE Frameworks and

Re: New framework: KF5Syndication

2015-04-22 Thread Aleix Pol
On Thu, Apr 23, 2015 at 12:13 AM, Daniel Vrátil wrote: > On Wednesday, April 22, 2015 11:02:31 PM Frank Osterfeld wrote: >> Hi, >> >> > KF5Syndication is an RSS/Atom parsing library. It also provides API to >> > fetch feeds directly from network. >> > >> > It's a Tier 3 Framework (depends on KCode

kf5-qt5 compile failures, need developer assistance

2015-04-22 Thread Scarlett Clark
These are from the kf5-qt5 branchGroup (usually master or frameworks branches) I realize many these are still under heavy development for porting. This is just a note to inform. Fixes welcome though. kcalcore: https://build-sandbox.kde.org/job/kcalcore%20master%20kf5-qt5/PLATFORM=Linux,compiler=

Re: New framework: KF5Syndication

2015-04-22 Thread Daniel Vrátil
On Wednesday, April 22, 2015 11:02:31 PM Frank Osterfeld wrote: > Hi, > > > KF5Syndication is an RSS/Atom parsing library. It also provides API to > > fetch feeds directly from network. > > > > It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's currently > > being used only by Akreg

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79361 --- autotests/kconfig_compiler/test13.h.ref (line 20)

Re: New framework: KF5Syndication

2015-04-22 Thread Daniel Vrátil
On Wednesday, April 22, 2015 10:51:15 PM Mark Gaiser wrote: > On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil wrote: > > Hi all, > > > > I'd like to ask for review of another Framework from kdepimlibs: > > KF5Syndication > > > > KF5Syndication is an RSS/Atom parsing library. It also provides API

Re: New framework: KF5Syndication

2015-04-22 Thread Frank Osterfeld
Hi, > > KF5Syndication is an RSS/Atom parsing library. It also provides API to fetch > feeds directly from network. > > It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's currently > being > used only by Akregator. The Akonadi RSS resources (still lingering in some work branch, I

Re: New framework: KF5Syndication

2015-04-22 Thread Frank Osterfeld
> On 22 Apr 2015, at 22:51, Mark Gaiser wrote: > > Disclaimer: I've never seen this code nor knew about it's existence till ~30 > minutes ago. > > This library depends on QtXml (quite heavily in fact). That very Qt module is > deprecated [1]. > Funnily enough, that is the only place that ment

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Matthew Dawson
> On April 22, 2015, 5 p.m., Albert Astals Cid wrote: > > autotests/kconfig_compiler/test13.h.ref, line 20 > > > > > > Why is there no brightness property anymore? I still see it on line 40. - Matthew ---

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79355 --- autotests/kconfig_compiler/test13.h.ref (line 20)

Re: New framework: KF5Syndication

2015-04-22 Thread Mark Gaiser
On Wed, Apr 22, 2015 at 9:44 PM, Daniel Vrátil wrote: > Hi all, > > I'd like to ask for review of another Framework from kdepimlibs: > KF5Syndication > > KF5Syndication is an RSS/Atom parsing library. It also provides API to > fetch > feeds directly from network. > > It's a Tier 3 Framework (depe

New framework: KF5Syndication

2015-04-22 Thread Daniel Vrátil
Hi all, I'd like to ask for review of another Framework from kdepimlibs: KF5Syndication KF5Syndication is an RSS/Atom parsing library. It also provides API to fetch feeds directly from network. It's a Tier 3 Framework (depends on KCodecs and KIO). AFAIK it's currently being used only by A

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79353 --- If the first issue doesn't fit into this commit, this has a sh

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/ --- (Updated April 22, 2015, 6:13 p.m.) Review request for KDE Frameworks.

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 22, 2015, 6:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Matthew Dawson
> On April 22, 2015, 10:53 a.m., Matthew Dawson wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 100 > > > > > > Is there a reason not to generate Q_PROPERTIES for all classes, or at > > least do it by

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
> On April 22, 2015, 4:53 p.m., Matthew Dawson wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 100 > > > > > > Is there a reason not to generate Q_PROPERTIES for all classes, or at > > least do it by

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Matthew Dawson
> On April 22, 2015, 10:53 a.m., Matthew Dawson wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 100 > > > > > > Is there a reason not to generate Q_PROPERTIES for all classes, or at > > least do it by

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
> On April 22, 2015, 4:53 p.m., Matthew Dawson wrote: > > src/kconfig_compiler/kconfig_compiler.cpp, line 100 > > > > > > Is there a reason not to generate Q_PROPERTIES for all classes, or at > > least do it by

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79347 --- Ship it! - Vishesh Handa On April 22, 2015, 2:51 p.m., Alei

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/ --- (Updated April 22, 2015, 4:51 p.m.) Review request for KDE Frameworks and

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Aleix Pol Gonzalez
> On April 22, 2015, 4:36 p.m., Vishesh Handa wrote: > > autotests/kconfig_compiler/test_signal.h.ref, line 126 > > > > > > Is the move required? This is a unit test, this is how it gets generated after the patc

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79346 --- autotests/kconfig_compiler/test13.h.ref (line 38)

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

2015-04-22 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79343 --- autotests/kconfig_compiler/test_signal.h.ref (line 121)

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Emmanuel Pescosta
> On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote: > > src/widgets/accessmanager.cpp, line 255 > > > > > > IMO you should always verify if the data is readable, because not all > > lib users are trustworthy (

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Aleix Pol Gonzalez
> On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote: > > src/widgets/accessmanager.cpp, line 255 > > > > > > IMO you should always verify if the data is readable, because not all > > lib users are trustworthy (

Build failed in Jenkins: kinfocenter_stable_qt5 #16

2015-04-22 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUIL

Re: Review Request 123463: Use categorized logging in runtime component

2015-04-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123463/ --- (Updated April 22, 2015, 9:03 a.m.) Status -- This change has been m

Re: Review Request 123463: Use categorized logging in runtime component

2015-04-22 Thread Martin Gräßlin
> On April 22, 2015, 10:49 a.m., Martin Klapetek wrote: > > src/runtime/logging_p.h, lines 21-23 > > > > > > It's useful if this also has > > > > #include > > > > so that you don't have to inclu

Review Request 123464: Drop dead code path to get compositingActive without QGuiApplication

2015-04-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123464/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 123463: Use categorized logging in runtime component

2015-04-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123463/#review79332 --- Ship it! src/runtime/logging_p.h (lines 21 - 23)

Re: Review Request 123453: ki18n: Remove mention of language skipping

2015-04-22 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123453/ --- (Updated April 22, 2015, 8:32 a.m.) Status -- This change has been m

Re: Review Request 123453: ki18n: Remove mention of language skipping

2015-04-22 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123453/#review79331 --- Ship it! Ship It! - Chusslove Illich On Април 21, 2015, 9:

Review Request 123463: Use categorized logging in runtime component

2015-04-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123463/ --- Review request for KDE Frameworks and Martin Klapetek. Bugs: 346429 h

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-22 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/ --- (Updated April 22, 2015, 7:27 a.m.) Status -- This change has been m

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-22 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/ --- (Updated April 22, 2015, 7:13 a.m.) Review request for KDE Frameworks.

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79327 --- Ship it! Ship It! - Martin Gräßlin On April 22, 2015, 9:13

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/#review79325 --- src/widgets/accessmanager.cpp (line 255)