Re: Review Request 123111: Only add a '/' if the url does not end with one

2015-03-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123111/#review78189 --- toString() is slow and wrong (e.g. the trailing slash could co

Re: Review Request 123101: Only add "/" to path if really necessary

2015-03-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123101/#review78188 --- Ship it! Ship It! - David Faure On March 22, 2015, 6:05 p.

Review Request 123178: [KCompletion] Delete condition inside KLineEdit::keyPressEvent that is already checked in a former condition

2015-03-29 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123178/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: KIOSK feature in kconfig framework

2015-03-29 Thread David Faure
On Tuesday 17 March 2015 20:12:29 Bhushan Shah wrote: > Hello, > > I am planning to work on KIOSK tool during the GSoC 2015, so I came > across this code in the kconfig framework while searching for things. > I came across this code, > > #pragma message("TODO: enable kiosk feature again (resource

Re: Review Request 123156: Don't warn the user/developer about something he can't fix

2015-03-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123156/ --- (Updated March 29, 2015, 9:21 p.m.) Status -- This change has been m