Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122864/ --- (Updated March 14, 2015, 4:58 a.m.) Status -- This change has been m

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated March 14, 2015, 4:58 a.m.) Status -- This change has been m

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/ --- (Updated mar. 14, 2015, 5:57 a.m.) Review request for KDE Frameworks and

Re: Review Request 122900: KPluginSelector to provide initialization arguments for the configuration modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122900/ --- (Updated March 14, 2015, 2:59 a.m.) Status -- This change has been m

Re: KF 5.8 changelog

On Fri, March 13, 2015 19:36:29 Marco Martin wrote: > On Friday 13 March 2015 19:15:21 Mark Gaiser wrote: > > > To everybody(and myself): > > > please follow this advice, on any mayor change especially if needs a bit > > > of > > > back and forth in reviews, let's try to add CHANGELOG: in the commi

Re: Review Request 122926: Add setError method to JobViewV2 interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/ --- (Updated March 13, 2015, 7:26 p.m.) Status -- This change has been m

Re: KF 5.8 changelog

On Friday 13 March 2015 19:15:21 Mark Gaiser wrote: > > To everybody(and myself): > > please follow this advice, on any mayor change especially if needs a bit > > of > > back and forth in reviews, let's try to add CHANGELOG: in the commit, > > mkay? > > Not just "major changes". Basically all comm

Re: KF 5.8 changelog

On Fri, Mar 13, 2015 at 4:05 PM, Marco Martin wrote: > On Friday 13 March 2015 10:12:24 David Faure wrote: > > The goal of the CHANGELOG line is to describe the change from the point > of > > view of a developer using the framework, or from the point of view of a > user > > running this code, whi

Re: Review Request 122913: Added an event() version that takes no icon and will use a default one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122913/#review77433 --- Ship it! Thanks!! ...+ the QStringLiteral change ;) src/kn

Re: KF 5.8 changelog

On Friday 13 March 2015 10:12:24 David Faure wrote: > The goal of the CHANGELOG line is to describe the change from the point of > view of a developer using the framework, or from the point of view of a user > running this code, while the rest of commit messages are often written from > the impleme

Re: KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter

On Thursday 12 March 2015 14:03:09 Jan Kundrát wrote: > Hi, > kdeclarative doesn't build on Qt 5.2 since commit > 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on > QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged > almost two months ago. Seems tha

Re: KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter

On Thursday 12 March 2015 14:03:09 Jan Kundrát wrote: > Hi, > kdeclarative doesn't build on Qt 5.2 since commit > 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep on > QOpenGLContext::isOpenGLES(), which is 5.3+ only. That commit was merged > almost two months ago. Seems tha

Re: Review Request 122886: QML-only KCM base

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 13, 2015, 12:04 p.m.) Review request for KDE Frameworks an

Re: Review Request 122893: Populate KIconDialog on showEvent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77409 --- Ship it! Hopefully I did not miss anything this time :) - Ch

Re: KF 5.8 changelog

On Friday 13 March 2015 09:29:44 David Faure wrote: > Plasma framework > > * Fix plasmapkg2 for translated systems > * Improve tooltip layout > * Make it possible to let plasmoids to load scripts outside the plasma > package > ... Plasma-framework developers: this "..." means, please use CH

KF 5.8 changelog

New frameworks: * KPeople, provides access to all contacts and the people who hold them * KXmlRpcClient, interaction with XMLRPC services ### General * A number of build fixes for compiling with the upcoming Qt 5.5 ### KActivities * Resources scoring service is now finalized ### KArchive * St

Re: Review Request 122926: Add setError method to JobViewV2 interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/#review77407 --- Ship it! OK. This could have been part of the terminate call,

Re: Review Request 122876: Delay notifications a bit on Plasma startup

> On March 12, 2015, 8:48 a.m., Martin Gräßlin wrote: > > timer looks wrong to me, too. Not because it's ugly, but because Plasma > > notifications will not go above the splash screen. The fallback might be > > ugly, but as I have seen: it goes above the splash screen. > > > > Thus I suggest t

Re: Re: KDeclarative doesn't build with Qt 5.2 due to QOpenGLContext::isOpenGLES() from plotter

On Thursday 12 March 2015 23:42:54 Albert Astals Cid wrote: > El Dijous, 12 de març de 2015, a les 14:03:09, Jan Kundrát va escriure: > > Hi, > > kdeclarative doesn't build on Qt 5.2 since commit > > 25c37a8a599f66e65be44ef99fd1fc8ca55dd477 [1] which introduced a hard dep > > on > > QOpenGLContext: