Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName

> On mar. 9, 2015, 11:20 a.m., Martin Klapetek wrote: > > Ship It! > > Martin Klapetek wrote: > Actually wait, StandardEvents should have standard icons, why would you > need to change them? They don't have a standard, default icon: you have to specify it and as of now the only way you ha

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

> On mar. 9, 2015, 6:26 p.m., Albert Astals Cid wrote: > > makes no sense to me, you are getting a rect to > > paint on and painting outside of it. > > > > what even warrants that there will be "space" > > on the qpainter? > > > > should the size increase be done in upper levels? > > David Ed

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/#review77228 --- src/kiconengine.cpp

Re: Review Request 122876: Delay notifications a bit on Plasma startup

> On March 9, 2015, 8:32 p.m., Aleix Pol Gonzalez wrote: > > Can't we use the same mechanism as when the screen is locked? (We do that, > > right? show the notifications after going out of lock). > > > > Having a timer is kind of hacky... I'm not aware of us doing that (and we don't, I've just

Re: Review Request 122876: Delay notifications a bit on Plasma startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122876/#review77226 --- Can't we use the same mechanism as when the screen is locked?

Review Request 122876: Delay notifications a bit on Plasma startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122876/ --- Review request for KDE Frameworks and Eike Hein. Bugs: 344903 https:/

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

> On March 9, 2015, 6:26 p.m., Albert Astals Cid wrote: > > makes no sense to me, you are getting a rect to > > paint on and painting outside of it. > > > > what even warrants that there will be "space" > > on the qpainter? > > > > should the size increase be done in upper levels? It's not pa

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/#review77223 --- makes no sense to me, you are getting a rect to paint on and

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/#review77222 --- Hi, this fixes the pixelation issues in the Kate document list

Re: Review Request 122576: Introduce KMoreTools

> On March 7, 2015, 9:04 a.m., David Faure wrote: > > KService is basically ksycoca. One day I hope we can move away from that, > > which means all of kservice could then be deprecated. > > So it still makes sense to *use* kservice where looking up desktop files is > > needed (it's our current

Re: Review Request 122576: Introduce KMoreTools

> On March 7, 2015, 9:04 a.m., David Faure wrote: > > KService is basically ksycoca. One day I hope we can move away from that, > > which means all of kservice could then be deprecated. > > So it still makes sense to *use* kservice where looking up desktop files is > > needed (it's our current

Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122875/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Re: Review Request 122576: Introduce KMoreTools

> On March 7, 2015, 9:04 a.m., David Faure wrote: > > KService is basically ksycoca. One day I hope we can move away from that, > > which means all of kservice could then be deprecated. > > So it still makes sense to *use* kservice where looking up desktop files is > > needed (it's our current

Re: Review Request 122793: Fix KUrlNavigator with high DPI pixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122793/ --- (Updated March 9, 2015, 11:32 a.m.) Status -- This change has been m

Re: Review Request 122792: Add test app for showing KUrlNavigator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122792/ --- (Updated March 9, 2015, 11:32 a.m.) Status -- This change has been m

Re: Review Request 122779: Make KFileItemDelegate handle non default devicePixelRatio in animations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122779/ --- (Updated March 9, 2015, 11:32 a.m.) Status -- This change has been m

Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName

> On March 9, 2015, 11:20 a.m., Martin Klapetek wrote: > > Ship It! Actually wait, StandardEvents should have standard icons, why would you need to change them? - Martin --- This is an automatically generated e-mail. To reply, visit: h

Re: Review Request 122864: Added event() version that takes StandardEvent eventId and QString iconName

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122864/#review77205 --- Ship it! Ship It! - Martin Klapetek On March 9, 2015, 6:02