Re: Review Request 122549: Avoid code path that leaves local config files locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review76212 --- bump? - David Edmundson On Feb. 12, 2015, 9:34 p.m., David

Build failed in Jenkins: kde-baseapps_master_qt5 #241

See Changes: [andreas.sturmlechner] Make tests optional -- [...truncated 2663 lines...] ^

Re: Review Request 122462: [KCompletion] Fix typos in documentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76203 --- +1 Looks good to me. - Aleix Pol Gonzalez On Feb. 8, 2015,

Re: Review Request 122462: [KCompletion] Fix typos in documentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76202 --- Ping? - David Gil Oliva On feb. 8, 2015, 10:46 p.m., David

Re: kio and scheme://

Review request to fix this! https://git.reviewboard.kde.org/r/122613/ Thanks for the support guys! On Sun, Nov 2, 2014 at 1:43 PM, Àlex Fiestas wrote: > Hi there > > There are quite a few places where the following code is found: > > if (!url.path().endsWith('/')) { > url.setPath(url.path()

Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- Review request for KDE Frameworks. Repository: kio Description ---

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #1009

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review request: QBluez

> Well, then the test should try to detect it and QEXPECT_FAIL, havign tests > fail means something is bad, and as you say it's not bad, just expected. I meant it's expected to fail in the case that something goes wrong when initializing Manager. And that is, for example, the case with running Blu

Re: Review request: QBluez

El Dimarts, 17 de febrer de 2015, a les 22:39:16, David Rosca va escriure: > > That would work i guess, note it's not only about the project name, but > > also about the class names. > > Sure. > > > But i get two others to fail > > Any idea? > > Hmm, I would say that it is actually expected to f

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/ --- (Updated Feb. 17, 2015, 9:43 p.m.) Status -- This change has been ma

Re: Review request: QBluez

> That would work i guess, note it's not only about the project name, but also > about the class names. Sure. > But i get two others to fail > Any idea? Hmm, I would say that it is actually expected to fail if there is an error when calling GetManagedObjects on org.freedesktop.DBus.ObjectManager

Jenkins build is back to normal : kconfig_stable_qt5 #22

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review request: QBluez

El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: > > Using Q* is usually frowned upon since the Qt people have made it quick > > clear that they reserve the right to use Q* names themselves, i'd look > > for a new name. > > I see. What about renaming it to BluezQt? That

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76197 --- Oh, cool. I hope it does not cause a slowdown. Can someone ve

Re: KPeople part of KDE Frameworks

On Tue, Feb 17, 2015 at 7:56 PM, Albert Astals Cid wrote: > El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure: >> Hi, >> I would like to submit KPeople for review process so it can join the >> KF5 family in the next 5.8 release. >> >> KPeople is a tier 3 framework (because

Re: KPeople part of KDE Frameworks

El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure: > Hi, > I would like to submit KPeople for review process so it can join the > KF5 family in the next 5.8 release. > > KPeople is a tier 3 framework (because of KService, which will be > dropped eventually, without breaking

Jenkins build is back to normal : kdelibs4support_master_qt5 #329

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #1008

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Making prison a framework

Welcoming prison to the family of KDE Frameworks :) A few nit-picks, in no particular order: - & and * should not be touching the types, but the variables (https://techbase.kde.org/Policies/Kdelibs_Coding_Style#Whitespace) - braces for functions should be on separate lines (https://techbase.kde.or

Re: Review request: QBluez

> Using Q* is usually frowned upon since the Qt people have made it quick clear > that they reserve the right to use Q* names themselves, i'd look for a new > name. I see. What about renaming it to BluezQt? > Also tried to run the tests and qbluez-managertest seems to get stuck forever. > Does it

Making prison a framework

Hi The KDESupport library, libprison, a bar code rendering abstraction layer could be heading forward for the first release of a qt5, widgets free version. People also suggesting to make it a framework. So please, take a look at kde:prison and let's try to get it reviewed for frameworks /Sune

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76195 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 17, 2015, 3

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #1007

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/ --- (Updated Feb. 17, 2015, 2:51 p.m.) Review request for KDE Frameworks, Dav

Review Request 122606: Fix startup of kssld5 dbus service

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122606/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 122607: Better support for non-platform xcb in KXMessages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122607/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/ --- (Updated Feb. 17, 2015, 2 p.m.) Status -- This change has been marke

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76186 --- Ship it! src/knotifyconfigelement.h

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76184 --- Ship it! i'm not 100% sure on the issue below, apart from tha

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555/ --- (Updated Feb. 17, 2015, 1:29 p.m.) Status -- This change has been ma

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #1006

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122604: Do not require KSelectionWatcher and KSelectionOwner to be on platform xcb

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122604/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/#review76177 --- src/currency.cpp

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ --- (Updated Feb. 17, 2015, 11:22 a.m.) Review request for KDE Frameworks.