Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

> On feb. 9, 2015, 7:24 p.m., David Faure wrote: > > This should not be done if the slave has provided a UDS_MIME_TYPE. E.g. > > kio_smb sends mimetypes that derive from inode/directory, such as > > application/x-smb-server and application/x-smb-workgroup. If you think this > > works with the

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- (Updated Feb. 9, 2015, 10:48 p.m.) Status -- This change has been ma

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

> On feb. 9, 2015, 7:24 p.m., David Faure wrote: > > This should not be done if the slave has provided a UDS_MIME_TYPE. E.g. > > kio_smb sends mimetypes that derive from inode/directory, such as > > application/x-smb-server and application/x-smb-workgroup. If you think this > > works with the

Re: Fixing and regulating certain types of search fields across KF5 apps

Eike, On Mon, Feb 9, 2015 at 1:03 PM, Eike Hein wrote: > > Hi, > > we currently have numerous dynamic search fields across KDE > apps that, for performance reasons, disregard input shorter > than a particular QString::length(). Examples are KMail and > some things in KRunner. It's a common patte

Fixing and regulating certain types of search fields across KF5 apps

Hi, we currently have numerous dynamic search fields across KDE apps that, for performance reasons, disregard input shorter than a particular QString::length(). Examples are KMail and some things in KRunner. It's a common pattern. This is very English-centric behavior; many scripts are more com

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/ --- (Updated Feb. 9, 2015, 7:26 p.m.) Status -- This change has been mar

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/#review75730 --- This should not be done if the slave has provided a UDS_MIME_T

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/#review75726 --- +1 - Mark Gaiser On feb 9, 2015, 5:51 p.m., Àlex Fiestas wr

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75724 --- Yes, this lets it build on OSX/CI. Thanks, Jeremy! - Marko K

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75725 --- Ship it! Ship It! - Marko Käning On Feb. 9, 2015, 4:31 p.m

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75723 --- Ship it! Ship It! - Marco Martin On Feb. 9, 2015, 3:31 p.m

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/#review75719 --- Ship it! Seems ok to me - Ivan Čukić On Feb. 9, 2015, 3:31

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/ --- (Updated feb. 9, 2015, 5:51 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/ --- (Updated feb. 9, 2015, 5:45 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 120185: Look for kdesu in the correct location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- (Updated Feb. 9, 2015, 5:41 p.m.) Status -- This change has been mar

Re: Review Request 122478: KConfigWidgets: Remove leftover uses of tr() for translation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122478/ --- (Updated Feb. 9, 2015, 5:29 p.m.) Status -- This change has been mar

Re: Review Request 122459: sync the bookmarkmanager with the shared one only if change was from this process

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122459/ --- (Updated Feb. 9, 2015, 5:22 p.m.) Status -- This change has been mar

Re: Review Request 122487: Reorder member variables to reduce memory usage.

> On Feb. 8, 2015, 8:45 p.m., David Faure wrote: > > Which magic tool did you come up with this time, to detect such things? :-) > > Aleix Pol Gonzalez wrote: > +1 :D I too want to know! It's still very much WIP, the code is in kde:scratch/vkrause/elf-dissector but be aware that it still g

Re: Review Request 122487: Reorder member variables to reduce memory usage.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122487/ --- (Updated Feb. 9, 2015, 5:04 p.m.) Status -- This change has been mar

Re: Review Request 122495: CMake nitpicking on KDiagram

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122495/ --- (Updated Feb. 9, 2015, 4:11 p.m.) Status -- This change has been mar

Re: Review Request 122495: CMake nitpicking on KDiagram

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122495/#review75704 --- Ship it! Ship It! - Friedrich W. H. Kossebau On Feb. 9, 20

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122493/ --- (Updated Feb. 9, 2015, 8:31 a.m.) Review request for KDE Frameworks and M

Re: Review Request 122481: Fix use of environ for OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122481/ --- (Updated Feb. 9, 2015, 3:17 p.m.) Status -- This change has been mar

Review Request 122499: include applications-menu-merged too

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122499/ --- Review request for KDE Frameworks and David Faure. Bugs: 213972 https

Re: Review Request 120185: Look for kdesu in the correct location

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review75682 --- Ship it! libexec/kf5 sounds sensible to me. I'd say, barring

Jenkins build became unstable: kservice_master_qt5 #235

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122498: Register with dbus to wake up KRun, and unregister then

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122498/ --- Review request for Kate and KDE Frameworks. Repository: kate Descriptio

Re: strange problem with KConfig

On Monday 09 February 2015, Matthew Dawson wrote: > However, I think the bug can be worked around in the short term for the kcm > by having the KSharedConfigs in question use only the file they are > pointed at. I think that is actually the correct behaviour, as those files > are not supposed to us

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

> On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: > > -1 > > > > You use C-Style casts. Oke, the frameworks coding style doesn't seem to > > explicitly forbid it (casts are not mentioned), but if i recall correctly > > we use the Qt style + some of our own which means we should obey the Qt >

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

> On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: > > -1 > > > > You use C-Style casts. Oke, the frameworks coding style doesn't seem to > > explicitly forbid it (casts are not mentioned), but if i recall correctly > > we use the Qt style + some of our own which means we should obey the Qt >

Re: Review Request 122493: Use math.h round rather than C++11 std::lround.

> On Feb. 9, 2015, 12:59 a.m., Mark Gaiser wrote: > > -1 > > > > You use C-Style casts. Oke, the frameworks coding style doesn't seem to > > explicitly forbid it (casts are not mentioned), but if i recall correctly > > we use the Qt style + some of our own which means we should obey the Qt >