Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

> On gen. 2, 2015, 4:06 p.m., Aleix Pol Gonzalez wrote: > > Can you check if an QCommandLineParser can get 2 of them? > > > > Many applications are adding explicitly the addHelpOption, so with this > > they might get it twice? Nah, it's fine, i just added parser.addHelpOption(); parser.addVer

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/#review72968 --- Can you check if an QCommandLineParser can get 2 of them? Man

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

> On Jan. 2, 2015, 3:33 p.m., Aleix Pol Gonzalez wrote: > > We used to do this. It was removed because somebody (can't remember) > > considered it was misleading that the API would do things by itself. > > > > I would welcome this (as well as the --help) but I'd like to hear what > > others th

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

> On gen. 2, 2015, 3:33 p.m., Aleix Pol Gonzalez wrote: > > We used to do this. It was removed because somebody (can't remember) > > considered it was misleading that the API would do things by itself. > > > > I would welcome this (as well as the --help) but I'd like to hear what > > others th

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

> On Jan. 2, 2015, 3:33 p.m., Aleix Pol Gonzalez wrote: > > We used to do this. It was removed because somebody (can't remember) > > considered it was misleading that the API would do things by itself. > > > > I would welcome this (as well as the --help) but I'd like to hear what > > others th

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

> On gen. 2, 2015, 3:33 p.m., Aleix Pol Gonzalez wrote: > > We used to do this. It was removed because somebody (can't remember) > > considered it was misleading that the API would do things by itself. > > > > I would welcome this (as well as the --help) but I'd like to hear what > > others th

Re: Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/#review72962 --- We used to do this. It was removed because somebody (can't rem

Review Request 121792: Make KAboutData::setupCommandLine call addHelpOption and addVersionOption

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121792/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 121773: Fix build without X.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/ --- (Updated Jan. 2, 2015, 2:03 p.m.) Status -- This change has been mar

Jenkins build is back to stable : kwindowsystem_master_qt5 » All,LINBUILDER #130

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kwindowsystem_stable_qt5 » All,LINBUILDER #11

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #129

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_stable_qt5 » All,LINBUILDER #10

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #128

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_stable_qt5 » All,LINBUILDER #9

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #127

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_stable_qt5 » All,LINBUILDER #8

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #126

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_stable_qt5 » All,LINBUILDER #7

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121299: Add NET::OSD window type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/ --- (Updated Jan. 2, 2015, 11:08 a.m.) Status -- This change has been ma

Re: Review Request 119607: Support for ".hidden" files

> On Jan. 1, 2015, 10:02 p.m., David Faure wrote: > > Thanks for the updated patch. > > > > I wrote a unittest for it, it works, so I pushed both, to wrap this up. > > Feel free to extend the test if you see missing testcases. > > > > I'm not too happy about the sleep(1s) in the unittest, but

Jenkins build is back to stable : plasma-framework_stable_qt5 » All,LINBUILDER #50

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : frameworkintegration_master_qt5 #149

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : frameworkintegration_stable_qt5 #15

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121299: Add NET::OSD window type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review72906 --- Ship it! Please add @since to the new enum values - Martin G

Re: Review Request 121299: Add NET::OSD window type

> On Jan. 1, 2015, 7:51 p.m., Kai Uwe Broulik wrote: > > Ping > > > > Is there anything else missing? 5.6 tagging is Saturday and I'd like to get > > this in for Plasma 5.2 sorry for the delay - I didn't get reviewing going over Christmas/New Year. - Martin

Re: Review Request 119607: Support for ".hidden" files

> On Jan. 1, 2015, 10:02 p.m., David Faure wrote: > > Thanks for the updated patch. > > > > I wrote a unittest for it, it works, so I pushed both, to wrap this up. > > Feel free to extend the test if you see missing testcases. > > > > I'm not too happy about the sleep(1s) in the unittest, but

Re: Re: Required and supported Qt versions

On Tuesday 30 December 2014 10:02:38 David Faure wrote: > On Tuesday 30 December 2014 21:50:40 Ben Cooksley wrote: > > On Tue, Dec 30, 2014 at 9:47 PM, David Faure wrote: > > > On Tuesday 30 December 2014 21:41:10 Ben Cooksley wrote: > > >> We test the variants noted by "kf5-qt5" and "stable-kf5-q

Re: Review Request 121773: Fix build without X.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/#review72897 --- Ship it! Ship It! - Martin Gräßlin On Dec. 31, 2014, 11:23