Jenkins build is back to stable : kio_stable_qt5 #61

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kio_master_qt5 #498

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kservice_stable_qt5 #17

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: plasma-framework_stable_qt5 » All,LINBUILDER #49

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #937

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_stable_qt5 » All,LINBUILDER #6

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : krunner_stable_qt5 #10

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kservice_stable_qt5 #16

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : krunner_master_qt5 #116

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kpty_stable_qt5 #4

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: frameworkintegration_stable_qt5 #14

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: frameworkintegration_master_qt5 #148

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Jeremy Whiting
> On Dec. 31, 2014, 5:52 a.m., Jeremy Whiting wrote: > > src/kdesud/kdesud.cpp, line 76 > > > > > > Why not use if HAVE_X11 && !defined(Q_OS_MAC) to keep that fix in place? > > Michael Palimaka wrote: > !defi

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Michael Palimaka
> On Dec. 31, 2014, 12:52 p.m., Jeremy Whiting wrote: > > src/kdesud/kdesud.cpp, line 76 > > > > > > Why not use if HAVE_X11 && !defined(Q_OS_MAC) to keep that fix in place? !defined(Q_OS_MAC) was only added afte

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/#review72841 --- src/kdesud/kdesud.cpp

Review Request 121773: Fix build without X.

2014-12-31 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/ --- Review request for KDE Frameworks. Repository: kdesu Description --

Jenkins build is back to stable : frameworkintegration_master_qt5 #147

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : frameworkintegration_stable_qt5 #13

2014-12-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121747/ --- (Updated Dec. 31, 2014, 8:52 a.m.) Status -- This change has been ma

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-31 Thread David Faure
> On Dec. 30, 2014, 12:11 a.m., Mark Gaiser wrote: > > autotests/kfiledialog_unittest.cpp, line 145 > > > > > > One more sace. where? (anyway I ran astyle-kdelibs now, so coding style should be good) On Dec. 3

Re: Review Request 121747: Fix broken unittest for QFileDialog::setViewMode.

2014-12-31 Thread David Faure
> On Dec. 30, 2014, 12:05 a.m., Aleix Pol Gonzalez wrote: > > autotests/kfiledialog_unittest.cpp, line 150 > > > > > > switch()? Use QStringLiteral? Done. This was taken from kfile.cpp, which has if()s. > On D