Re: KDE-CI IRC meeting - Your possible KDE contributions in non-C++

2014-11-22 Thread Marko Käning
Hi Mario, thanks for organizing this! > Prospective agenda for the IRC meeting: > - Ben: Short introduction to KDE CI > - Everybody: Short introduction incl. their skills and wishes for KDE CI > - Ben: What needs to be changed > - Everybody: Work on a roadmap and distribute work till next meeting

KDE-CI IRC meeting - Your possible KDE contributions in non-C++

2014-11-22 Thread Mario Fux
[Disclaimer: this email is sent to kde-devel, kde-core-devel and kde- frameworks-devel. Please just answer to kde-devel!] Morning ladies and gentlemen Oh and please scratch the "please" above ;-). This email is about another possibility to contribute to KDE. It's about taking work off Ben's shou

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210/ --- (Updated Nov. 22, 2014, 6:39 p.m.) Review request for KDE Accessibility,

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread Christoph Feck
> On Nov. 22, 2014, 4:40 p.m., David Gil Oliva wrote: > > src/kled.h, line 257 > > > > > > It should be hidden behind the d-pointer. > > José Millán Soto wrote: > Why should it be hidden? > As it is not

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210/#review70793 --- I think the updateAccessibleName() should also be called from

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread David Gil Oliva
> On Nov. 22, 2014, 4:40 p.m., David Gil Oliva wrote: > > src/kled.h, line 257 > > > > > > It should be hidden behind the d-pointer. > > José Millán Soto wrote: > Why should it be hidden? > As it is not

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread José Millán Soto
> On Nov. 22, 2014, 4:40 p.m., David Gil Oliva wrote: > > src/kled.h, line 257 > > > > > > It should be hidden behind the d-pointer. Why should it be hidden? As it is not a virtual function it should not cause b

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210/#review70783 --- src/kled.h

Review Request 121210: Provide an accessible name for KLed

2014-11-22 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210/ --- Review request for KDE Accessibility and KDE Frameworks. Repository: kwid