Re: Proposal to improving KDE Software Repository Organization

2014-08-18 Thread David Faure
Nice work. Just one thing: On Monday 18 August 2014 21:54:40 Michael Pyne wrote: > So "kf5-qt5" might mean "KF5/Devel, Plasma5/Devel, etc." while > "kf5-qt5-stable" might mean "KF5/Devel, Plasma5/Stable, etc.". This looks like an attempt to keep the current branch-group naming for compatibi

Re: How to promote less mature Frameworks?

2014-08-18 Thread David Faure
On Friday 15 August 2014 12:51:58 Kevin Ottens wrote: > On Friday 15 August 2014 09:34:04 Alex Merry wrote: > > On Friday 15 August 2014 10:21:57 Mark Gaiser wrote: > > > On Fri, Aug 15, 2014 at 12:12 AM, Àlex Fiestas wrote: > > > > Hi there > > > > > > > > At the Randa sprint we have discussed a

Re: Review Request 119773: Launch scripts in autostart-directories

2014-08-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119773/#review64817 --- In the KF5 world even more so than before, all the autostart c

Proposal to improving KDE Software Repository Organization

2014-08-18 Thread Michael Pyne
Hi all, Ben Cooksley and I would like to get some feedback on further evolutions to the organization structure we employ for the repositories at git.kde.org, to allow our current usage of CI even as we move farther into the KF5-based world. TL;DR: More indirection in our JSON in kde-build-meta

Re: Review Request 119808: Move module metadata to after class picker

2014-08-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119808/ --- (Updated Aug. 18, 2014, 10:04 p.m.) Review request for KDE Frameworks, De

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review64807 --- modules/ECMGeneratePkgConfigFile.cmake

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-18 Thread Alex Merry
> On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, lines 25-26 > > > > > > Why not have both be KF5Archive as the standard? And have LIB_NAME > > default to BASE_NAME (or

Re: Review Request 119808: Move module metadata to after class picker

2014-08-18 Thread Alex Merry
> On Aug. 18, 2014, 1:38 p.m., Aleix Pol Gonzalez wrote: > > Maybe a screenshot will make it easier to review? Good idea; however, I've overwritten my local copy (because of other RRs), and now probably won't have time until a week tomorrow. - Alex --

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Aug. 18, 2014, 1:59 p.m.) Review request for Build System, KDE F

Re: Review Request 119798: Generating PkgConig files from ECM

2014-08-18 Thread Aleix Pol Gonzalez
> On Aug. 15, 2014, 8:20 a.m., Alex Merry wrote: > > modules/ECMGeneratePkgConfigFile.cmake, lines 25-26 > > > > > > Why not have both be KF5Archive as the standard? And have LIB_NAME > > default to BASE_NAME (or

Re: Review Request 119808: Move module metadata to after class picker

2014-08-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119808/#review64750 --- Maybe a screenshot will make it easier to review? - Aleix Pol

Re: Breeze widget style for KF5

2014-08-18 Thread Sebastian Kügler
On Monday, August 11, 2014 12:29:05 Hugo Pereira Da Costa wrote: > Comments, objections, blessings, are welcome After using it daily for about a week, I can say I'm really happy about it. It feels fast, well-done (even if some bits are missing, not complete yet), and gives me an impression of hi

Re: How to promote less mature Frameworks?

2014-08-18 Thread Sebastian Kügler
On Friday, August 15, 2014 12:51:58 Kevin Ottens wrote: > And that's the problem if we release them. If it's released "with the rest" > expect people to have wrong expectations about them. > > A possibility would be perhaps to produce nightly tarballs for those > frameworks which don't have the

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated Aug. 18, 2014, 11:48 a.m.) Status -- This change has been m

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- (Updated Aug. 18, 2014, 9:35 a.m.) Status -- This change has been ma

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64717 --- Ship it! See comments first. src/declarativeimports/plasmac

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/ --- (Updated Aug. 18, 2014, 9:25 a.m.) Review request for KDE Frameworks and

Re: Review Request 119781: Port TextArea to QtControls

2014-08-18 Thread Marco Martin
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Snippetextractor comments in framework examples

2014-08-18 Thread Mirko Boehm
Hi, On 08/18/2014 09:50 AM, David Faure wrote: > On Monday 11 August 2014 10:34:40 Rohan Garg wrote: >> > Hi everyone >> > As part of writing the KDE Frameworks 5 book, we were wondering if >> > it's fine with all the framework maintainers if we started adding >> > snippetextractor comments in the

Re: Interesting issue with KAboutData and icons

2014-08-18 Thread Harald Sitter
On Mon, Aug 18, 2014 at 9:41 AM, David Faure wrote: > On Monday 04 August 2014 22:01:15 Michael Pyne wrote: >> Hi all, >> >> I received a bug (https://bugs.kde.org/show_bug.cgi?id=337938) reported >> against KAboutData in KCoreAddons, that setting the window icon doesn't >> actually set the window

Re: Snippetextractor comments in framework examples

2014-08-18 Thread David Faure
On Monday 11 August 2014 10:34:40 Rohan Garg wrote: > Hi everyone > As part of writing the KDE Frameworks 5 book, we were wondering if > it's fine with all the framework maintainers if we started adding > snippetextractor comments in the examples to be able to directly quote > things in the book fr

Re: Interesting issue with KAboutData and icons

2014-08-18 Thread David Faure
On Monday 04 August 2014 22:01:15 Michael Pyne wrote: > Hi all, > > I received a bug (https://bugs.kde.org/show_bug.cgi?id=337938) reported > against KAboutData in KCoreAddons, that setting the window icon doesn't > actually set the window icon. > > In fact, KAboutData doesn't even try to, except

Re: Minimum translation percentage for frameworks release

2014-08-18 Thread David Faure
On Sunday 03 August 2014 01:34:54 Albert Astals Cid wrote: > El Divendres, 1 d'agost de 2014, a les 14:08:54, Alexander Potashev va > > escriure: > > 2014-08-01 13:07 GMT+04:00 Māris Nartišs : > > > As a head of another inactive, barely passing current criteria language > > > team, I would also vo

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

2014-08-18 Thread David Faure
> On Aug. 13, 2014, 7:47 a.m., David Faure wrote: > > src/lib/io/kautosavefile.h, line 49 > > > > > > To me kautosavefile was about the KOffice/Calligra use case: saving > > into a temp file in order to recover t