Re: Re: Breeze widget style for KF5

On Monday 11 August 2014 22:49:43 Milian Wolff wrote: > On Monday 11 August 2014 14:20:26 Luigi Toscano wrote: > > On Monday 11 of August 2014 14:08:35 Martin Gräßlin wrote: > > > On Monday 11 August 2014 13:10:39 Luigi Toscano wrote: > > > > On Monday 11 of August 2014 13:05:19 Hugo Pereira Da Cos

Re: Review Request 119723: Show q_properties at the top of class documentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119723/#review64337 --- I like it. How hard would it be then to remvoe the properties

Review Request 119723: Show q_properties at the top of class documentation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119723/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: KPlotting and KUnitConversion

On Monday 11 August 2014 18:41:33 Garret Wassermann wrote: > Simple is good, this is why I enjoy the KPlotting library. Might I > ask what use cases you have in mind for the framework so I can > better make suggestions? KPlotting is intended for applications, where the plot isn't a central part o

Re: Review Request 119681: Duplicate header guard from notifybylogfile.h in notifybyaudio.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119681/ --- (Updated Aug. 11, 2014, 9:32 p.m.) Status -- This change has been ma

OSX/CI: kmymoney fails to build on branch framework

Why is the build failing here with an "Alarm clock”? --- /Users/marko/WC/KDECI-builds/kmymoney/kmymoney/views/kmymoneyview.cpp:2287:16: warning: 'KIcon' is deprecated [-Wdeprecated-declarations] frm->setIcon(KIcon(icon)); ^ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/framewo

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119530/ --- (Updated Aug. 11, 2014, 9:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

> On Aug. 11, 2014, 8:23 a.m., David Faure wrote: > > Nice patch, I love the ton of unittests :) Awesome review. Thanks. I think I fixed all the concerns, I ran astyle and posted a new diff. > On Aug. 11, 2014, 8:23 a.m., David Faure wrote: > > autotests/kautosavefiletest.cpp, line 56 > > <

Re: OSX/CI: kgeography fails to build on branch frameworks

Hi Albert, On 11 Aug 2014, at 23:05 , Albert Astals Cid wrote: > I appreciate your efforts for building kgeography_frameworks, please try > again > since i just pushed some code to it. just did. All is fine now. :) > But, i think you should not try to build more thing than the linux CI, it's

Re: OSX/CI: kgeography fails to build on branch frameworks

El Dilluns, 11 d'agost de 2014, a les 21:30:07, Marko Käning va escriure: > [ 44%] /Users/marko/WC/KDECI-builds/kgeography/src/kgeography.cpp:18:10: > fatal error: 'kicon.h' file not found #include > ^ > Building CXX object src/CMakeFiles/kgeography.dir/mypopup.cpp.o > [ 48%] Building CXX

Re: Breeze widget style for KF5

On Monday 11 August 2014 13:05:19 Hugo Pereira Da Costa wrote: > Hi Milian > > > On Monday 11 August 2014 12:29:05 Hugo Pereira Da Costa wrote: > >> Hi all, > >> For the last couple of weeks and after discussion with Nuno, Marco, > >> Andrew and some others, I've worked on implementing most of the

Re: OSX/CI: kgeography fails to build on branch frameworks

2014-08-11 21:30 GMT+02:00 Marko Käning : > > [ 44%] /Users/marko/WC/KDECI-builds/kgeography/src/kgeography.cpp:18:10: > fatal error: 'kicon.h' file not found > #include > ^ > Building CXX object src/CMakeFiles/kgeography.dir/mypopup.cpp.o > [ 48%] Building CXX object src/CMakeFiles/kgeo

Re: Breeze widget style for KF5

On Monday 11 August 2014 14:20:26 Luigi Toscano wrote: > On Monday 11 of August 2014 14:08:35 Martin Gräßlin wrote: > > On Monday 11 August 2014 13:10:39 Luigi Toscano wrote: > > > On Monday 11 of August 2014 13:05:19 Hugo Pereira Da Costa wrote: > > > > Hi Milian > > > > > > > > > As someone with

Jenkins build is back to stable : kdelibs_stable #1168

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

OSX/CI: kgeography fails to build on branch frameworks

[ 44%] /Users/marko/WC/KDECI-builds/kgeography/src/kgeography.cpp:18:10: fatal error: 'kicon.h' file not found #include ^ Building CXX object src/CMakeFiles/kgeography.dir/mypopup.cpp.o [ 48%] Building CXX object src/CMakeFiles/kgeography.dir/popupmanager.cpp.o [ 51%] Building CXX object

Re: Review Request 119699: KIO: add public API isClipboardDataCut/setClipboardDataCut.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119699/#review64315 --- Ship it! Looks good to me! - Eike Hein On Aug. 10, 2014, 8

Jenkins build became unstable: kdelibs_stable #1167

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review64304 --- The patch does not apply. - Albert Astals Cid On mai. 15, 2

Re: Breeze widget style for KF5

Hi Hugo, This is fantastic! I'm so excited to see how far your efforts have progressed. On Mon, Aug 11, 2014 at 3:29 AM, Hugo Pereira Da Costa wrote: > Ultimately I'd like to > - push this to some official repository (where should that be ? > kde/workspace/breeze/kstyle ?) > I'm ambivalent on

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 6:23 p.m.) Status -- This change has been ma

Re: Breeze widget style for KF5

On Mon, Aug 11, 2014 at 12:29 PM, Hugo Pereira Da Costa wrote: > Hi all, > For the last couple of weeks and after discussion with Nuno, Marco, Andrew > and some others, I've worked on implementing most of the ideas from > git://anongit.kde.org/breeze.git (more precisely from the QML demos at > wid

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64290 --- Ship it! Ship It! - Lukáš Tinkl On Srp. 11, 2014, 7:51 odp

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 5:51 p.m.) Review request for KDE Frameworks and

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64284 --- src/start_kdeinit/start_kdeinit.c

Re: Web Shortcuts KCM

On 08/11/2014 09:45 AM, David Faure wrote: In any case you could ask the contributors for relicensing, before you spend a lot of time rewriting it (you "can", but it's such a waste - and a risk for regressions / missing features) I'll try to track them down. Maybe Riddell can help me actu

Re: Review Request 119713: Don't use hicolor if we have breeze or oxygen are available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/ --- (Updated ago. 11, 2014, 4:47 p.m.) Review request for KDE Frameworks. R

Re: Review Request 119713: Don't use hicolor if we have breeze or oxygen are available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/ --- (Updated ago. 11, 2014, 4:47 p.m.) Review request for KDE Frameworks. R

Re: Review Request 119713: Don't use hicolor if we have breeze or oxygen are available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/ --- (Updated ago. 11, 2014, 4:15 p.m.) Review request for KDE Frameworks. R

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #684

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #684

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #683

See Changes: [notmart] use "open in" [notmart] add file definition for colors -- [...truncated 255 lines...] Built target coronatest_automoc Scanning depend

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #683

See Changes: [notmart] use "open in" [notmart] add file definition for colors -- [...truncated 251 lines...] Generating datamodel.moc

Re: Review Request 119714: Fix the build on Windows using MSVC 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119714/ --- (Updated Aug. 11, 2014, 3:46 p.m.) Status -- This change has been ma

Re: Review Request 119713: Don't use hicolor if we have breeze or oxygen are available

> On ago. 11, 2014, 1:54 p.m., Aleix Pol Gonzalez wrote: > > src/kstandardaction.cpp, line 48 > > > > > > Wouldn't it be better to use something like this? > > > > > > QIcon::setThemeSearchPaths(QIcon::t

Re: Review Request 119714: Fix the build on Windows using MSVC 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119714/#review64270 --- Ship it! Ship It! - Milian Wolff On Aug. 11, 2014, 1:24 p.

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 2:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

> On Aug. 11, 2014, 2:47 p.m., David Faure wrote: > > src/kdeinit/kinit.cpp, line 503 > > > > > > This can't work, it's replacing a full path with a relative path. > > > > The goal of this code was s/lib

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64267 --- src/kdeinit/kinit.cpp

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 2:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64266 --- +1 from me, I'd wait for dfaure for the final "ship it" tho :)

Re: Review Request 119713: Don't use hicolor if we have breeze or oxygen are available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/#review64264 --- src/kstandardaction.cpp

Re: Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119698/#review64263 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Aug. 1

Re: Review Request 119714: Fix the build on Windows using MSVC 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119714/#review64262 --- Ship it! This should be save, default paramater is 0 anyways

Review Request 119713: Don't use hicolor if we have breeze or oxygen are available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Review Request 119714: Fix the build on Windows using MSVC 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119714/ --- Review request for KDE Frameworks, Christoph Cullmann and Joseph Wenninger.

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64260 --- I'm getting this error: chown: cannot access „/usr//usr/lib64

Re: Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119698/ --- (Updated ago. 11, 2014, 12:40 p.m.) Review request for KDE Frameworks.

Re: Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119698/ --- (Updated ago. 11, 2014, 12:39 p.m.) Review request for KDE Frameworks.

Re: Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

> On ago. 10, 2014, 9:01 p.m., Aleix Pol Gonzalez wrote: > > src/kconfigdialogmanager.cpp, line 61 > > > > > > It could be a QSet, you're already doing the cast and > > checking it's not null anyway. It could be

Re: Review Request 119711: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/ --- (Updated Aug. 11, 2014, 12:30 p.m.) Review request for KDE Frameworks and

Re: Breeze widget style for KF5

On Monday 11 of August 2014 14:08:35 Martin Gräßlin wrote: > On Monday 11 August 2014 13:10:39 Luigi Toscano wrote: > > On Monday 11 of August 2014 13:05:19 Hugo Pereira Da Costa wrote: > > > Hi Milian > > > > > > > As someone with no clue: > > > > > > > > a) what's the advantage of having a nati

Re: Re: Breeze widget style for KF5

On Monday 11 August 2014 13:10:39 Luigi Toscano wrote: > On Monday 11 of August 2014 13:05:19 Hugo Pereira Da Costa wrote: > > Hi Milian > > > > > As someone with no clue: > > > > > > a) what's the advantage of having a native widget style, compared to > > > using > > > QtCurve settings? > > > >

Re: Breeze widget style for KF5

On 08/11/2014 01:10 PM, Luigi Toscano wrote: On Monday 11 of August 2014 13:05:19 Hugo Pereira Da Costa wrote: Hi Milian As someone with no clue: a) what's the advantage of having a native widget style, compared to using QtCurve settings? None, except that you need someone working on qtcurve

Re: Breeze widget style for KF5

On Monday 11 of August 2014 13:05:19 Hugo Pereira Da Costa wrote: > Hi Milian > > > > As someone with no clue: > > > > a) what's the advantage of having a native widget style, compared to using > > QtCurve settings? > > None, except that you need someone working on qtcurve > > > Are there thing

Re: Breeze widget style for KF5

Hi Milian On Monday 11 August 2014 12:29:05 Hugo Pereira Da Costa wrote: Hi all, For the last couple of weeks and after discussion with Nuno, Marco, Andrew and some others, I've worked on implementing most of the ideas from git://anongit.kde.org/breeze.git (

Re: Breeze widget style for KF5

On Monday 11 August 2014 12:29:05 Hugo Pereira Da Costa wrote: > Hi all, > For the last couple of weeks and after discussion with Nuno, Marco, > Andrew and some others, I've worked on implementing most of the ideas > from git://anongit.kde.org/breeze.git > (more

Breeze widget style for KF5

Hi all, For the last couple of weeks and after discussion with Nuno, Marco, Andrew and some others, I've worked on implementing most of the ideas from git://anongit.kde.org/breeze.git (more precisely from the QML demos at widgetstyles/qtquickcontrolsstyle)

Re: Snippetextractor comments in framework examples

Hi! El 11/08/2014 10:35, "Rohan Garg" escribió: > > Hi everyone > As part of writing the KDE Frameworks 5 book, we were wondering if > it's fine with all the framework maintainers if we started adding > snippetextractor comments in the examples to be able to directly quote > things in the book fr

Re: For Book Sprint team: Frameworks Cookbook

Hello everyone, As Mirko mentioned, we think that the sections you will be writing for the book will be good subjects for defensive publications. Densive publications are like anti-patents. They are used to protect ideas and innovative hacks *against* subsequent patent filing. So with a little

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #88

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/ --- (Updated Aug. 11, 2014, 9:47 a.m.) Status -- This change has been ma

Re: Review Request 119681: Duplicate header guard from notifybylogfile.h in notifybyaudio.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119681/#review64244 --- Ship it! Awkward mistake :) Thanks! - Martin Klapetek On A

Re: Enabling Exceptions in CMake

On Mon, Aug 11, 2014 at 4:52 AM, Aleix Pol wrote: > Well, you can document it together with the funcion that enables exceptions > at least. OK, documented at https://techbase.kde.org/index.php?title=Development/ECM_SourceIncompatChanges&diff=82951&oldid=82898 David E. Narvaez __

Re: Enabling Exceptions in CMake

On Mon, Aug 11, 2014 at 10:22 AM, David Narvaez wrote: > On Sun, Aug 10, 2014 at 5:03 PM, Aleix Pol wrote: > > From kde-modules/KDECompilerSettings.cmake > > > > # kde_enable_exceptions() > > # > > # Enables exceptions for C++ source files compiled for the > > # CMakeLists.txt file in the curr

Re: Web Shortcuts KCM

On Wednesday 06 August 2014 08:58:07 Eike Hein wrote: > On 08/04/2014 10:09 AM, David Faure wrote: > > So yep, that's not going away any time soon ;) > > Alright, so that leaves the licensing problem, right? Do I > need to rewrite the KCM? Can I even? Do we contact Yves > Arrouye for relicensing?

Snippetextractor comments in framework examples

Hi everyone As part of writing the KDE Frameworks 5 book, we were wondering if it's fine with all the framework maintainers if we started adding snippetextractor comments in the examples to be able to directly quote things in the book from the examples in the framework we're writing about. You can

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119530/#review64231 --- Nice patch, I love the ton of unittests :) autotests/kautosa

Re: Enabling Exceptions in CMake

On Sun, Aug 10, 2014 at 5:03 PM, Aleix Pol wrote: > From kde-modules/KDECompilerSettings.cmake > > # kde_enable_exceptions() > # > # Enables exceptions for C++ source files compiled for the > # CMakeLists.txt file in the current directory and all subdirectories. > > See http://api.kde.org/ecm/kd

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/#review64230 --- Ship it! src/kwindowsystem.h

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

> On July 31, 2014, 2:03 p.m., Thomas Lübking wrote: > > src/kwindowinfo_x11.cpp, line 305 > > > > > > Any chance we can make this a function return in netwm.h to be used by > > the lib, kactivities and kwin and