Re: Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013

2014-07-31 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119365/ --- (Updated Aug. 1, 2014, 6:27 a.m.) Status -- This change has been mar

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119510: Fix untranslated menu entries

2014-07-31 Thread Lukáš Tinkl
> On Čec. 28, 2014, 8:12 odp., David Faure wrote: > > I don't know about the bcp47 thing, but setting the locale to C is > > definitely definitely wrong. > > > > This line of code in kdelibs4 was saying > > > >// force generating of KLocale object. if not, the database will get > >// b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-31 Thread Lukáš Tinkl
On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Minimum translation percentage for frameworks release

2014-07-31 Thread David Gil Oliva
Hi! El 31/07/2014 20:57, "Alexander Potashev" escribió: > > 2014-07-31 21:32 GMT+04:00 Albert Astals Cid : > > So you have an application, let's say VLC that is using some KDE framework, > > now VLC itself is in catalan at 100%, but that KDE framework is in catalan > > only at 25%. > > > > Why wo

Re: Minimum translation percentage for frameworks release

2014-07-31 Thread Alexander Potashev
2014-07-31 21:32 GMT+04:00 Albert Astals Cid : > So you have an application, let's say VLC that is using some KDE framework, > now VLC itself is in catalan at 100%, but that KDE framework is in catalan > only at 25%. > > Why would ever someone want not to have those 25% of strings? I.e. when would

Re: Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013

2014-07-31 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119365/#review63594 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On J

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-31 Thread Thomas Lübking
> On Juli 31, 2014, 12:03 nachm., Thomas Lübking wrote: > > src/kwindowinfo_x11.cpp, line 305 > > > > > > Any chance we can make this a function return in netwm.h to be used by > > the lib, kactivities and kwin

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-31 Thread Ivan Čukić
> On July 31, 2014, 12:03 p.m., Thomas Lübking wrote: > > src/kwindowinfo_x11.cpp, line 305 > > > > > > Any chance we can make this a function return in netwm.h to be used by > > the lib, kactivities and kwin an

Re: Minimum translation percentage for frameworks release

2014-07-31 Thread Albert Astals Cid
El Dijous, 31 de juliol de 2014, a les 21:06:21, Alexander Potashev va escriure: > 2014-07-31 15:27 GMT+04:00 Aleix Pol : > > On Thu, Jul 31, 2014 at 8:32 AM, Alexander Potashev > > > > wrote: > >> Correct - Albert's final idea was to let the downstream decide. I'm > >> almost sure that won't wo

Re: Minimum translation percentage for frameworks release

2014-07-31 Thread Alexander Potashev
2014-07-31 15:27 GMT+04:00 Aleix Pol : > On Thu, Jul 31, 2014 at 8:32 AM, Alexander Potashev > wrote: >> Correct - Albert's final idea was to let the downstream decide. I'm >> almost sure that won't work well, specifically most distros will >> probably include all translations we ship, even very i

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 31, 2014, 1:15 p.m.) Status -- This change has been ma

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Sebastian Kügler
> On July 31, 2014, 12:56 p.m., David Edmundson wrote: > > src/qmlcontrols/kcoreaddons/kuserproxy.cpp, line 128 > > > > > > This is a static method. You don't need to call QHostInfo ctor. Hah, thanks for catchin

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63563 --- Ship it! Good to me too. src/qmlcontrols/kcoreaddons/kuserp

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-31 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/#review63557 --- src/kwindowinfo_x11.cpp

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

2014-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63555 --- Ship it! I kinda liked the singlethon as well, but seems more

Re: Minimum translation percentage for frameworks release

2014-07-31 Thread Aleix Pol
On Thu, Jul 31, 2014 at 8:32 AM, Alexander Potashev wrote: > 2014-07-31 3:51 GMT+04:00 Aleix Pol : > > On Thu, Jul 31, 2014 at 1:36 AM, Alexander Potashev < > aspotas...@gmail.com> > > wrote: > >> > >> But doing per-framework percentages is no bueno, either: imagine your > >> app uses KService an

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-31 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/ --- (Updated July 31, 2014, 10:09 a.m.) Review request for KDE Frameworks, kw

Re: Review Request 119523: port TextField to QtControls

2014-07-31 Thread Marco Martin
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >

Re: Review Request 119523: port TextField to QtControls

2014-07-31 Thread David Edmundson
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >

Frameworks Cookbook book sprint

2014-07-31 Thread Valorie Zimmerman
Our time together is coming close! It would be good to decide on what writing platform we'll use. Rohan and I are both familiar with Booki at Flossmanuals. I found a book (available as an epub too) about Booki itself: http://www.flossmanuals.net/booki-user-guide/ Flossmanuals also has a nice guid

Jenkins build is back to stable : kio_master_qt5 #307

2014-07-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kio_master_qt5 #306

2014-07-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119551: Fix KFilePreviewGenerator not triggering model change update when determining MIME type as byproduct of unsuccessful preview job

2014-07-31 Thread Eike Hein
> On July 31, 2014, 7:56 a.m., David Faure wrote: > > src/filewidgets/kfilepreviewgenerator.cpp, line 685 > > > > > > This if () isn't useful, the for loop below will be a no-op if the list > > is empty. Sorry,

Re: Review Request 119551: Fix KFilePreviewGenerator not triggering model change update when determining MIME type as byproduct of unsuccessful preview job

2014-07-31 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119551/ --- (Updated July 31, 2014, 8:06 a.m.) Status -- This change has been ma

Re: Review Request 119551: Fix KFilePreviewGenerator not triggering model change update when determining MIME type as byproduct of unsuccessful preview job

2014-07-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119551/#review63540 --- Ship it! Nice detailed analysis, sounds all correct to me.