Porting KDialog::makeStandardCaption

2014-07-25 Thread David Narvaez
Hi, What's the new way to do KDialog::makeStandardCaption[0] withot KDELibs4Support? Thanks. David E. Narvaez [0] http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKDialog.html#a765be466448a0212674700a8f843966e ___ Kde-frameworks-devel mail

Re: KIcon -> QIcon and KIconLoader

2014-07-25 Thread David Narvaez
On Fri, Jul 25, 2014 at 5:45 PM, Martin Klapetek wrote: > You can do > > QIcon icon(new KIconEngine(iconName, pointerToIconLoader)); Thanks. I'll update the porting documentation and the porting script. David E. Narvaez ___ Kde-frameworks-devel mailing

Re: KIcon -> QIcon and KIconLoader

2014-07-25 Thread Martin Klapetek
On Fri, Jul 25, 2014 at 11:21 PM, David Narvaez wrote: > Hi, > > The migration script from KIcon to QIcon seems to think every usage of > KIcon( ... ) is of the form KIcon( iconName ) but there's also KIcon( > iconName, pointerToIconLoader ). What do I need to do to port those to > QIcon? > You

KIcon -> QIcon and KIconLoader

2014-07-25 Thread David Narvaez
Hi, The migration script from KIcon to QIcon seems to think every usage of KIcon( ... ) is of the form KIcon( iconName ) but there's also KIcon( iconName, pointerToIconLoader ). What do I need to do to port those to QIcon? Thanks. David E. Narvaez ___

Re: Review Request 119267: Adding KWindowSystem::setOnActivities(WId win, const QStringList &activities) method

2014-07-25 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119267/ --- (Updated July 25, 2014, 9:07 p.m.) Review request for KDE Frameworks, kwi

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/ --- (Updated July 25, 2014, 4:52 p.m.) Review request for KDE Frameworks and

Re: Review Request 119382: Port kio-mtp to KF5

2014-07-25 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/#review63168 --- CMakeLists.txt

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin
> On July 25, 2014, 3:57 p.m., Andrew Lake wrote: > > src/declarativeimports/plasmacomponents/qml/ToolButton.qml, line 30 > > > > > > Just curious, any reason to not use ToolButton here? > > > > http://qt

Re: Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63169 --- src/declarativeimports/plasmacomponents/qml/ToolButton.qml

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63163 --- One thing tough, i would put back in all the documentation com

Review Request 119464: port ToolButton to QtControls

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119417: kconfig: Fix QBasicAtomicInt being treated as int (reposted)

2014-07-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119417/#review63142 --- Ship it! Ship It! - Alex Merry On July 22, 2014, 11:35 p.m

Re: Review Request 119417: kconfig: Fix QBasicAtomicInt being treated as int (reposted)

2014-07-25 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119417/#review63136 --- Ping? - David Gil Oliva On jul. 22, 2014, 11:35 p.m., David

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 25, 2014, 11:05 a.m.) Status -- This change has been m

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63130 --- Ship it! Ship It! - David Edmundson On July 25, 2014, 10:5

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
> On July 25, 2014, 10:44 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 76 > > > > > > This causes a behavioural change: > > > > look at line 10

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 25, 2014, 10:55 a.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63127 --- src/declarativeimports/plasmacomponents/qml/styles/ButtonStyl

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread David Edmundson
> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread David Edmundson
> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 25, 2014, 9:41 a.m.) Review request for KDE Frameworks and

Re: KF5 Porting: Installing Icons

2014-07-25 Thread Alex Merry
On Friday 25 July 2014 02:52:09 Eike Hein wrote: > On 07/24/2014 08:35 PM, Alex Merry wrote: > > As Jonathan said, yes, you are correct. And, yes, I should really write a > > porting script for that. > > Yay! That's the excuse I needed to avoid fixing Konvi's icon > installs until your script is r

Re: Review Request 119457: Script to Fix ecm_install_icons Deprecation Warnings

2014-07-25 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119457/ --- (Updated July 25, 2014, 8:37 a.m.) Status -- This change has been ma

Re: Review Request 119457: Script to Fix ecm_install_icons Deprecation Warnings

2014-07-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119457/#review63113 --- Ship it! Thank you, you are awesome! A couple of notes about

Re: Review Request 119455: make Button a QtControl

2014-07-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63110 --- I think this is nearly good to go. A few questions below. sr