Jenkins build is back to stable : kdelibs_stable #1162

2014-07-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Porting: Installing Icons

2014-07-24 Thread David Narvaez
On Thu, Jul 24, 2014 at 2:35 PM, Alex Merry wrote: > As Jonathan said, yes, you are correct. And, yes, I should really write a > porting script for that. Thanks for the confirmation, I just posted https://git.reviewboard.kde.org/r/119457/ David E. Narvaez

Review Request 119457: Script to Fix ecm_install_icons Deprecation Warnings

2014-07-24 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119457/ --- Review request for KDE Frameworks. Repository: kde-dev-scripts Descript

Re: KF5 Porting: Installing Icons

2014-07-24 Thread Eike Hein
On 07/24/2014 08:35 PM, Alex Merry wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Yay! That's the excuse I needed to avoid fixing Konvi's icon installs until your script is ready ;) Alex Cheers, Eike _

Jenkins build became unstable: kdelibs_stable #1161

2014-07-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119447: meinproc: check both result of parsing and validation

2014-07-24 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119447/ --- (Updated July 24, 2014, 11:42 p.m.) Status -- This change has been m

Re: Review Request 119446: Add a simple test for meinproc

2014-07-24 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119446/ --- (Updated July 24, 2014, 11:42 p.m.) Status -- This change has been m

Re: Review Request 119446: Add a simple test for meinproc

2014-07-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119446/#review63103 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 24, 2014, 1

Re: Review Request 119446: Add a simple test for meinproc

2014-07-24 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119446/ --- (Updated Lug. 25, 2014, 1:20 a.m.) Review request for Documentation, KDE

Re: Review Request 119446: Add a simple test for meinproc

2014-07-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119446/#review63102 --- Ship it! Please ship after removing the two unneeded lines?

Re: Review Request 119447: meinproc: check both result of parsing and validation

2014-07-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119447/#review63101 --- Ship it! Looks good to me - Albert Astals Cid On jul. 24,

Re: KF5 Porting: Installing Icons

2014-07-24 Thread Alex Merry
On Wednesday 23 July 2014 18:08:42 David Narvaez wrote: > Hi, > > The information at [0] seems to indicate I just need to worry about > renaming files to match the new categories (btw, is there a script for > that?) but what I get from > > CMake Warning (dev) at > /usr/share/ECM/modules/ECMInstal

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 24, 2014, 6:17 p.m.) Review request for KDE Frameworks and

Re: Questions about KDE 4.14 and later + branches

2014-07-24 Thread Christoph Cullmann
> > > Leaving KDE/4.14 the last kdelibs 4.x based branch and just killing > > > "master" > > > and switching it over to what is now in "frameworks"? > > > > That sounds wrong. I'd just merge frameworks to master and kill frameworks. > Ok ;) I just did the merge frameworks => master and adjusted th

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Marco Martin
> On July 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 83 > > > > > > style.labelImplicitWidth doesn't exist? gah, leftover - Marco

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Marco Martin
> On July 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 41 > > > > > > This isn't very declarative, is there a reason we can't do: > >

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63091 --- src/declarativeimports/plasmacomponents/qml/styles/ButtonStyl

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 24, 2014, 4:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Marco Martin
> On July 24, 2014, 4:20 p.m., Martin Gräßlin wrote: > > Concerning the icon names: for the Desktops Effects KCM the names are > > working without me doing anything. So there must be a solution hidden in > > the widgets emulating style. yes, the native style figures out that internally, create

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Marco Martin
> On July 24, 2014, 4:18 p.m., Andrew Lake wrote: > > Exciting! > > > > Might this eventually support a ButtonStyle.qml in the plasma theme that > > overrides the svg-based ButtonStyle if it's present? That way we could take > > the already developed Breeze ButtonStyle.qml and just ship it in

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63087 --- Concerning the icon names: for the Desktops Effects KCM the na

Re: Review Request 119455: make Button a QtControl

2014-07-24 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63086 --- Exciting! Might this eventually support a ButtonStyle.qml in

Review Request 119455: make Button a QtControl

2014-07-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119444: Replacing also kicon.h header include

2014-07-24 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119444/ --- (Updated July 24, 2014, 10:16 a.m.) Status -- This change has been m

Re: Review Request 119435: Replacing also kaction.h header include

2014-07-24 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119435/ --- (Updated July 24, 2014, 10:16 a.m.) Status -- This change has been m