Re: Review Request 119435: Replacing also kaction.h header include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119435/#review63029 --- Ship it! Ship It! - Laurent Montel On juil. 23, 2014, 9:26

Re: Review Request 119444: Replacing also kicon.h header include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119444/#review63030 --- Ship it! Ship It! - Laurent Montel On juil. 23, 2014, 11:0

Re: Review Request 119447: meinproc: check both result of parsing and validation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119447/#review63024 --- +1, makes sense to me, I don't see a drawback to further check

Review Request 119447: meinproc: check both result of parsing and validation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119447/ --- Review request for Documentation, KDE Frameworks and kdelibs. Repository:

Review Request 119446: Add a simple test for meinproc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119446/ --- Review request for Documentation, KDE Frameworks and kdelibs. Repository:

Review Request 119444: Replacing also kicon.h header include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119444/ --- Review request for KDE Frameworks. Repository: kde-dev-scripts Descript

Re: KF5 Porting: Installing Icons

On Wed, Jul 23, 2014 at 06:23:32PM -0400, David Narvaez wrote: > On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell wrote: > >> # The given icons, whose names must match the pattern:: > >> # > >> # --. > >> > >> seems to indicate I need to rename all of the files to remove the > >> theme from the

Re: KF5 Porting: Installing Icons

On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell wrote: >> # The given icons, whose names must match the pattern:: >> # >> # --. >> >> seems to indicate I need to rename all of the files to remove the >> theme from the prefix. > > Keep the theme name, preferably use hicolor for icons that are a

Re: KF5 Porting: Installing Icons

On Wed, Jul 23, 2014 at 06:08:42PM -0400, David Narvaez wrote: > This warning is for project developers. Use -Wno-dev to suppress it. > > is that I need to update to > which seems to me like I need to explicitly list all icons in the dir, and Yes you are advised to use the new install function a

KF5 Porting: Installing Icons

Hi, The information at [0] seems to indicate I just need to worry about renaming files to match the new categories (btw, is there a script for that?) but what I get from CMake Warning (dev) at /usr/share/ECM/modules/ECMInstallIcons.cmake:205 (message): ecm_install_icons() with no ICONS argument

Review Request 119435: Replacing also kaction.h header include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119435/ --- Review request for KDE Frameworks. Repository: kde-dev-scripts Descript

Re: Review Request 119377: Add highlighting commands

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/#review62977 --- Ship it! Ship It! - Christoph Cullmann On July 23, 2014, 3

Re: Review Request 119377: Add highlighting commands

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/ --- (Updated Juli 23, 2014, 5:08 nachm.) Review request for KDE Frameworks an

Re: Review Request 119406: Always take the painter based path for composeOverBorder

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/ --- (Updated July 23, 2014, 1:53 p.m.) Status -- This change has been ma

Re: KDELibs4Support fails to install on Windows if DocBookXML4 absent

El miércoles, 23 de julio de 2014, Luigi Toscano escribió: > On Wednesday 23 of July 2014 00:27:18 Nicolás Alvarez wrote: > > Hello, > > > > Currently KDELibs4Support fails to install on Windows. It gives the > > following error: > > > > CMake Error at src/cmake_install.cmake:264 (file): > > fi

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: KDELibs4Support fails to install on Windows if DocBookXML4 absent

On Wednesday 23 of July 2014 00:27:18 Nicolás Alvarez wrote: > Hello, > > Currently KDELibs4Support fails to install on Windows. It gives the > following error: > > CMake Error at src/cmake_install.cmake:264 (file): > file RELATIVE_PATH must be passed a full path to the file: > searched_dir-N

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: Review Request 119409: framework part of the applet alternatives shooser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 23, 2014, 10:31 a.m.) Status -- This change has been m

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: Review Request 119410: Document KDED dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119410/ --- (Updated July 23, 2014, 9:50 a.m.) Status -- This change has been ma

Re: Review Request 119409: framework part of the applet alternatives shooser

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 23, 2014, 9:18 a.m.) Review request for KDE Frameworks and

Re: Review Request 119406: Always take the painter based path for composeOverBorder

> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > >  > > > > - Compiler warning: > > > > fr

Re: Review Request 119410: Document KDED dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119410/#review62923 --- Ship it! Yes, KIO needs kded for favicons, cached passwords,