KDELibs4Support fails to install on Windows if DocBookXML4 absent

2014-07-22 Thread Nicolás Alvarez
Hello, Currently KDELibs4Support fails to install on Windows. It gives the following error: CMake Error at src/cmake_install.cmake:264 (file): file RELATIVE_PATH must be passed a full path to the file: searched_dir-NOTFOUND Call Stack (most recent call first): cmake_install.cmake:115 (inclu

Review Request 119417: kconfig: Fix QBasicAtomicInt being treated as int (reposted)

2014-07-22 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119417/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/#review62911 --- Two issues: - Existing Dialog instances don't get the corner

Re: Review Request 119410: Document KDED dependency.

2014-07-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119410/#review62902 --- Have to run now but want to comment so i don't forget. Have y

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread David Edmundson
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Jenkins build is back to normal : kconfig_master_qt5 #118

2014-07-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it > > Marco Martin w

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- (Updated July 22, 2014, 4:26 p.m.) Review request for KDE Frameworks, Ann

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Jonathan Riddell
On July 21, 2014, 4:24 p.m., Jonathan Riddell wrote: > > Also is it really worth having icons? I guess it's fine, but maybe it could > > be skipped. icons are nice :) - Jonathan --- This is an automatically generated e-mail. To reply,

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > Forgot to say, I think introducing a X-Plasma-Provides is ok. I guess that it will contain the concepts it's fulfilling, right? such as: X-Plasma-Provides=clock > On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/script

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 22, 2014, 4:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
> On July 22, 2014, 3:59 p.m., Aleix Pol Gonzalez wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 555 > > > > > > Why can't you just call the method? You're not delaying it ah, no, because th

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/#review62891 --- src/scriptengines/qml/plasmoid/appletinterface.cpp

Review Request 119410: Document KDED dependency.

2014-07-22 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119410/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 22, 2014, 3:40 p.m.) Review request for KDE Frameworks and

Review Request 119409: framework part of the applet alternatives shooser

2014-07-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/#review62888 --- +1, this escentially means that it now will use the same code

Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #70

2014-07-22 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (after extraction) [scripty] SVN_SILENT made messages (after extraction) [christoph] Indicate used text encoding in generated HTM

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-07-22 Thread Alexander Richardson
> On Juli 22, 2014, 9:24 vorm., David Faure wrote: > > src/lib/plugin/kpluginloader.h, line 316 > > > > > > is there a unittest for that? ( being a relative path) Yes there is for KPluginLoader::findPlugins(), b

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-07-22 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Juli 22, 2014, 1:17 nachm.) Review request for KDE Frameworks.

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- (Updated July 22, 2014, 9:12 a.m.) Review request for KDE Frameworks and

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Laurent Montel
> On juil. 22, 2014, 7:42 matin, Laurent Montel wrote: > > templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 > > > > > > bool KAboutData::setupCommandLine(QCommandLineParser *parser) > > { > >

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Jonathan Riddell
> On July 22, 2014, 7:42 a.m., Laurent Montel wrote: > > templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 > > > > > > bool KAboutData::setupCommandLine(QCommandLineParser *parser) > > { > > i

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/#review62848 --- templates/C++/kde-frameworks5-simple/src/main.cpp

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/#review62844 --- src/lib/plugin/kpluginloader.h