Re: git hooks for reviews mandatory?

2014-06-21 Thread Michael Pyne
On Sat, June 21, 2014 19:34:21 Kevin Ottens wrote: > On Saturday 21 June 2014 11:22:28 Michael Pyne wrote: > > On Thu, June 19, 2014 23:21:22 Marco Martin wrote: > > > Hi all, > > > I was thinking, since the policy for committing in frameworks is to > > > always > > > asking for a review, what abou

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Saturday 21 June 2014 11:22:28 Michael Pyne wrote: > On Thu, June 19, 2014 23:21:22 Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an hook that accept

Jenkins build is back to stable : ktexteditor_master_qt5 #427

2014-06-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118768: ECMAddTests: make NAME_PREFIX only apply to the test, not the target

2014-06-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118768/ --- (Updated June 21, 2014, 3:42 p.m.) Status -- This change has been ma

[extra-cmake-modules] modules: ECMAddTests: make NAME_PREFIX only apply to the test, not the target

2014-06-21 Thread Alex Merry
Git commit f6f1e8c7b8321389fe8268fc25254bd512a6f399 by Alex Merry. Committed on 15/06/2014 at 16:21. Pushed by alexmerry into branch 'master'. ECMAddTests: make NAME_PREFIX only apply to the test, not the target David Faure and Patrick Spendrin have convinced me that NAME_PREFIX should be informa

Re: Review Request 118768: ECMAddTests: make NAME_PREFIX only apply to the test, not the target

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118768/#review60667 --- This review has been submitted with commit f6f1e8c7b8321389fe

Re: git hooks for reviews mandatory?

2014-06-21 Thread Michael Pyne
On Thu, June 19, 2014 23:21:22 Marco Martin wrote: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have bee

Re: Review Request 118853: Log name + size of not found icons in debug output

2014-06-21 Thread Luigi Toscano
> On June 21, 2014, 11:36 a.m., Christoph Feck wrote: > > What is the status of categorized debugging/logging support in Qt, and how > > do we utilize that in our frameworks? > > > > If we are still simply using uncategorized qDebug(), please commit it. We can use qCDebug; the only problem is

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-21 Thread David Faure
> On June 17, 2014, 4:50 p.m., Matthew Dawson wrote: > > src/core/ksharedconfig.cpp, line 52 > > > > > > Why create a template function here, when the T must be > > GlobalSharedConfigList? Why not just put the l

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/ --- (Updated June 21, 2014, 9:37 a.m.) Review request for KDE Frameworks and

Re: Review Request 118853: Log name + size of not found icons in debug output

2014-06-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118853/#review60646 --- What is the status of categorized debugging/logging support in

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Friday 20 June 2014 22:11:57 Albert Astals Cid wrote: > El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure: > > I've heard of many complaints about how noisy is kde-frameworks mailing > > list because of review requests. Also, I fear there's people not working > > at full sp

Re: git hooks for reviews mandatory?

2014-06-21 Thread Kevin Ottens
On Friday 20 June 2014 13:13:20 Aleix Pol wrote: > On Fri, Jun 20, 2014 at 7:40 AM, Kevin Ottens wrote: > > On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > > > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin > > > > wrote: > > > > Hi all, > > > > I was thinking, since the policy for committing

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-21 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/ --- (Updated June 21, 2014, 7:39 a.m.) Status -- This change has been ma

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

2014-06-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60639 --- This review has been submitted with commit 4b498196899223692e