Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Ben Cooksley
On Tue, May 27, 2014 at 9:59 PM, Alex Merry wrote: > On Tuesday 27 May 2014 17:30:56 Ben Cooksley wrote: >> On Mon, May 26, 2014 at 9:04 PM, Alex Merry wrote: >> > On Monday 26 May 2014 19:41:33 Ben Cooksley wrote: >> >> On Mon, May 26, 2014 at 7:38 PM, wrote: >> >> > On 26 May 2014, at 09:35 ,

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Ben Cooksley
On Tue, May 27, 2014 at 9:55 PM, Alex Merry wrote: > On Monday 26 May 2014 20:37:23 mk-li...@email.de wrote: >> I hope that Ben can give me a hint about how to make use of proper variable >> substitution in that cfg file, since the following unfortunately doesn’t >> work: >> --- >> #configureExtra

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Ben Cooksley
On Tue, May 27, 2014 at 5:59 PM, Marko Käning wrote: > On 27 May 2014, at 07:29 , Ben Cooksley wrote: >> configurePlatformArgs=-DCMAKE_INSTALL_BUNDLEDIR="{installPrefix}/Applications” > > I ran into stg I had seen with my own trials to access the installPrefix > variable via %(*)s: > --- > Trace

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Ben Cooksley
On Tue, May 27, 2014 at 5:53 PM, Marko Käning wrote: > On 27 May 2014, at 07:29 , Ben Cooksley wrote: > >> Please try the following syntax instead. >> Note that I recommend you override this in >> config/build/darwin-mavericks.cfg instead to ensure all CMake projects >> on OS X are affected by it

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review58618 --- kcms/keyboard/flags.cpp

Re: Review Request 118359: Change {read, write}Check to *Entry for KUrl and KConfig.

2014-05-27 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118359/ --- (Updated May 27, 2014, 5:54 p.m.) Status -- This change has been mar

Re: Review Request 118359: Change {read, write}Check to *Entry for KUrl and KConfig.

2014-05-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118359/#review58612 --- Ship it! Ship It! - Alex Merry On May 27, 2014, 6:13 p.m.,

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-27 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 27, 2014, 9:02 p.m.) Review request for kde-workspace, KDE F

Review Request 118366: Porting keyboard module to Framework5

2014-05-27 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Reposi

Re: Review Request 118365: Porting keyboard module to framework 5

2014-05-27 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118365/ --- (Updated May 27, 2014, 8:50 p.m.) Status -- This change has been dis

Re: Review Request 118365: Porting keyboard module to framework 5

2014-05-27 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118365/ --- (Updated May 27, 2014, 8:48 p.m.) Review request for kde-workspace, KDE F

Review Request 118365: Porting keyboard module to framework 5

2014-05-27 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118365/ --- Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Reposi

Review Request 118362: handle the case of exact timeouts correctly

2014-05-27 Thread Ian Monroe
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118362/ --- Review request for KDE Frameworks. Repository: kidletime Description --

Re: Build failed in Jenkins: kdelibs4support_master_qt5 #203

2014-05-27 Thread Matthew Dawson
On May 27, 2014 04:03:03 PM Mark Gaiser wrote: > I looked at this issue and it is introduced by commit: > 5f4dc2973f10cd44b2c70680fee72dd8fc545d2f in kconfig. > Belonging to this review request: > https://git.reviewboard.kde.org/r/118039/ It removes readCheck and > writeCheck. > > I don't know wha

Review Request 118359: Change {read, write}Check to *Entry for KUrl and KConfig.

2014-05-27 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118359/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Loading Qt 5 translations

2014-05-27 Thread Aurélien Gâteau
On Mon, May 26, 2014, at 9:41, Alexander Potashev wrote: > 2014-05-26 18:17 GMT+04:00 Aurélien Gâteau : > > Not sure where we could put this. Frameworks load their translations, I > > believe it should be up to Qt to load its own translations. The only > > framework where it could maybe make sense

Re: Build failed in Jenkins: kdelibs4support_master_qt5 #203

2014-05-27 Thread Mark Gaiser
I looked at this issue and it is introduced by commit: 5f4dc2973f10cd44b2c70680fee72dd8fc545d2f in kconfig. Belonging to this review request: https://git.reviewboard.kde.org/r/118039/ It removes readCheck and writeCheck. I don't know what the intended fix would be for kdelibs4support which impleme

Re: Review Request 118352: Add more deprecated notes to KDialog

2014-05-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118352/#review58573 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 27, 2014, 1:

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/ --- (Updated May 27, 2014, 1:55 p.m.) Status -- This change has been mar

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58568 --- This review has been submitted with commit c9b553aa40612a65e5

Build failed in Jenkins: kdelibs4support_master_qt5 #203

2014-05-27 Thread KDE CI System
See -- [...truncated 1178 lines...] ^ : In static member function ‘static QStrin

Review Request 118352: Add more deprecated notes to KDialog

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118352/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Jens Reuterberg
> On May 27, 2014, 9:56 a.m., Christoph Feck wrote: > > I'll leave the decision which factor to use to the VDG. > > Thomas Pfeiffer wrote: > To get feedback from the VDG, I'd suggest adding alake to the request, > he's our expert on those matters. > > Sebastian Kügler wrote: > I've not

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Sebastian Kügler
> On May 27, 2014, 9:56 a.m., Christoph Feck wrote: > > I'll leave the decision which factor to use to the VDG. > > Thomas Pfeiffer wrote: > To get feedback from the VDG, I'd suggest adding alake to the request, > he's our expert on those matters. I've notified Jens, he's in a more conveni

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Thomas Pfeiffer
> On May 27, 2014, 9:56 a.m., Christoph Feck wrote: > > I'll leave the decision which factor to use to the VDG. To get feedback from the VDG, I'd suggest adding alake to the request, he's our expert on those matters. - Thomas --- This

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Alex Merry
On Tuesday 27 May 2014 17:30:56 Ben Cooksley wrote: > On Mon, May 26, 2014 at 9:04 PM, Alex Merry wrote: > > On Monday 26 May 2014 19:41:33 Ben Cooksley wrote: > >> On Mon, May 26, 2014 at 7:38 PM, wrote: > >> > On 26 May 2014, at 09:35 , Ben Cooksley wrote: > >> >> For reasons stated above, ap

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58546 --- Ship it! I'll leave the decision which factor to use to the V

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Alex Merry
On Monday 26 May 2014 20:37:23 mk-li...@email.de wrote: > I hope that Ben can give me a hint about how to make use of proper variable > substitution in that cfg file, since the following unfortunately doesn’t > work: > --- > #configureExtraArgs=-DCMAKE_INSTALL_BUNDLEDIR="%(installPrefix)s/lib/libex

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-27 Thread Matthew Dawson
On May 27, 2014 07:53:03 AM Marko Käning wrote: > On 27 May 2014, at 07:29 , Ben Cooksley wrote: > > Please try the following syntax instead. > > Note that I recommend you override this in > > config/build/darwin-mavericks.cfg instead to ensure all CMake projects > > on OS X are affected by it. >

Re: Review Request 118313: [Konqlib] KUrl -> QUrl

2014-05-27 Thread David Faure
> On May 25, 2014, 1:31 p.m., Emmanuel Pescosta wrote: > > lib/konq/konq_popupmenu.cpp, line 192 > > > > > > KUrl::cleanPath() -> QUrl::??? This is documented in kurl.h : url.setPath(QDir::cleanPath(url.path())