Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #65

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118197: Fix regression in NETRootInfo::sendPing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/#review58184 --- This review has been submitted with commit eb4f296767e5b3f17a

Re: Review Request 118197: Fix regression in NETRootInfo::sendPing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/ --- (Updated May 20, 2014, 5:27 a.m.) Status -- This change has been mar

Re: Review Request 117695: change where dynamic replace tabs is performed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/ --- (Updated May 19, 2014, 10:36 p.m.) Status -- This change has been ma

Re: Review Request 117695: change where dynamic replace tabs is performed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review58180 --- This review has been submitted with commit f9d33a959dd03cd4f3

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/ --- (Updated May 20, 2014, 12:26 a.m.) Review request for KDE Frameworks. C

Review Request 118211: Add an autotest for QDesigner plugin generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118211/ --- Review request for KDE Frameworks. Repository: kdesignerplugin Descript

Re: Review Request 118192: Fix/replace CMake macros provided by kdesignerplugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118192/ --- (Updated May 19, 2014, 9:57 p.m.) Review request for KDE Frameworks and A

Re: Review Request 117695: change where dynamic replace tabs is performed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review58172 --- Ship it! I think that is a better way to handle it than the o

Re: Framework Localization Policy

El Divendres, 16 de maig de 2014, a les 01:04:48, Aurélien Gâteau va escriure: > Hi, > > Finally took the time to document framework localization. You can find > the documentation here: > http://community.kde.org/Frameworks/Frameworks_Localization_Policy . > Feedback is welcome. Looks good to me.

Loading Qt 5 translations

Hi Translations for frameworks are loaded automatically when they are used, but what about Qt 5 itself? Are those translations loaded and if not, how should they be loaded? >From testing using German locale it looks like Qt 5 translations are not loaded. Most generic buttons like Ok, Close, Cance

Re: Review Request 118192: Do not set the INSTALL_RPATH_USE_LINK_PATH and INSTALL_RPATH properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118192/ --- (Updated May 19, 2014, 5:06 p.m.) Review request for KDE Frameworks and A

Re: Review Request 118195: Look for kded modules without kded_ prefix first

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118195/#review58167 --- This review has been submitted with commit 17977dcd85442a4cf8

Re: Review Request 118195: Look for kded modules without kded_ prefix first

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118195/ --- (Updated May 19, 2014, 5:02 p.m.) Status -- This change has been mar

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #418

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #418

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #417

See Changes: [notmart] it's a QGuiApplication -- [...truncated 351 lines...] Generating moc_framesvg.cpp Generating moc_packagestructure.cpp Generating moc_a

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #417

See Changes: [notmart] it's a QGuiApplication -- [...truncated 351 lines...] Generating moc_packagestructure.cpp Generating moc_associatedapplicationmanage

Re: Review Request 117695: change where dynamic replace tabs is performed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117695/#review58165 --- Looks good to me. Still, Christoph, since it touches the core

Re: Review Request 118195: Look for kded modules without kded_ prefix first

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118195/#review58164 --- Ship it! Perfect :) - David Faure On May 19, 2014, 2:39 p.

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #416

See Changes: [notmart] don't link agains KConfigWidgets -- [...truncated 370 lines...] Generating moc_effectwatcher_p.cpp [ 23%] [ 23%] Building CXX object

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #416

See Changes: [notmart] don't link agains KConfigWidgets -- [...truncated 371 lines...] [ 21%] Built target KF5Plasma_automoc [ 22%] Generating libplasma-th

Re: Review Request 118195: Look for kded modules without kded_ prefix first

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118195/ --- (Updated May 19, 2014, 2:39 p.m.) Review request for KDE Frameworks and D

Re: Review Request 118195: Look for kded modules without kded_ prefix first

> On May 19, 2014, 1:41 p.m., David Faure wrote: > > src/kded.cpp, line 373 > > > > > > !obj.contains('/') is slightly more readable > > > > Why this test, anyway? I don't really understand the logic her

Re: Review Request 118195: Look for kded modules without kded_ prefix first

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118195/#review58153 --- Idea sounds ok, just minor issues. src/kded.cpp

Re: Review Request 118116: Rename DBus interfaces to use new namespaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118116/ --- (Updated May 19, 2014, 6:57 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 118102: Use all entries from a cert attribute instead of just using the first one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118102/ --- (Updated May 19, 2014, 6:56 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 118197: Fix regression in NETRootInfo::sendPing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/#review58151 --- Ship it! ... and is the only theoretically correct procedure

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58144 --- This review has been submitted with commit c5c34851dc410aa146

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- (Updated May 19, 2014, 12:07 p.m.) Status -- This change has been ma

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58142 --- Ship it! Ship It! - Marco Martin On May 19, 2014, 10:56 a.

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

> On May 19, 2014, 1:06 p.m., Marco Martin wrote: > > looks fine. > > can you try it also on an item that uses dbusmenu for menus, like kmix? I just tried kmix and it looks fine to me on both left and right click. Both menus behave like I would expect (override redirect, grabbing pointer/keyboa

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58139 --- looks fine. can you try it also on an item that uses dbusmenu

Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: k

Re: GenerateExportHeader and clang

On 18/05/14 20:03, Ivan Čukić wrote: > >> Ah, but what is clang's return value when there is an unrecognized option? > > It is 0. That is why I find the situation so strange. :) And I thought I was being clever :-) It turns out that GenerateExportHeader uses check_cxx_compiler_flag, which greps

Re: Review Request 118197: Fix regression in NETRootInfo::sendPing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/#review58132 --- Ship it! Fix tested and confirmed. - Eike Hein On May 19,

Review Request 118197: Fix regression in NETRootInfo::sendPing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118197/ --- Review request for KDE Frameworks, kwin and Eike Hein. Bugs: 335024 h

Re: Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

> On May 16, 2014, 3:38 p.m., Thomas Lübking wrote: > > a) main.cpp, void Application::start() > > -Xcb::sync(); > > owner->claim(m_replace, true); > > +Xcb::sync(); > > Sufficient? (though it warns about a QPA crash "later") > > > > b) Qt bug (should flush once per eventcycle) or fe