Re: Review Request 118167: Flush xcb connection after preparing KSelectionOwner::claim

2014-05-18 Thread Martin Gräßlin
> On May 16, 2014, 3:38 p.m., Thomas Lübking wrote: > > a) main.cpp, void Application::start() > > -Xcb::sync(); > > owner->claim(m_replace, true); > > +Xcb::sync(); > > Sufficient? (though it warns about a QPA crash "later") > > > > b) Qt bug (should flush once per eventcycle) or fe

Re: GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
> Ah, but what is clang's return value when there is an unrecognized option? It is 0. That is why I find the situation so strange. :) Cheers, Ivan -- A program that has not been tested does not work. -- Bjarne Stroustrup ___ Kde-frameworks-devel

Re: GenerateExportHeader and clang

2014-05-18 Thread Alex Merry
On 18/05/14 19:07, Ivan Čukić wrote: >> Although if they fail, I think hidden visibility shouldn't be turned on, > > They are not for some reason. The symbol is visible through 'nm', but is > marked as 't' - local symbol in text area. > >> Anyway, the relevant file is CMakeFiles/CMakeOutput.log

Review Request 118195: Look for kded modules without kded_ prefix first

2014-05-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118195/ --- Review request for KDE Frameworks and David Faure. Repository: kded Des

Re: GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
> Although if they fail, I think hidden visibility shouldn't be turned on, They are not for some reason. The symbol is visible through 'nm', but is marked as 't' - local symbol in text area. > Anyway, the relevant file is CMakeFiles/CMakeOutput.log in the build Yes, just finished dealing with i

Re: GenerateExportHeader and clang

2014-05-18 Thread Alex Merry
On 18/05/14 18:42, Ivan Čukić wrote: > On Sunday 18 May 2014 18:28:00 Alex Merry wrote: >> Nope, all looks fine to me when I build KCoreAddons. Configure output has: > > Fun. For me both 3.4 and 3.5 (trunk) fail. > > -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY > -- Performing Test COMPILER_

Re: GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
On Sunday 18 May 2014 18:28:00 Alex Merry wrote: > Nope, all looks fine to me when I build KCoreAddons. Configure output has: Fun. For me both 3.4 and 3.5 (trunk) fail. -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Failed -- Performing Test

Re: GenerateExportHeader and clang

2014-05-18 Thread Alex Merry
On 18/05/14 17:50, Ivan Čukić wrote: > Hi, > > When compiling libraries that use GenerateExportHeader with clang 3.5.0, I'm > getting a library without any methods exported. > > I'm using the same CMake invocation is as kdesrc-build does, only with > -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++

GenerateExportHeader and clang

2014-05-18 Thread Ivan Čukić
Hi, When compiling libraries that use GenerateExportHeader with clang 3.5.0, I'm getting a library without any methods exported. I'm using the same CMake invocation is as kdesrc-build does, only with -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ \ -DCMAKE_C_COMPILER=/usr/local/bin/clang Generat

CMake package files location

2014-05-18 Thread Alex Merry
I'm reviewing the frameworks I maintain, and one of things listed that I should check is the directory structure: http://community.kde.org/Frameworks/Policies#Framework_directory_structure This has the line "CMake modules (FindFoo.cmake etc.) or CMake macro files go into cmake subdirectory". Now,

Review Request 118193: Use the macros provided by KDesignerPlugin

2014-05-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118193/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Review Request 118192: Fix/replace CMake macros provided by kdesignerplugin

2014-05-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118192/ --- Review request for KDE Frameworks and Alex Merry. Repository: kdesignerpl