Jenkins build is back to stable : kdelibs4support_master_qt5 #156

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kinit_master_qt5 #66

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kinit_master_qt5 #65

2014-04-26 Thread KDE CI System
See Changes: [aleixpol] KF5 libexec files are now located in lib/libexec/kf5 -- [...truncated 12 lines...] == Cleaning Source Tree HEAD is now at 3cf90b5 Add framework information in metainfo.yaml fi

Review Request 117799: Clean up private slots in KCompletion

2014-04-26 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117799/ --- Review request for KDE Frameworks. Repository: kcompletion Description

Re: Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-26 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/#review56655 --- Ship it! Ship It! - Chusslove Illich On April 22, 2014, 3:

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

2014-04-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117795/#review56646 --- src/depdiagram-prepare

Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

2014-04-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117795/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox D

Jenkins build became unstable: kdelibs4support_master_qt5 #152

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #53

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/#review56638 --- This review has been submitted with commit b7887433d5dd44a441

Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability

2014-04-26 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- (Updated April 26, 2014, 5:39 p.m.) Status -- This change has been m

Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability

2014-04-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/#review56637 --- Ship it! Ship It! - Kevin Ottens On April 26, 2014, 4:48 p

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/#review56636 --- This review has been submitted with commit 65833d5f436cad860f

Re: Review Request 117708: move kioslave docs paths for co-installability

2014-04-26 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/ --- (Updated April 26, 2014, 5:24 p.m.) Status -- This change has been m

Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability

2014-04-26 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117792/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56631 --- This review has been submitted with commit fd6d554d8af7fe74d6

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56632 --- This review has been submitted with commit 7cd8252d2c662c6db4

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 26, 2014, 3:40 p.m.) Status -- This change has been m

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56633 --- This review has been submitted with commit 2fc7aeab836b0e4036

Re: Review Request 117688: Do not skip a language if there is no application catalog for it

2014-04-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117688/#review56630 --- Ship it! Ship It! - Kevin Ottens On April 22, 2014, 1:39 p

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56629 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 7:18 p

Jenkins build is back to normal : ktexteditor_master_qt5 #372

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #52

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kpty_master_qt5 #30

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kross_master_qt5 #46

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kmediaplayer_master_qt5 #43

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : khtml_master_qt5 #77

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdewebkit_master_qt5 #35

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Infopage in frameworkintegration

2014-04-26 Thread Albert Astals Cid
El Dissabte, 26 d'abril de 2014, a les 13:26:31, Alex Merry va escriure: > FrameworkIntegration installs a bunch of images and css files to > ${DATA_INSTALL_DIR}/kf5/infopage. LXR suggests nothing ever references > an "infopage" directory (either in kf5-qt5 or in qt4-latest), except for > the CMake

Re: Review Request 117781: Install again the content of common/, prepare for other languages too

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56620 --- This review has been submitted with commit fd96fa5b175d965bbe

Re: Review Request 117781: Install again the content of common/, prepare for other languages too

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56619 --- This review has been submitted with commit 75ba2ae6c1f35056cb

Re: Review Request 117781: Install again the content of common/, prepare for other languages too

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56622 --- This review has been submitted with commit 1cd33b3cad5c9a38d3

Re: Review Request 117781: Install again the content of common/, prepare for other languages too

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56621 --- This review has been submitted with commit 184882c4c5418a9fc9

Re: Review Request 117781: Install again the content of common/, prepare for other languages too

2014-04-26 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- (Updated April 26, 2014, 1:29 p.m.) Status -- This change has been m

Re: Review request: kdeebugdialog5 co-installability

2014-04-26 Thread David Faure
On Thursday 24 April 2014 14:49:00 Jonathan Riddell wrote: > Reviewboard does not like this patch and even my usual goto man for git help > agateau can't work out why. So here's a manual review request > > kdelibs4support: > http://starsky.19inch.net/~jr/tmp/DIFF This seems to be about oxygen r

Re: plasma-framework in kdereview

2014-04-26 Thread Marco Martin
On Saturday, April 26, 2014, David Faure wrote: >> David is acting on the move as I'm typing that email. Stay tuned! :-) > > plasma-framework is now under frameworks/. > > kdesrc-build users, remember to do > rm -rf kdereview/plasma-framework playground/libs/plasma-framework > to avoid hacking in

Re: Why is plasma-framework using /usr/share/kde5?

2014-04-26 Thread David Faure
On Tuesday 22 April 2014 10:40:45 Daniel Vrátil wrote: > On Monday 21 of April 2014 17:32:10 you wrote: > > On Tuesday 15 April 2014 18:14:36 Daniel Vrátil wrote: > > > Hi, > > > > > > I'm wondering why Plasma Framework installs it's .desktop files to > > > /usr/share/kde5 by default? It causes so

Infopage in frameworkintegration

2014-04-26 Thread Alex Merry
FrameworkIntegration installs a bunch of images and css files to ${DATA_INSTALL_DIR}/kf5/infopage. LXR suggests nothing ever references an "infopage" directory (either in kf5-qt5 or in qt4-latest), except for the CMakeLists.txt files in frameworkintegration, and the README.md (which suggests the im

Jenkins build is back to normal : frameworkintegration_master_qt5 #65

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #309

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kio_master_qt5 #168

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #51

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kmediaplayer_master_qt5 #42

2014-04-26 Thread KDE CI System
See Changes: [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: kio_master_qt5 #167

2014-04-26 Thread KDE CI System
See Changes: [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: kdewebkit_master_qt5 #34

2014-04-26 Thread KDE CI System
See Changes: [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace <

Build failed in Jenkins: khtml_master_qt5 #76

2014-04-26 Thread KDE CI System
See Changes: [aleixpol] flag.png was renamed to kf5_flag.png [faure] cleanup after non-idempotent script -- Started by remote host 127.0.0.1 with note: Triggered by commit Started by remote host 127.0

Build failed in Jenkins: kdelibs4support_master_qt5 #146

2014-04-26 Thread KDE CI System
See Changes: [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break [aleixpol] Add l10n to be installed [aleixpol] Cannot rename 2 thing

Build failed in Jenkins: frameworkintegration_master_qt5 #64

2014-04-26 Thread KDE CI System
See Changes: [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break [faure] cleanup after non-idempotent script

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #308

2014-04-26 Thread KDE CI System
See Changes: [alex.merry] Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS -- Started by upstream project "plasma-framework_master_qt5" build

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #50

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kwallet_master_qt5 #95

2014-04-26 Thread KDE CI System
See Changes: [alex.merry] Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break

Build failed in Jenkins: ktexteditor_master_qt5 #371

2014-04-26 Thread KDE CI System
See Changes: [alex.merry] Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't b

Build failed in Jenkins: kross_master_qt5 #45

2014-04-26 Thread KDE CI System
See Changes: [alex.merry] Use KF5_INCLUDE_INSTALL_DIR and KF5_INSTALL_TARGETS_DEFAULT_ARGS [faure] separate framework version from dependencies version, to be able to increase the version in two steps at release time, so CI doesn't break [

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-26 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/ --- (Updated April 26, 2014, 11:21 a.m.) Status -- This change has been

Re: Review Request 117511: Add class for finding the kde4 config and apps home dirs.

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117511/#review56610 --- This review has been submitted with commit 669a089e8cbb3c15a0

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #49

2014-04-26 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-26 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/ --- (Updated April 26, 2014, 10:41 a.m.) Status -- This change has been

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-26 Thread David Faure
> On April 23, 2014, 5:09 p.m., David Faure wrote: > > The reason I did it this way was because existing application code uses > > > > #include > > #include > > etc. > > See e.g. > > http://lxr.kde.org/source/kde/kdelibs/kross/kjs/kjsscript.cpp?v=stable-qt4 > > > > So I picked the "namespace

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/#review56605 --- This review has been submitted with commit 856fcbab0765ce21c1

Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-26 Thread Aleix Pol Gonzalez
> On April 23, 2014, 5:09 p.m., David Faure wrote: > > The reason I did it this way was because existing application code uses > > > > #include > > #include > > etc. > > See e.g. > > http://lxr.kde.org/source/kde/kdelibs/kross/kjs/kjsscript.cpp?v=stable-qt4 > > > > So I picked the "namespace

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Alex Merry
> On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: > > Would it be a good idea to start by reverting > > https://git.reviewboard.kde.org/r/116096/ ? > > Alex Merry wrote: > So we have no unit tests? I don't really see how that would help (except > in the strict sense of no unit tests =>

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Stephen Kelly
> On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: > > Would it be a good idea to start by reverting > > https://git.reviewboard.kde.org/r/116096/ ? > > Alex Merry wrote: > So we have no unit tests? I don't really see how that would help (except > in the strict sense of no unit tests =>

Re: RFC: Do we want the entire commit history to be pushed if code is moved to another repository?

2014-04-26 Thread David Faure
On Saturday 26 April 2014 09:20:08 Frank Reininghaus wrote: > Hi everyone, > > when kdelibs was split into the different frameworks repositories, the > git history was dropped. I think that this was a good idea - splitting > the history properly would have been an extremely complex task, and > eve

Re: plasma-framework in kdereview

2014-04-26 Thread David Faure
On Saturday 26 April 2014 10:56:00 Kevin Ottens wrote: > Hello, > > On Saturday 26 April 2014 02:33:07 Kevin Ottens wrote: > > On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: > > > El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va > > escriure: > > > > since it was don

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Alex Merry
> On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: > > Would it be a good idea to start by reverting > > https://git.reviewboard.kde.org/r/116096/ ? So we have no unit tests? I don't really see how that would help (except in the strict sense of no unit tests => no failing unit tests). - Al

Re: Review Request 117780: Add a FindKF5.cmake module

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/#review56596 --- This review has been submitted with commit 12e3e7e2d6685aa29a

Re: Review Request 117780: Add a FindKF5.cmake module

2014-04-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/ --- (Updated April 26, 2014, 9:07 a.m.) Status -- This change has been m

Re: plasma-framework in kdereview

2014-04-26 Thread Kevin Ottens
Hello, On Saturday 26 April 2014 02:33:07 Kevin Ottens wrote: > On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: > > El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: > > > since it was done earlier this week, better announce it formally, so > > > everybody ca

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56594 --- Would it be a good idea to start by reverting https://git.rev

Re: Update your copy of extra-cmake-modules

2014-04-26 Thread Aurélien Gâteau
Alex Merry wrote: > On 21/04/14 16:26, šumski wrote: >> On Friday 18 of April 2014 10:37:50 Aurélien Gâteau wrote: >> ... >>> I made it that way intentionally because I consider it bad to have >>> different code generated depending on whether you have the framework is >>> built from a release tarb

Re: Review Request 117781: Install again the content of common/, prepare for other languages too

2014-04-26 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/#review56593 --- Ship it! Lokks good to me, thanks - Burkhard Lück On April

Re: RFC: Do we want the entire commit history to be pushed if code is moved to another repository?

2014-04-26 Thread Ben Cooksley
On Sat, Apr 26, 2014 at 7:20 PM, Frank Reininghaus wrote: > Hi everyone, > > when kdelibs was split into the different frameworks repositories, the > git history was dropped. I think that this was a good idea - splitting > the history properly would have been an extremely complex task, and > every

RFC: Do we want the entire commit history to be pushed if code is moved to another repository?

2014-04-26 Thread Frank Reininghaus
Hi everyone, when kdelibs was split into the different frameworks repositories, the git history was dropped. I think that this was a good idea - splitting the history properly would have been an extremely complex task, and everyone who wants to do source code archaelogy can just look at the kdelib