Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Albert Astals Cid
El Dissabte, 8 de febrer de 2014, a les 16:32:04, David Faure va escriure: > On Saturday 08 February 2014 14:13:40 Ivan Čukić wrote: > > On Saturday, 8. February 2014. 12.58.53 David Faure wrote: > > > Also, kactivities is the only framework that still uses a branch named > > > "frameworks". > > >

Re: Building frameworks: docbook problems

2014-02-08 Thread Andriy Rysin
On 02/07/2014 04:01 AM, David Faure wrote: > On Monday 03 February 2014 22:08:20 Andriy Rysin wrote: >> I am trying to build frameworks using >> http://community.kde.org/Frameworks/Building on Fedora 20 and it failes >> in several modules due to some docbook problem, e.g. in kconfigwidgets: >> >> S

Jenkins build is back to normal : kcompletion_master_qt5 #29

2014-02-08 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

2014-02-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/#review49300 --- This review has been submitted with commit 6bac05aad6f4d326fd

Build failed in Jenkins: kcompletion_master_qt5 #28

2014-02-08 Thread KDE CI System
See Changes: [davidgiloliva] Hide a private method and a private slot of KComboBox behind the d-pointer -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on Li

Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

2014-02-08 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/ --- (Updated Feb. 8, 2014, 9:59 p.m.) Status -- This change has been mar

Re: Review Request 115541: Build fix for Mac OS X

2014-02-08 Thread Harald Fernengel
> On Feb. 8, 2014, 10:07 a.m., David Faure wrote: > > Urgh, we were hoping this wouldn't be an issue. > > > > This commit would break #include , so it cannot go in. > > > > All "namespaced" frameworks do it this way already btw, see kparts for > > instance: > > > > -- Up-to-date: > > /d/kde/

Review Request 115586: Improve attica tests

2014-02-08 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115586/ --- Review request for KDE Frameworks. Repository: attica Description -

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread David Faure
> On Feb. 8, 2014, 5:34 p.m., David Faure wrote: > > Looks good, but then you have 56 other frameworks where to add a > > if(BUILD_TESTING) around add_subdirectory(tests) and > > add_subdirectory(autotests) :-) > > Michael Palimaka wrote: > That's fine, do I need to do a review request for

Review Request 115584: Remove kfileaudiopreview transitive dependencies

2014-02-08 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115584/ --- Review request for KDE Frameworks. Repository: kfileaudiopreview Descri

Jenkins build is back to normal : plasma-framework_master_qt5 #1140

2014-02-08 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #1139

2014-02-08 Thread KDE CI System
See Changes: [faure] Port to updated KActivities -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 in workspace

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread Michael Palimaka
> On Feb. 8, 2014, 5:34 p.m., David Faure wrote: > > Looks good, but then you have 56 other frameworks where to add a > > if(BUILD_TESTING) around add_subdirectory(tests) and > > add_subdirectory(autotests) :-) > > Michael Palimaka wrote: > That's fine, do I need to do a review request for

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread David Faure
> On Feb. 8, 2014, 5:34 p.m., David Faure wrote: > > Looks good, but then you have 56 other frameworks where to add a > > if(BUILD_TESTING) around add_subdirectory(tests) and > > add_subdirectory(autotests) :-) > > Michael Palimaka wrote: > That's fine, do I need to do a review request for

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/ --- (Updated Feb. 8, 2014, 5:39 p.m.) Status -- This change has been mar

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review49266 --- This review has been submitted with commit f82baa287631fd1d83

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread Michael Palimaka
> On Feb. 8, 2014, 5:34 p.m., David Faure wrote: > > Looks good, but then you have 56 other frameworks where to add a > > if(BUILD_TESTING) around add_subdirectory(tests) and > > add_subdirectory(autotests) :-) That's fine, do I need to do a review request for all of those that have just that

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/#review49264 --- Ship it! Looks good, but then you have 56 other frameworks wh

Re: Review Request 115424: Improve kparts dependencies

2014-02-08 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115424/ --- (Updated Feb. 8, 2014, 5:32 p.m.) Review request for KDE Frameworks and D

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
On Saturday 08 February 2014, David Faure wrote: > * plasma-framework depends on kactivities which is also not a proper > framework. Shall we make it one and release it together with the others? > It needs a bit of updating in the cmake stuff (it has too many of the > usually toplevel stuff like

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Ivan Čukić
> more and more places - and especially all of the frameworks themselves. Ok, I'm game for the branch switch. Is there any documentation on how/what should be done to the cmake parts? p.s. > Since then, kdelibs got splitted, so as I said, KF5 stuff is "master" in The thread in question is from

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
On Saturday 08 February 2014 14:13:40 Ivan Čukić wrote: > On Saturday, 8. February 2014. 12.58.53 David Faure wrote: > > Also, kactivities is the only framework that still uses a branch named > > "frameworks". > > > > Can we switch to master = kf5 and KDE/4.13 for the current master, > > assuming

Re: HAVE_X11 usage in KIO/core

2014-02-08 Thread Christoph Feck
On Saturday 08 February 2014 00:55:22 Albert Astals Cid wrote: > [about the "X11" string in user agent] > > Sincerely, just drop it. > > We will change from sending > > Mozilla/5.0 (compatible; Konqueror/4.0; Linux; X11; i686; en_US) > KHTML/4.0.1 (like Gecko) > > to > > Mozilla/5.0 (compatible

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Ivan Čukić
On Saturday, 8. February 2014. 12.58.53 David Faure wrote: > Also, kactivities is the only framework that still uses a branch named > "frameworks". > > Can we switch to master = kf5 and KDE/4.13 for the current master, assuming > a 4.13 release of it is planned? [otherwise what do we do with maste

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Ivan Čukić
On Saturday, 8. February 2014. 13.26.41 you wrote: > On Saturday 08 February 2014 12:44:48 David Faure wrote: > > * plasma-framework depends on kactivities which is also not a proper > > framework. Shall we make it one and release it together with the others? > > It needs a bit of updating in the

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-08 Thread Ivan Romanov
> On Feb. 8, 2014, 6:42 p.m., Ivan Romanov wrote: > > Use tabs (not spaces) for intendation. Also split very long lines. *indentation - Ivan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 115540: Wrap string literals in QStringLiteral in headers so projects with QT_NO_CAST_FROM_ASCII can use them

2014-02-08 Thread Ivan Romanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115540/#review49246 --- Use tabs (not spaces) for intendation. Also split very long li

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
On Saturday 08 February 2014 12:44:48 David Faure wrote: > * plasma-framework depends on kactivities which is also not a proper > framework. Shall we make it one and release it together with the others? > It needs a bit of updating in the cmake stuff (it has too many of the > usually toplevel stu

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
Also, kactivities is the only framework that still uses a branch named "frameworks". Can we switch to master = kf5 and KDE/4.13 for the current master, assuming a 4.13 release of it is planned? [otherwise what do we do with master?] The only commit that is in master and not in 4.12 is this one

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
On Saturday 08 February 2014 11:36:26 Marco Martin wrote: > On Saturday 08 February 2014 10:59:19 David Faure wrote: > > On Saturday 08 February 2014 10:55:25 Marco Martin wrote: > > > On Saturday 08 February 2014 10:31:10 David Faure wrote: > > > > > * it's not under frameworks/ in the projects.kd

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

2014-02-08 Thread David Faure
On Sunday 26 January 2014 00:20:02 Friedrich W. H. Kossebau wrote: > > > }; > > > > I think it makes sense to have two methods, at two different layers. > > The KFormat one is like Qt: the caller of the method decides what they > > want. The KIO one is as we like things in KDE, very often: it take

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
On Saturday 08 February 2014 10:59:19 David Faure wrote: > On Saturday 08 February 2014 10:55:25 Marco Martin wrote: > > On Saturday 08 February 2014 10:31:10 David Faure wrote: > > > > * it's not under frameworks/ in the projects.kde.org hierarchy. Shall > > > > we > > > > move it? > > > > > > >

Re: Repository rename and consequences

2014-02-08 Thread Michael Pyne
On Sat, February 8, 2014 10:58:23 Ben Cooksley wrote: > Once the procedure has been completed, automated build scripts such as > kdesrc-build should automatically clone the repositories under their > new names - however custom scripts and procedures will need to be > adjusted by hand. I would just

Re: Review Request 115524: Hide a private method and a private slot of KComboBox behind the d-pointer

2014-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115524/#review49241 --- Ship it! Ship It! - David Faure On Feb. 6, 2014, 10:35 p.m

Re: Review Request 115541: Build fix for Mac OS X

2014-02-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541/#review49240 --- Urgh, we were hoping this wouldn't be an issue. This commit w

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
On Saturday 08 February 2014 10:55:25 Marco Martin wrote: > On Saturday 08 February 2014 10:31:10 David Faure wrote: > > > * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we > > > move it? > > > > > > * it declares itself to be version 2.0.0. Can I change that to 4.96.0 > > >

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
On Saturday 08 February 2014 10:31:10 David Faure wrote: > > > > * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we > > move it? > > > > * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like > > all other frameworks? > > Ping? It's now or never, for alp

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
On Thursday 06 February 2014 23:32:11 David Faure wrote: > On Wednesday 05 February 2014 22:42:00 Michael Palimaka wrote: > > On 02/03/2014 08:17 PM, David Faure wrote: > > > Any new module that should be added to this release, compared to TP1? > > > > I see that plasma-framework.yaml says tier 3,