Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: Review Request 115047: Fix substitution order for some KUIT elements with attributes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115047/ --- (Updated Jan. 15, 2014, 9:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 114971: Remove unused common files and do not install any of them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/#review47472 --- Ship it! > I don't think we should be installing the licenses

Re: Review Request 114969: Add common files required for documentation generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/#review47471 --- Ship it! I think there is no way to save the old history for

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

On 01/15/2014 12:15 PM, Alex Merry wrote: > On 15/01/14 07:36, Valentin Rusu wrote: >> On 01/15/2014 07:16 AM, Ben Cooksley wrote: >>> It seems you are relying on D-Bus auto-launching. Is this the case? >> >> Yes, the kwallet API uses DBus activation to get kwalletd up un running. >> If that's alre

Re: Review Request 115021: Fix build without X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/#review47458 --- This review has been submitted with commit a52839a1297d20ad2b

Re: Review Request 115021: Fix build without X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/ --- (Updated Jan. 15, 2014, 3:15 p.m.) Status -- This change has been ma

Re: Review Request 115021: Fix build without X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/#review47457 --- Ship it! Ship It! - Nicolás Alvarez On Jan. 15, 2014, 6:49

Re: Review Request 114973: Remove spurious image files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/ --- (Updated Jan. 15, 2014, 2:49 p.m.) Status -- This change has been ma

Re: Review Request 114979: Do not install licenses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/#review47456 --- This review has been submitted with commit 43eec02513ab92b465

Re: Review Request 114979: Do not install licenses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/ --- (Updated Jan. 15, 2014, 2:54 p.m.) Status -- This change has been ma

Re: Review Request 114972: Trim default settings from Doxyfile.global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/#review47454 --- This review has been submitted with commit 8a7650c12de04486af

Re: Review Request 114973: Remove spurious image files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/#review47455 --- This review has been submitted with commit 1db8547e62d528705a

Re: Review Request 114972: Trim default settings from Doxyfile.global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/ --- (Updated Jan. 15, 2014, 2:49 p.m.) Status -- This change has been ma

Re: Review Request 114973: Remove spurious image files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/#review47452 --- Ship it! Those are left overs: the apidox folder used to cont

Re: Review Request 114979: Do not install licenses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/#review47453 --- Ship it! Makes sense, thanks! - Aurélien Gâteau On Jan. 15

Re: Review Request 114971: Remove unused common files and do not install any of them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/#review47449 --- Ship it! Makes sense to me. - Aurélien Gâteau On Jan. 15,

Re: Review Request 114972: Trim default settings from Doxyfile.global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/#review47451 --- Ship it! Much nicer, indeed. - Aurélien Gâteau On Jan. 15,

Re: Review Request 114969: Add common files required for documentation generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/#review47450 --- Makes sense to me , but I leave it up to Luigi to give the "Sh

Review Request 115030: Install public headers for KJsEmbed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115030/ --- Review request for KDE Frameworks. Repository: kjsembed Description ---

Re: Review Request 114973: Remove spurious image files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114973/ --- (Updated Jan. 15, 2014, 2:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 114972: Trim default settings from Doxyfile.global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114972/ --- (Updated Jan. 15, 2014, 2:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 114979: Do not install licenses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114979/ --- (Updated Jan. 15, 2014, 2:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 114969: Add common files required for documentation generation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114969/ --- (Updated Jan. 15, 2014, 2:08 p.m.) Review request for KDE Frameworks, Aur

Re: Review Request 114971: Remove unused common files and do not install any of them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114971/ --- (Updated Jan. 15, 2014, 2:08 p.m.) Review request for KDE Frameworks, Aur

Review Request 115028: Allow the building of deprecated code to be disabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115028/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Ktextwidget module

Hi, I will maintain this module. I spoke this morning with David Gil and he is ok with it. This is used a lot in kdepim/kmail and I worked on it (in kdelibs) before. So I am interesting to maintain it. I will change name in wiki. Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Sen

Re: Review Request 115016: Make KJob usable from QML

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115016/#review47440 --- Ship it! After Kevin Krammer's comment on the list, I realise

Re: Review Request 115016: Make KJob usable from QML

On 15/01/14 12:43, Kevin Krammer wrote: > On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote: >> A NOTIFY signal is optional. If defined, it should specify one existing >> signal in that class that is emitted whenever the value of the property >> changes. NOTIFY signals for MEMBER variables mu

Re: Review Request 115016: Make KJob usable from QML

On Tuesday, 2014-01-14, 23:12:56, Aurélien Gâteau wrote: > > On Jan. 14, 2014, 9:20 p.m., Alex Merry wrote: > > > src/lib/jobs/kjob.h, line 92 > > > > > line92>> > > > > I don't think this will work; I'm fairly sure tha

Review Request 115026: Remove commented out code for QX11EmbedContainer/WhatsThis

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115026/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 115024: Remove check for X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115024/ --- (Updated Jan. 15, 2014, 12:21 p.m.) Review request for KDE Frameworks and

Review Request 115024: Remove check for X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115024/ --- Review request for KDE Frameworks and Andreas Hartmetz. Repository: kxmlg

Re: Review Request 114962: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/ --- (Updated Jan. 15, 2014, 12:13 p.m.) Status -- This change has been m

Re: Review Request 114962: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47437 --- This review has been submitted with commit 7e315ef53a9574ee17

Re: Review Request 114962: Improve dependency specifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114962/#review47436 --- Ship it! Ship It! - David Faure On Jan. 15, 2014, 5:54 a.m

Re: Review Request 115023: Remove unused dependency

> On Jan. 15, 2014, 11:33 a.m., Alex Merry wrote: > > CMakeLists.txt, lines 33-35 > > > > > > This got me wondering if we even need X11; it looks like it's not used > > directly, and it just uses HAVE_X11 in a fr

Re: Review Request 115023: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115023/#review47430 --- This review has been submitted with commit 9677ec08b4d00895c5

Re: Review Request 115023: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115023/ --- (Updated Jan. 15, 2014, 11:35 a.m.) Status -- This change has been m

Re: Review Request 115023: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115023/#review47429 --- Ship it! CMakeLists.txt

Review Request 115023: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115023/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Jenkins build became unstable: kwallet-framework_master_qt5 #21

On 15/01/14 07:36, Valentin Rusu wrote: > On 01/15/2014 07:16 AM, Ben Cooksley wrote: >> It seems you are relying on D-Bus auto-launching. Is this the case? > > Yes, the kwallet API uses DBus activation to get kwalletd up un running. > If that's already in place, then I realize that we need anothe

Re: Integrating kf5dot and kapidox

On Tue, Jan 14, 2014, at 6:53, Alex Merry wrote: > On 14/01/14 08:58, Aurélien Gâteau wrote: > > On Mon, Jan 13, 2014, at 14:34, Alex Merry wrote: > >> On 13/01/14 21:36, Aurélien Gâteau wrote: > >>> Second, api.kde.org deployment. kf5dot-prepare needs to be able to run > >>> CMake on the source

Review Request 115022: Remove unused dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115022/ --- Review request for KDE Frameworks. Repository: kdesu Description --

Review Request 115021: Fix build without X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115021/ --- Review request for KDE Frameworks. Repository: kdesu Description --