---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/#review46422
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 29, 2013, 1
On Sun, Dec 29, 2013 at 8:10 PM, David Faure wrote:
> On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote:
> > > On Friday 27 December 2013 19:36:57 Aleix Pol wrote:
> > > > Hi,
> > > > Here's a patch adding CamelCase headers to KCoreAddons (attached).
> > > >
> > > > If we agree that it
On Sun, Dec 29, 2013 at 4:12 PM, Michal Humpula wrote:
> On Sunday 29 of December 2013 14:44:59 David Faure wrote:
> > On Thursday 19 December 2013 15:28:27 Dominik Haumann wrote:
> > > On Thursday, December 19, 2013 15:12:01 Michal Humpula wrote:
> > > > On Thursday 19 of December 2013 14:57:33 D
On Sun, Dec 29, 2013 at 08:07:38PM +0100, Christoph Cullmann wrote:
> if I play around with Kate on KF5, it laggs like hell the whole time.
>
> I tried to profile, but guess I am stuck a bit.
How did you profile? I'd recommend using 'perf', it's pretty simple to use:
- perf record ./kate
- per
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/
---
(Updated Dec. 29, 2013, 11:50 p.m.)
Review request for KDE Frameworks.
Am Sonntag, 29. Dezember 2013, 17:39:47 schrieb Kevin Ottens:
> On Sunday 29 December 2013 17:11:36 Friedrich W. H. Kossebau wrote:
> > So possibly something more that needs to be decided on: where should
> > plain headers end up?
>
> Consensus was: same place. The camel cased includes and the .h
On Sun, Dec 29, 2013 at 8:07 PM, Christoph Cullmann wrote:
> Hi,
>
> if I play around with Kate on KF5, it laggs like hell the whole time.
>
> I tried to profile, but guess I am stuck a bit.
>
> Interesting is that most times you see it lag and you interrupt it then, it
> hangs around in:
>
> #0
Hi,
if I play around with Kate on KF5, it laggs like hell the whole time.
I tried to profile, but guess I am stuck a bit.
Interesting is that most times you see it lag and you interrupt it then, it
hangs around in:
#0 0x73fc1a90 in operator< (k1=..., k2=...) at
/home/cullmann/local/k
On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote:
> > On Friday 27 December 2013 19:36:57 Aleix Pol wrote:
> > > Hi,
> > > Here's a patch adding CamelCase headers to KCoreAddons (attached).
> > >
> > > If we agree that it's the proper way of doing it, I'll proceed to do it
> > > on
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114727/
---
(Updated Dec. 29, 2013, 6:04 p.m.)
Review request for KDE Frameworks.
R
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114726/
---
(Updated Dec. 29, 2013, 6:04 p.m.)
Review request for KDE Frameworks.
R
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114727/
---
Review request for KDE Frameworks.
Repository: kcodecs
Description
On Sunday 29 December 2013 17:11:36 Friedrich W. H. Kossebau wrote:
> Am Samstag, 28. Dezember 2013, 12:32:43 schrieb Kevin Ottens:
> > On Saturday 28 December 2013 11:55:56 David Faure wrote:
> > > On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote:
> > > > So existing code ported
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114726/
---
Review request for KDE Frameworks.
Repository: kxmlgui
Description
Am Samstag, 28. Dezember 2013, 12:32:43 schrieb Kevin Ottens:
> On Saturday 28 December 2013 11:55:56 David Faure wrote:
> > On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote:
> > > So existing code ported from kdelibs would have to explicitely prefix
> > > the
> > > includes, e.g.
> On Friday 27 December 2013 19:36:57 Aleix Pol wrote:
> > Hi,
> > Here's a patch adding CamelCase headers to KCoreAddons (attached).
> >
> > If we agree that it's the proper way of doing it, I'll proceed to do it on
> > the rest of modules.
>
> Looks good to me. I like the fact that we can't for
On Sunday 29 of December 2013 14:44:59 David Faure wrote:
> On Thursday 19 December 2013 15:28:27 Dominik Haumann wrote:
> > On Thursday, December 19, 2013 15:12:01 Michal Humpula wrote:
> > > On Thursday 19 of December 2013 14:57:33 Dominik Haumann wrote:
> > > > On Wednesday, December 18, 2013 19
On Friday 20 December 2013 14:59:45 Michal Humpula wrote:
> Hi there,
>
> I was wondering if there is a recommended migration path from
> KDE4_ADD_APP_ICON cmake makro.
This stuff is indeed missing on
http://techbase.kde.org/Development/ECM_SourceIncompatChanges
Moving the discussion to kd
On Thursday 19 December 2013 15:28:27 Dominik Haumann wrote:
> On Thursday, December 19, 2013 15:12:01 Michal Humpula wrote:
> > On Thursday 19 of December 2013 14:57:33 Dominik Haumann wrote:
> > > On Wednesday, December 18, 2013 19:42:43 Michal Humpula wrote:
> > > > Git commit 4e6c1c3d8cd6dbe4d8
On Thursday 19 December 2013 18:10:11 Aurélien Gâteau wrote:
> Hi,
>
> Attached patch causes cmake to fail early if libsm is not installed, rather
> than waiting until we try to build code using it.
>
> This patch also removes buggy calls to set_package_properties(). I found
> out calling set_pac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/#review46369
---
This review has been submitted with commit
b2d3750b2f1e37a9a3
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/#review46371
---
This review has been submitted with commit
30f4934da203e0c6b2
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/
---
(Updated Dec. 29, 2013, 12:41 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/#review46373
---
This review has been submitted with commit
d8ef63c5cfe1a4d77c
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/#review46370
---
This review has been submitted with commit
52d1353c8f3ba73efe
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/#review46372
---
This review has been submitted with commit
cf2e0086eb86f21347
> On Dec. 29, 2013, 9:56 a.m., David Faure wrote:
> > Should have been part of 114703 :)
Oops, sorry, mental blip! Should have specified (and remembered) the
dependency...
- Alex
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114706/
---
(Updated Dec. 29, 2013, 12:34 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114706/#review46367
---
This review has been submitted with commit
d20a60e5c1e66656b5
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114705/
---
(Updated Dec. 29, 2013, 12:01 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114705/#review46366
---
This review has been submitted with commit
8bfddaca3205bcde63
> On Dec. 29, 2013, 10:55 a.m., David Faure wrote:
> > This actually broke the build for me.
> >
> >
> > # kdesrc-build running: 'gmake' '-j8'
> > # from directory: /d/kde/build/5/frameworks/kdesignerplugin
> > CMake Warning at
> > /d/kde/inst/kde_frameworks/lib64/cmake/KF5WebKit/KF5WebKitConf
On Friday 27 December 2013 19:36:57 Aleix Pol wrote:
> Hi,
> Here's a patch adding CamelCase headers to KCoreAddons (attached).
>
> If we agree that it's the proper way of doing it, I'll proceed to do it on
> the rest of modules.
Looks good to me. I like the fact that we can't forget to add forwa
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114706/#review46359
---
Ship it!
Should have been part of 114703 :)
- David Faure
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114703/#review46358
---
This actually broke the build for me.
# kdesrc-build running
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114705/#review46357
---
Ship it!
Hehe, this is from 2001, back when designer was gene
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/#review46354
---
Looks good to me, except for one thing.
src/kgendesignerplug
> On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote:
> > IMO the patch as it is is not good.
> >
> > Several things:
> > 1) This file, is not mandatory at all with KDE frameworks.
> > You can build applications using KDE frameworks libraries without it. You
> > (the developer of the applica
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/#review46352
---
The kde4 code (kcmdlineargs.cpp) was doing this:
39 matches
Mail list logo
