Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

2013-08-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/#review38575 --- staging/frameworkintegration/src/kstyle/CMakeLists.txt

Re: Review Request 112229: Port bunch of POSIX calls to qplatformdefs.h calls

2013-08-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112229/#review38574 --- Ship it! Looks OK. Assuming you ran the whole kdelibs test sui

Re: Review Request 112225: Port ::mmap to QT_MMAP

2013-08-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112225/#review38573 --- Ship it! Ship It! - Kevin Ottens On Aug. 23, 2013, 4:08 p.m

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112217/#review38572 --- KDE5PORTING.html

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-25 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112079/#review38570 --- staging/kguiaddons/src/util/kiconutils.h

Re: Review Request 112282: Move platformHints into their own class

2013-08-25 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112282/ --- (Updated Aug. 26, 2013, 12:58 a.m.) Review request for KDE Frameworks and

Review Request 112282: Move platformHints into their own class

2013-08-25 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112282/ --- Review request for KDE Frameworks and Kevin Ottens. Description --- W

Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- Review request for KDE Frameworks. Description --- Allow setting a cu

Re: Review Request 112277: Fix deadlock by avoid calling Qfont::QFont() in KFontSettingsData

2013-08-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112277/#review38568 --- Ship it! Makes sense to me, good catch! - Aleix Pol Gonzalez

Review Request 112279: Use qApp->setFont so we magically use QGuiApplication or QApplication

2013-08-25 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112279/ --- Review request for KDE Frameworks and Kevin Ottens. Description --- U

Re: Review Request 112277: Fix deadlock by avoid calling Qfont::QFont() in KFontSettingsData

2013-08-25 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112277/ --- (Updated Aug. 25, 2013, 8:38 p.m.) Review request for KDE Frameworks and K

Re: Fwd: Frameworks API Documentation

2013-08-25 Thread Kevin Ottens
On Saturday 24 August 2013 21:13:01 Sebastian Kügler wrote: > Hi Allen, > > On Saturday, August 24, 2013 15:14:34 Albert Astals Cid wrote: > > Assumpte: Frameworks API Documentation > > Data: Dissabte, 24 d'agost de 2013, 09:02:55 > > De: Allen Winter > > A: kde-core-de...@kde.org > > > > First

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
On 08/25/2013 12:39 PM, Kevin Krammer wrote: > On Sunday, 2013-08-25, Valentin Rusu wrote: >> On 08/24/2013 02:32 PM, Kevin Krammer wrote: >>> On Saturday, 2013-08-24, Albert Astals Cid wrote: El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va > escriure: > * AFAIK, framewo

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Kevin Krammer
On Sunday, 2013-08-25, Valentin Rusu wrote: > On 08/24/2013 02:32 PM, Kevin Krammer wrote: > > On Saturday, 2013-08-24, Albert Astals Cid wrote: > >> El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: > >>> * AFAIK, frameworks should be independent and self-contained. kwal

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
On 08/24/2013 01:43 PM, Albert Astals Cid wrote: > El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: >> >> * Another piece of software related to kwallet is KWalletManager from >> kdeutils. I think that component should also be detached from kdeutils >> and attached under

Re: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
On 08/24/2013 02:32 PM, Kevin Krammer wrote: > On Saturday, 2013-08-24, Albert Astals Cid wrote: >> El Dissabte, 24 d'agost de 2013, a les 12:31:20, Valentin Rusu va escriure: >>> >>> * AFAIK, frameworks should be independent and self-contained. kwallet >>> depends on kde-runtime/kwalletd. This com

Fwd: KF5 kwallet, kwalletd and wallet manager questions

2013-08-25 Thread Valentin Rusu
NOTE: forwarding this here after initially sending it only to kde-core-devel. Hello, Now that frameworks splitting is almost done ;-) with some people even running KF5-based sessions on their systems, I'd like to plan kwallet porting and integration. BTW, I'd like also to announce that I agreed wi