Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/#review38396 --- This review has been submitted with commit 182fbab9402ddd0

Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/ --- (Updated Aug. 23, 2013, 5:33 a.m.) Status -- This change has been mar

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-22 Thread Martin Graesslin
On Wednesday 21 August 2013 08:40:43 Kevin Ottens wrote: > Hello, > > On Tuesday 20 August 2013 23:23:30 Alexander Neundorf wrote: > > On Tuesday 20 August 2013, Stephen Kelly wrote: > > > Alexander Neundorf wrote: > > > > please wait with updating the required version until 2.8.12 final is > > >

Jenkins build became unstable: kdelibs_stable #776

2013-08-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112217/#review38393 --- You can use "git diff -M80%" instead of --find-copies-harder, t

Re: Smart D-Ptr in KCoreAddons

2013-08-22 Thread Mark
On Thu, Aug 22, 2013 at 6:49 PM, Ivan Čukić wrote: > Hi all, > > We had some discussions on plasma-devel regarding the use of a smart non- > inherited D-Pointer[1] and Kevin proposed moving the pointer into KCoreAddons. > The only listed downside of including it into plasma is that it is too low >

Re: Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-22 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112217/ --- (Updated Aug. 22, 2013, 11:34 p.m.) Review request for KDE Frameworks. D

Review Request 112217: copy KStyle as K4Style in KDE4Support

2013-08-22 Thread Wojciech Kapuscinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112217/ --- Review request for KDE Frameworks. Description --- kdelibs_cleanup ta

Re: I'm out

2013-08-22 Thread Alexander Neundorf
On Thursday 22 August 2013, Kevin Ottens wrote: > Hello, > > On Thursday 22 August 2013 09:14:16 Stephen Kelly wrote: > > Mark wrote: > > > On Wed, Aug 21, 2013 at 10:20 PM, Alexander Neundorf > > > > > > wrote: > > >> until recently I thought I was still the maintainer of the buildsystem > > >>

CMake source incompatible changes

2013-08-22 Thread Alexander Neundorf
Hi, here: http://techbase.kde.org/Development/ECM_SourceIncompatChanges I tried to document all cmake source-incompatible changes in our buildsystem between KDE4 and KF5 (except FindKDE4Internal.cmake itself, since this is not done yet). Please try to keep that up-to-date and complete. I think i

Re: I'm out

2013-08-22 Thread Alexander Neundorf
On Wednesday 21 August 2013, Mark wrote: ... > Hi Alexander, > > I'm sorry to hear that! I hope you keep sticking around in KDE :) > As for the issues, why don't you and Stephen just find yourself a > quiet place on IRC and talk about it? Good news for Dominik: as I wrote, this is a break from KD

Smart D-Ptr in KCoreAddons

2013-08-22 Thread Ivan Čukić
Hi all, We had some discussions on plasma-devel regarding the use of a smart non- inherited D-Pointer[1] and Kevin proposed moving the pointer into KCoreAddons. The only listed downside of including it into plasma is that it is too low level and generic to belong to that framework (Sebas). Cons:

Qt Dev Days 2013

2013-08-22 Thread John Layt
Hi, Qt Dev Days Europe is coming up on October 7-9 and once again this year KDE e.V. is partnering with Digia, KDAB and ICS in the running of the event. In particular KDE is once again helping organise a Qt Contributors Day on Monday October 7th. We have been allocated a room for the day to hold

Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread Martin Gräßlin
> On Aug. 22, 2013, 2:28 p.m., David Faure wrote: > > tier1/kwindowsystem/src/kmanagerselection.cpp, line 656 > > > > > > that's still a weird if() then, if it does nothing in the body. > > Why not just call o

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

2013-08-22 Thread David Faure
On Thursday 08 August 2013 13:17:18 Frank Reininghaus wrote: > Hi David, > > 2013/8/7 David Faure: > > On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: > >> OK, I see now that it uses pointers to be able to modify the actual > >> KFileItems in KDirListerCache (if it would just keep KFil

Jenkins build became unstable: kdelibs_frameworks_qt5 #1065

2013-08-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112175: Implement Ctrl+Enter dialog acceptation in KStyle::polish()

2013-08-22 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112175/#review38359 --- Perhaps you should move this to staging/frameworkintegration/te

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1063

2013-08-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2013-w31

2013-08-22 Thread Sune Vuorela
On 2013-08-22, Kevin Ottens wrote: >> There's cmake --warn-uninitialized: "Print a warning when an >> uninitialized variable is used." > > Now that's interesting... Any way to control that from the CMakeLists.t= > xt or=20 > to turn that into an error? (just wondering how far that can be pushed)=

Re: Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/#review38333 --- Ship it! Many thanks for taking care of this. tier1/kwindows

Re: KF5 Update Meeting Minutes 2013-w31

2013-08-22 Thread Kevin Ottens
On Wednesday 21 August 2013 17:27:12 Nicolás Alvarez wrote: > 2013/8/21 Kevin Ottens : > > And that's exactly the point, in the case of dependencies management at > > build time I don't like how cmake handles variables at all[*] (and I > > don't think I'm alone in that, most of the people touching

Re: I'm out

2013-08-22 Thread Kevin Ottens
Hello, On Thursday 22 August 2013 09:14:16 Stephen Kelly wrote: > Mark wrote: > > On Wed, Aug 21, 2013 at 10:20 PM, Alexander Neundorf > > wrote: > >> until recently I thought I was still the maintainer of the buildsystem > >> for KDE4 and also KF5, but I think the consensus on this list here is

Re: I'm out

2013-08-22 Thread Stephen Kelly
Mark wrote: > On Wed, Aug 21, 2013 at 10:20 PM, Alexander Neundorf > wrote: >> Hi, >> >> until recently I thought I was still the maintainer of the buildsystem >> for KDE4 and also KF5, but I think the consensus on this list here is >> that Stephen has taken over this role. >> So I'll let him do