Jenkins build became unstable: kdelibs_frameworks_qt5 #1062

2013-08-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2013-w31

2013-08-21 Thread Nicolás Alvarez
2013/8/21 Kevin Ottens : > And that's exactly the point, in the case of dependencies management at build > time I don't like how cmake handles variables at all[*] (and I don't think I'm > alone in that, most of the people touching our cmake files have problems with > it at some point... except you

Re: I'm out

2013-08-21 Thread Mark
On Wed, Aug 21, 2013 at 10:20 PM, Alexander Neundorf wrote: > Hi, > > until recently I thought I was still the maintainer of the buildsystem for > KDE4 and also KF5, but I think the consensus on this list here is that Stephen > has taken over this role. > So I'll let him do that, and stay out of t

I'm out

2013-08-21 Thread Alexander Neundorf
Hi, until recently I thought I was still the maintainer of the buildsystem for KDE4 and also KF5, but I think the consensus on this list here is that Stephen has taken over this role. So I'll let him do that, and stay out of the way. I'll still have a look at KDE4 stuff, but for KF5 (including

Re: Problem merging Qt branch

2013-08-21 Thread David Edmundson
Thanks to awesome help from David F and Kevin this all got resolved. Thanks guys. David ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1060

2013-08-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2013-w31

2013-08-21 Thread Alexander Neundorf
On Wednesday 21 August 2013, Kevin Ottens wrote: > On Tuesday 20 August 2013 22:31:28 Alexander Neundorf wrote: > > On Wednesday 31 July 2013, Kevin Ottens wrote: > > > Hello, > > > > > > On Wednesday 31 July 2013 12:37:52 Stephen Kelly wrote: > > > > Kevin Ottens wrote: > > > > > Once the splitti

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Alexander Neundorf
On Wednesday 21 August 2013, Kevin Ottens wrote: > Hello, > > On Tuesday 20 August 2013 23:23:30 Alexander Neundorf wrote: > > On Tuesday 20 August 2013, Stephen Kelly wrote: > > > Alexander Neundorf wrote: > > > > please wait with updating the required version until 2.8.12 final is > > > > out. >

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Alexander Neundorf
On Wednesday 21 August 2013, Kevin Ottens wrote: > Hello, > > On Wednesday 21 August 2013 11:00:56 Giorgos Tsiapaliokas wrote: > > On 20 August 2013 23:47, Alexander Neundorf wrote: > > > > On 21 August 2013 09:40, Kevin Ottens wrote: > > > The crux of the issue is: > > > Is there anyone buildi

Re: Review Request 112079: Add utility function to paint icon overlays

2013-08-21 Thread Martin Klapetek
> On Aug. 19, 2013, 9:52 a.m., Kevin Ottens wrote: > > staging/kguiaddons/src/util/qiconoverlay.h, line 29 > > > > > > Apidox is missing for those two functions. The dox is in the .cpp file, I got used to that fro

Re: Review Request 112174: Make KSharedConfig::Ptr use QExplicitlySharedDataPointer

2013-08-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112174/ --- (Updated Aug. 21, 2013, 2:35 p.m.) Status -- This change has been mar

Re: Review Request 112174: Make KSharedConfig::Ptr use QExplicitlySharedDataPointer

2013-08-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112174/#review38280 --- This review has been submitted with commit 84ffcc8b2434a14db40

Re: Review Request 112174: Make KSharedConfig::Ptr use QExplicitlySharedDataPointer

2013-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112174/#review38275 --- Ship it! (after discussing on IRC that all unittests pass as b

Review Request 112185: Fix KManagerSelection and re-enable unit test

2013-08-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112185/ --- Review request for KDE Frameworks and David Faure. Description --- Re

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Sebastian Kügler
On Wednesday, August 21, 2013 08:40:43 Kevin Ottens wrote: > Is there anyone building kdelibs-frameworks and/or plasma-framework without > using the kdesrc-build based procedure described on the wiki? > http://community.kde.org/Frameworks/Building I am, on two systems. (Just as data point, I want

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Stephen Kelly
Rohan Garg wrote: >> What will be different when the 2.8.12 final is released? It will be >> needed for frameworks, and your cmake 2.8.12 package will still overwrite >> the distro version, correct? >> > > Correct, the difference would be that instead of releasing a unstable > cmake which might

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Rohan Garg
> What will be different when the 2.8.12 final is released? It will be needed > for frameworks, and your cmake 2.8.12 package will still overwrite the > distro version, correct? > Correct, the difference would be that instead of releasing a unstable cmake which might have bugs, we will be releas

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Kevin Ottens
On Wednesday 21 August 2013 12:27:06 Stephen Kelly wrote: > Rohan Garg wrote: > > While KDE Frameworks is sandboxed > > separately from a stable KDE install, cmake is not sandboxed and > > overwrites the cmake package from the official distro repository., which > > is why I'm uneasy with thought of

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Stephen Kelly
Rohan Garg wrote: > While KDE Frameworks is sandboxed > separately from a stable KDE install, cmake is not sandboxed and > overwrites the cmake package from the official distro repository., which > is why I'm uneasy with thought of having a RC release of cmake in the PPA. What will be different

Re: oxygen vs kstyle

2013-08-21 Thread Kevin Ottens
Hello, On Wednesday 21 August 2013 10:41:06 Hugo Pereira Da Costa wrote: > On 08/20/2013 10:31 PM, Kevin Ottens wrote: > > My understanding of the current situation is that: > > a) the current KStyle is overengineered and does way too much; > > yes. > > > b) we need a KStyle to enforce some

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Kevin Ottens
On Wednesday 21 August 2013 13:57:22 Rohan Garg wrote: > > > so I disagree on raising the cmake requirement, at least before the > > > final > > > release is out. > > > > Which cmake release do you use in Project Neon 5? Is it part of your > > packaging effort or you assume whatever comes from the

Re: oxygen vs kstyle

2013-08-21 Thread Hugo Pereira Da Costa
On 08/20/2013 10:31 PM, Kevin Ottens wrote: Hello, On Tuesday 20 August 2013 21:27:52 Hugo Pereira Da Costa wrote: There is some traffic on the frameworks list concerning implementing new features in kstyle. It might be useful to mention that the current oxygen code (KDE's default widget style)

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Rohan Garg
> > so I disagree on raising the cmake requirement, at least before the final > > release is out. > > Which cmake release do you use in Project Neon 5? Is it part of your > packaging effort or you assume whatever comes from the distro? > We currently build for 2 releases last stable (Raring) an

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Kevin Ottens
Hello, On Wednesday 21 August 2013 13:37:29 Rohan Garg wrote: > > The crux of the issue is: > > Is there anyone building kdelibs-frameworks and/or plasma-framework > > without > > using the kdesrc-build based procedure described on the wiki? > > http://community.kde.org/Frameworks/Building > > I

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Kevin Ottens
Hello, On Wednesday 21 August 2013 11:00:56 Giorgos Tsiapaliokas wrote: > On 20 August 2013 23:47, Alexander Neundorf wrote: > On 21 August 2013 09:40, Kevin Ottens wrote: > > The crux of the issue is: > > Is there anyone building kdelibs-frameworks and/or plasma-framework > > without > > using

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Rohan Garg
> The crux of the issue is: > Is there anyone building kdelibs-frameworks and/or plasma-framework without > using the kdesrc-build based procedure described on the wiki? > http://community.kde.org/Frameworks/Building > I don't use kdesrc-build. I primarily rely on packages from Project Neon 5 and

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-21 Thread Giorgos Tsiapaliokas
Hello On 20 August 2013 23:47, Alexander Neundorf wrote: > Hi, > > I actually don't have to say that, since it should be obvious to everybody > here, I also object to requiring non-final versions of cmake, it just makes > life harder for everybody trying to contribute. > +1 On 21 August 2013