Re: Ki18n mostly ready

2013-08-01 Thread Kevin Ottens
On Thursday 01 August 2013 22:03:36 Albert Astals Cid wrote: > El Dijous, 1 d'agost de 2013, a les 12:54:07, Kevin Ottens va escriure: > > Hello, > > > > On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: > > > > [: Kevin Ottens :] > > > > What's needed for kconfig_compiler? Because curre

Re: Revising changing configurations with KConfig

2013-08-01 Thread Kevin Ottens
On Thursday 01 August 2013 22:02:15 Albert Astals Cid wrote: > El Dijous, 1 d'agost de 2013, a les 08:28:13, Kevin Ottens va escriure: > > Hello, > > > > On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: > > > Well, KDirSortFilterProxyModel is being used indirectly by every > > > applic

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36947 --- Ship it! awesome, I like it now :) - Milian Wolff On Aug. 1

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
> On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: > > staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 > > > > > > just do return convert(...); > > Nicolás Alvarez wrote: > No, that would give t

Re: Ki18n mostly ready

2013-08-01 Thread Albert Astals Cid
El Dijous, 1 d'agost de 2013, a les 12:54:07, Kevin Ottens va escriure: > Hello, > > On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: > > > [: Kevin Ottens :] > > > What's needed for kconfig_compiler? Because currently kconfig isn't > > > supposed to depend on ki18n at all. > > > > It

Re: Revising changing configurations with KConfig

2013-08-01 Thread Albert Astals Cid
El Dijous, 1 d'agost de 2013, a les 08:28:13, Kevin Ottens va escriure: > Hello, > > On Thursday 01 August 2013 08:09:14 Frank Reininghaus wrote: > > Well, KDirSortFilterProxyModel is being used indirectly by every > > application which has a "File Open/Save" dialog, and by apps like Kate > > whic

Problem compiling

2013-08-01 Thread David Gil Oliva
Hi, I'm having problems compiling KF5. The configuration gives me this: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version "5.0.0", minimum required is "5.0.0") found components: CMake Compiler InstallDirs CMake Error at /home/david/devel

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:59 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:56 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Nicolás Alvarez
> On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: > > staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 > > > > > > just do return convert(...); No, that would give the opposite return value. To have

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36933 --- nearly there! :) staging/kservice/tools/desktoptojson/kconfig

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Kevin Krammer
> On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote: > > staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57 > > > > > > Do we want the output/errors to be translated? > > Sebastian Kügler wrote: > I

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 6:03 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 111841: Prefer job->exec() to synchronousRun

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 1, 2013, 5:52 p.m.) Review request for KDE Frameworks. Des

Review Request 111841: Prefer job->exec() to synchronousRun

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- Review request for KDE Frameworks. Description --- Ports all uses of

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 5:49 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 5:44 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
> On Aug. 1, 2013, 4:48 p.m., Kevin Krammer wrote: > > staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 57 > > > > > > Do we want the output/errors to be translated? It's really a helper tool for the b

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36923 --- staging/kservice/tools/desktoptojson/kconfigtojson.h

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/ --- (Updated Aug. 1, 2013, 4:32 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Sebastian Kügler
> On Aug. 1, 2013, 12:07 p.m., Milian Wolff wrote: > > Some more nitpicks from my side - sorry Sebas I hope you don't think I'm > > too pedantic :) But I hope others read this as well and start following the > > new best-practices for Qt5 codebases. No problem at all, in fact I much appreciate

Review Request 111834: Move KHelpClient into xmlgui

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111834/ --- Review request for KDE Frameworks. Description --- The class still wa

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36906 --- Some more nitpicks from my side - sorry Sebas I hope you don't

Re: Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111833/ --- (Updated Aug. 1, 2013, 11:03 a.m.) Review request for KDE Frameworks. Ch

Re: Ki18n mostly ready

2013-08-01 Thread Kevin Ottens
Hello, On Thursday 01 August 2013 11:58:44 Chusslove Illich wrote: > > [: Kevin Ottens :] > > What's needed for kconfig_compiler? Because currently kconfig isn't > > supposed to depend on ki18n at all. > > It does generate translation calls as necessary, and currently it accepts an > option (from

Review Request 111833: Remove small dependency between KGlobalSettings::naturalCompare and KDirSortFilterProxyModel

2013-08-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111833/ --- Review request for KDE Frameworks. Summary (updated) - Re

Jenkins build is back to stable : plasma-framework_master_qt5 #534

2013-08-01 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #532

2013-08-01 Thread KDE CI System
See Changes: [sebas] Fix fallout from qDebug -> kDebug porting -- [...truncated 804 lines...] Building CXX object src/declarativeimports/locale/CMakeFiles/localebindingsplugin.dir/calendar

Re: Ki18n mostly ready

2013-08-01 Thread Chusslove Illich
> [: Kevin Ottens :] > What's needed for kconfig_compiler? Because currently kconfig isn't > supposed to depend on ki18n at all. It does generate translation calls as necessary, and currently it accepts an option (from .kcfgc file) whether to generate tr or i18n calls. So another option to specify

Build failed in Jenkins: plasma-framework_master_qt5 #531

2013-08-01 Thread KDE CI System
See Changes: [sebas] Fix qDebug/kDebug port -- [...truncated 522 lines...] /srv/jenkins/install/linux/x64_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:984:36: warning: ‘KUrl’ is deprec