Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 30, 2013, 2:41 a.m.) Review request for KDE Frameworks and D

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
> On July 25, 2013, 4:33 p.m., David Faure wrote: > > staging/kservice/src/plugin/kpluginloader.cpp, line 235 > > > > > > This relates to my comment in the other review. If what we have is a > > list with always

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/ --- (Updated July 30, 2013, 2:33 a.m.) Review request for KDE Frameworks and D

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111688/ --- (Updated July 30, 2013, 2:31 a.m.) Review request for KDE Frameworks and D

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
> On July 25, 2013, 4:33 p.m., David Faure wrote: > > staging/kservice/src/plugin/kpluginloader.cpp, line 235 > > > > > > This relates to my comment in the other review. If what we have is a > > list with always

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
> On July 25, 2013, 4:33 p.m., David Faure wrote: > > staging/kservice/src/plugin/kpluginloader.cpp, line 235 > > > > > > This relates to my comment in the other review. If what we have is a > > list with always

Review Request 111789: Improve KFileItemList memory usage and performance

2013-07-29 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111789/ --- Review request for KDE Frameworks and David Faure. Description --- Th

Re: Review Request 111701: Port away from kde_file in KDirOperator (KFile)

2013-07-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111701/#review36778 --- Ship it! Ship It! - David Faure On July 29, 2013, 9:22 p.m.

Re: Review Request 111701: Port away from kde_file in KDirOperator (KFile)

2013-07-29 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111701/ --- (Updated July 29, 2013, 9:22 p.m.) Review request for KDE Frameworks. Ch

Build failed in Jenkins: kdelibs_frameworks_qt5 #948

2013-07-29 Thread KDE CI System
See Changes: [scarpino] WHAT ALL doesn't include packages searched using the QUIET keyword -- [...truncated 15584 lines...] from

Build failed in Jenkins: kdelibs_frameworks_qt5 #947

2013-07-29 Thread KDE CI System
See Changes: [scarpino] Move K4AboutData and KComponentData to kde4support -- [...truncated 11192 lines...] [ 64%] Building CXX object staging/kunitconversion/src/kunitconversion/CMakeFiles/KUn

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/ --- (Updated July 29, 2013, 7:15 p.m.) Status -- This change has been mar

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/#review36773 --- This review has been submitted with commit 21dfceedf2bf4a3fbc5

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/#review36767 --- Ship it! KHTML could be ported away of course, but this can be

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-29 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/ --- (Updated July 29, 2013, 6:07 p.m.) Review request for KDE Frameworks. De

Build failed in Jenkins: kdelibs_frameworks_qt5 #945

2013-07-29 Thread KDE CI System
See Changes: [faure+bluesystems] Move KToolInvocation to the kservice framework -- [...truncated 9254 lines...] from

Jenkins build became unstable: kdelibs_frameworks_qt5 #944

2013-07-29 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111702: Move K4AboutData and KComponentData to kde4support

2013-07-29 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111702/ --- (Updated July 29, 2013, 4:20 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/ --- (Updated July 29, 2013, 2:05 p.m.) Status -- This change has been mar

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111409/#review36746 --- This review has been submitted with commit aa16577f402549c7372

Jenkins build is back to normal : kdelibs_frameworks_qt5 #942

2013-07-29 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #941

2013-07-29 Thread KDE CI System
See Changes: [faure+bluesystems] Use the new QUrl::fileName() method. [faure+bluesystems] Port kcoreaddons away from QUrlPathInfo - and from libkdeqt5staging, therefore. [faure+bluesystems] remove unneeded deps [faure+bluesystems]

Re: symbol lookup error in each application linking KDE4Support

2013-07-29 Thread Martin Graesslin
On Monday 29 July 2013 11:13:32 David Faure wrote: > 2) check your LD_LIBRARY_PATH (empty is ok), and check thanks, that was the trick. LD_LIBRARY_PATH had of course my normal kde (4) setup included. After unsetting the variable kdeinit5 works and now I'm scared as I don't have an excuse anymore

Re: symbol lookup error in each application linking KDE4Support

2013-07-29 Thread Martin Graesslin
On Saturday 27 July 2013 12:47:53 you wrote: > On Wednesday 24 July 2013 12:01:07 Martin Graesslin wrote: > > Hi, > > > > when I try to run binaries which links KDE4Support (e.g. kdeinit5) I get > > the following symbol lookup error: > > > > [...]lib/x86_64-linux-gnu/libKDE4Support.so.5: undefine

Re: symbol lookup error in each application linking KDE4Support

2013-07-29 Thread David Faure
On Monday 29 July 2013 11:04:20 Martin Graesslin wrote: > so I think the root problem is that KDE4 is > picked instead of KF5. Yes. 1) we'll kill libkdecore.so before the end of the year, but meanwhile feel free to raise its version number in order to avoid this clash 2) check your LD_LIBRARY

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-29 Thread David Faure
> On July 25, 2013, 4:32 p.m., David Faure wrote: > > staging/kservice/src/services/kplugininfo.cpp, line 110 > > > > > > So "args" is a list of maps, any of which could contain a MetaData key? > > This seems str

Re: symbol lookup error in each application linking KDE4Support

2013-07-29 Thread Giorgos Tsiapaliokas
Hello, same error here from fresh install(no build dirs, clean install dir). $ nm -D /opt/kf5/lib64/libkdecore.so | grep kde_kiosk_admin 0023ac80 B kde_kiosk_admin $ objdump -t /opt/kf5/lib64/libkdecore.so | grep kde_kiosk_admin 0023ac80 g O .bss 0001 kde_kios

Jenkins build is back to stable : kdelibs_frameworks_qt5 #940

2013-07-29 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 109480: Add support for xcb_generic_event_t to KKeyServer::xEventToQt

2013-07-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109480/ --- (Updated July 29, 2013, 6:55 a.m.) Status -- This change has been mar