Re: Review Request 111605: move kfreediskspace to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111605/ --- (Updated July 20, 2013, 3:10 a.m.) Review request for KDE Frameworks. Ch

Re: Header cleanup / Link interface (was kdewidgets: fix build)

On Friday 19 July 2013, Stephen Kelly wrote: > Stephen Kelly wrote: > > Qt5::Core is a public dependency of Qt5::Widgets (as is Qt5::Gui), so > > there's no need to try to be exhaustive with dependencies which cmake > > will add anyway. You only need to add 'leaf modules'. > > To be more clear. I'

Re: KStandardDirs and locale path

El Divendres, 19 de juliol de 2013, a les 16:27:39, Chusslove Illich va escriure: > > [: David Faure :] > > I.e. the question is whether the search path should apply to all catalogs > > in the current process (loaded after the call), or should apply to an > > individual catalog. In your example co

Re: Header cleanup / Link interface (was kdewidgets: fix build)

Stephen Kelly wrote: > Qt5::Core is a public dependency of Qt5::Widgets (as is Qt5::Gui), so > there's no need to try to be exhaustive with dependencies which cmake will > add anyway. You only need to add 'leaf modules'. To be more clear. I'm saying only what CMake requires. Public dependencies

Re: Header cleanup / Link interface (was kdewidgets: fix build)

David Faure wrote: >> 3. We have situation >> >> a) framework A (public header use QObject and QWidget) >> -> LINK_PUBLIC only to Qt5::Widgets? or both Qt5::Core and Qt5::Widgets? > > I don't know if deps become part of it. I guess not, but I'm no expert. > Stephen? Alex? I say target_link_lib

Re: Review Request 111609: Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111609/ --- (Updated July 19, 2013, 7:57 p.m.) Status -- This change has been mar

Re: Header cleanup / Link interface (was kdewidgets: fix build)

On Friday 19 July 2013, David Faure wrote: > On Friday 19 July 2013 17:40:26 wojtask w wrote: ... > > 3. We have situation > > > > a) framework A (public header use QObject and QWidget) > > -> LINK_PUBLIC only to Qt5::Widgets? or both Qt5::Core and Qt5::Widgets? > > I don't know if deps become pa

Jenkins build is back to stable : kdelibs_frameworks_qt5 #884

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Porting the mode_t uses

On Friday 19 July 2013 19:56:46 Aleix Pol wrote: > Hi, > We've been looking into the tasks to be done in the kdelibs cleanup and > I've been looking into the mode_t port. It's obviously not a trivial task, > since we don't have any adequate replacement for all the required values > [1]. > > I gues

Re: Review Request 111605: move kfreediskspace to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111605/#review36180 --- kio/CMakeLists.txt

Re: Review Request 111609: Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111609/#review36184 --- This review has been submitted with commit c39a5b1dcd91cdae7fc

Re: Review Request 111609: Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111609/#review36171 --- Ship it! Ship It! - David Faure On July 19, 2013, 6:46 p.m.

Review Request 111609: Replace signals: with Q_SIGNALS: and slots with Q_SLOTS: everywhere in kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111609/ --- Review request for KDE Frameworks. Description --- Replace signals: w

Re: Review Request 111539: Move kundoactions and kcheckaccelerators to xmlgui

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111539/ --- (Updated July 19, 2013, 9:06 p.m.) Review request for KDE Frameworks and K

Porting the mode_t uses

Hi, We've been looking into the tasks to be done in the kdelibs cleanup and I've been looking into the mode_t port. It's obviously not a trivial task, since we don't have any adequate replacement for all the required values [1]. I guess the best move would be to extend QFile::Permissions to fit ou

Header cleanup / Link interface (was kdewidgets: fix build)

On Friday 19 July 2013 17:40:26 wojtask w wrote: > there is a difference between "kf5/kdewidgets" and "kf5/stagging/kwidgets" Oh, oops. > But on the other hand I don't understand what "kdewidgets" is (my fix may > be wrong). It's the Qt designer plugin which makes all the kde widgets available i

Review Request 111605: move kfreediskspace to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111605/ --- Review request for KDE Frameworks. Description --- move kfreediskspac

Re: naturalCompare Qt5 task

On sexta-feira, 19 de julho de 2013 16.17.52, Frank Reininghaus wrote: > But I thought that natural locale-based comparison is just what > QCollator does if its "numericMode" is enabled? > > http://qt.gitorious.org/qt/qtbase/blobs/v5.1.0/src/corelib/tools/qcollator.c > pp#line401 Maybe. Check if

Re: naturalCompare Qt5 task

On sexta-feira, 19 de julho de 2013, às 13.17.26, you wrote: > Hi, > I was looking at that task in the Qt5 epics list and I didn't understand it > fully. > > contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is > naturalCompare function but private and not as good as from KStri

Re: KStandardDirs and locale path

> [: David Faure :] > I.e. the question is whether the search path should apply to all catalogs > in the current process (loaded after the call), or should apply to an > individual catalog. In your example code above, I presume the latter would > be better. If the search path would apply to all ca

Re: naturalCompare Qt5 task

Hi, 2013/7/19 Thiago Macieira: > On sexta-feira, 19 de julho de 2013, às 13.17.26, you wrote: >> Hi, >> I was looking at that task in the Qt5 epics list and I didn't understand it >> fully. >> >> contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is >> naturalCompare function b

Re: naturalCompare Qt5 task

On Fri, Jul 19, 2013 at 2:51 PM, Aleix Pol wrote: > On Fri, Jul 19, 2013 at 2:47 PM, John Layt wrote: >> >> On 19 July 2013 14:15, Aleix Pol wrote: >> > On Fri, Jul 19, 2013 at 1:17 PM, Aleix Pol wrote: >> >> >> >> Hi, >> >> I was looking at that task in the Qt5 epics list and I didn't >> >> un

Jenkins build became unstable: kdelibs_frameworks_qt5 #883

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111408: Move KConfigDialogManager to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111408/#review36160 --- This review has been submitted with commit 23770d374b1f578dfbf

Re: Review Request 111408: Move KConfigDialogManager to KConfigWidgets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111408/ --- (Updated July 19, 2013, 1:24 p.m.) Status -- This change has been mar

Re: naturalCompare Qt5 task

On Fri, Jul 19, 2013 at 2:47 PM, John Layt wrote: > On 19 July 2013 14:15, Aleix Pol wrote: > > On Fri, Jul 19, 2013 at 1:17 PM, Aleix Pol wrote: > >> > >> Hi, > >> I was looking at that task in the Qt5 epics list and I didn't understand > >> it fully. > >> > >> contribute natural-comparison to

Re: naturalCompare Qt5 task

On 19 July 2013 14:15, Aleix Pol wrote: > On Fri, Jul 19, 2013 at 1:17 PM, Aleix Pol wrote: >> >> Hi, >> I was looking at that task in the Qt5 epics list and I didn't understand >> it fully. >> >> contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is >> naturalCompare function

Jenkins build is back to stable : kdelibs_frameworks_qt5 #882

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_frameworks_qt5 #881

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 111409: Deprecate KGlobalSettings::*Font methods in favor of QFontsDatabase::systemFont

> On July 10, 2013, 9 a.m., Kevin Ottens wrote: > > Only style nitpicks I didn't spot the last time. Since it can't get in yet > > anyway we've time. ;-) It can go in now, no? can I get a ship it? :D - Aleix --- This is an automaticall

Re: naturalCompare Qt5 task

On Fri, Jul 19, 2013 at 1:17 PM, Aleix Pol wrote: > Hi, > I was looking at that task in the Qt5 epics list and I didn't understand > it fully. > > contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is > naturalCompare function but private and not as good as from KStringHandler

Review Request 111599: Move KGesture and KGestureMap to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111599/ --- Review request for KDE Frameworks. Description --- Move KGesture and

Review Request 111599: Move KGesture and KGestureMap to KDE4Attic

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111599/ --- Review request for KDE Frameworks. Description --- Move KGesture and

Re: naturalCompare Qt5 task

On Fri, Jul 19, 2013 at 1:27 PM, Frank Reininghaus wrote: > Hi, > > 2013/7/19 Aleix Pol: > > Hi, > > I was looking at that task in the Qt5 epics list and I didn't understand > it > > fully. > > > > contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is > > naturalCompare functi

Re: naturalCompare Qt5 task

Hi, 2013/7/19 Aleix Pol: > Hi, > I was looking at that task in the Qt5 epics list and I didn't understand it > fully. > > contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is > naturalCompare function but private and not as good as from KStringHandler. > Thiago says: add the f

naturalCompare Qt5 task

Hi, I was looking at that task in the Qt5 epics list and I didn't understand it fully. contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is naturalCompare function but private and not as good as from KStringHandler. Thiago says: add the feature to QCollator. Here's the proble