Re: Patch: Move kprotocolmanager to kiocore.

2013-02-11 Thread Jignesh Kakadiya
Hi David, Here is the first patch which removes QGuiAppliction from kprotocolmanager. Please review it. Thanks, Jignesh On Mon, Feb 11, 2013 at 10:45 PM, David Faure wrote: > On Monday 11 February 2013 21:59:44 Jignesh Kakadiya wrote: > > Hi David, > > > > It moves kprotocolmanager from kio/k

Re: Review Request 107791: move Sonnet out of KDEUI, port away from KDE classes.

2013-02-11 Thread Martin Tobias Holmedahl Sandsmark
On Mon, Feb 11, 2013 at 12:57:46PM -, Aleix Pol Gonzalez wrote: > Why are there so many removed files? Shouldn't they be renamed? > Maybe you forgot some git mv? No, I used git mv, and the new files show up, it's just reviewboard that doesn't show the moves properly. -- Martin Sandsmark

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Stephen Kelly
Stephen Kelly wrote: > Thiago Macieira wrote: >> A quick check shows that the cmake generated files are completely wrong >> already for when someone plays with the dir options. They don't take >> --bindir into account, for example. > > Did you check this, or are you guessing? > Depending on whi

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread David Faure
On Monday 11 February 2013 18:02:39 Sebastian Kügler wrote: > Do we have any canonical place where I set a sensible the QML2_IMPORT_PATH > env var, so we don't have to tell everybody to add this to their setup? The current solution is to document it in http://community.kde.org/Frameworks/Buildin

Re: Patch: Move kprotocolmanager to kiocore.

2013-02-11 Thread David Faure
On Monday 11 February 2013 21:59:44 Jignesh Kakadiya wrote: > Hi David, > > It moves kprotocolmanager from kio/kio to kiocore. Builds successfully. > Please review it. You should make two commits: one which moves the code, and one which makes changes to the code (like the QGuiApplication depende

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Monday, February 11, 2013 17:43:01 Stephen Kelly wrote: > Sebastian Kügler wrote: > >> What do you need it for, exactly? > > > > To find out where Qt will look for QtQuick2 imports (that's > > $ARCHDATADIR/qml, defaulting to $PREFIX/qml, which leads to /usr/qml). > > > > I'd like to be able to

Jenkins build became unstable: kdelibs_frameworks_qt5 #394

2013-02-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Monday, February 11, 2013 17:03:55 Stephen Kelly wrote: > Sebastian Kügler wrote: > > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > >> On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > >> > Apparently not. I've looked at where the example imports from the Q

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Stephen Kelly
Thiago Macieira wrote: > A quick check shows that the cmake generated files are completely wrong > already for when someone plays with the dir options. They don't take > --bindir into account, for example. Did you check this, or are you guessing? Thanks, Steve.

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Thiago Macieira
On segunda-feira, 11 de fevereiro de 2013 12.21.48, Sebastian Kügler wrote: > On Monday, February 11, 2013 10:49:08 Sebastian Kügler wrote: > > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > > > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > > > Apparently

kcolorscheme needs ksharedconfig.h

2013-02-11 Thread Treeve Jelbert
In file included from /var/git/kf5/staging/kguiaddons/src/colors/kcolorscheme.cpp:19:0: /var/git/kf5/staging/kguiaddons/src/colors/kcolorscheme.h:24:27: fatal error: ksharedconfig.h: No such file or directory compilation terminated. ___ Kde-frameworks

more phonon problems

2013-02-11 Thread Treeve Jelbert
[976/2118] Building CXX object interfaces/kmediaplayer/kfileaudiopreview/CMakeFiles/kfileaudio preview.dir/kfileaudiopreview.cpp.o In file included from /var/git/kf5/interfaces/kmediaplayer/kfileaudiopreview/kfileaudiopreview.cpp:20:0: /var/git/kf5/interfaces/kmediaplayer/kfileaudiopreview/kfil

Jenkins build is back to stable : kdelibs_frameworks_qt5 #393

2013-02-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-11 Thread Stephen Kelly
David Faure wrote: > On Sunday 10 February 2013 23:35:53 Stephen Kelly wrote: >> Especially as I see on the wiki link you posted, the recommendation is to >> configure it with tests. Why do we instruct people build all Qt tests? >> That's pure timewasting. > > OK, I guess not everyone compiling K

Re: khtml uses qx11info_x11 without checking for qtx11support

2013-02-11 Thread David Faure
On Sunday 10 February 2013 23:35:53 Stephen Kelly wrote: > Especially as I see on the wiki link you posted, the recommendation is to > configure it with tests. Why do we instruct people build all Qt tests? > That's pure timewasting. OK, I guess not everyone compiling KF5 will contribute to Qt as

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
[adding frameworks list, slipped out] On Monday, February 11, 2013 10:49:08 Sebastian Kügler wrote: > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > > Apparently not. I've looked at where the example import

Re: kdelibs[frameworks] build failure in kwindowsystem and others

2013-02-11 Thread Sebastian Kügler
On Monday, February 11, 2013 10:21:07 Stephen Kelly wrote: > Sebastian Kügler wrote: > > I'm getting the following build errors in kdelibs[frameworks] since > > yesterday. It seems the CI system doesn't pick it up (or hasn't yet): > > > > [ 22%] Building CXX object > > tier1/kwindowsystem/src/CMak

Re: kdelibs[frameworks] build failure in kwindowsystem and others

2013-02-11 Thread Stephen Kelly
Sebastian Kügler wrote: > I'm getting the following build errors in kdelibs[frameworks] since > yesterday. It seems the CI system doesn't pick it up (or hasn't yet): > > [ 22%] Building CXX object > tier1/kwindowsystem/src/CMakeFiles/kwindowsystem.dir/kwindowsystem_x11.cpp.o > /home/sebas/kf5/sr

kdelibs[frameworks] build failure in kwindowsystem and others

2013-02-11 Thread Sebastian Kügler
I'm getting the following build errors in kdelibs[frameworks] since yesterday. It seems the CI system doesn't pick it up (or hasn't yet): [ 22%] Building CXX object tier1/kwindowsystem/src/CMakeFiles/kwindowsystem.dir/kwindowsystem_x11.cpp.o /home/sebas/kf5/src/kdelibs/tier1/kwindowsystem/src/km